Upgrade to Pro — share decks privately, control downloads, hide ads and more …

誰が為のPull Requestか？

Avatar for Hiroya Hinomori(KTC) Hiroya Hinomori(KTC)
May 15, 2024
0
100

誰が為のPull Requestか？

Avatar for Hiroya Hinomori(KTC)

Hiroya Hinomori(KTC)

May 15, 2024
Tweet

More Decks by Hiroya Hinomori(KTC)

See All by Hiroya Hinomori(KTC)
iOSDC初出展までにした事を共有したい
Avatar for Hiroya Hinomori(KTC) ktchiroyah
0
110
エンジニアが開発生産性を上げるためにやる最初の一歩
Avatar for Hiroya Hinomori(KTC) ktchiroyah
0
320
内製化でクルマの未来を作るぼくらの話
Avatar for Hiroya Hinomori(KTC) ktchiroyah
0
82

Featured

See All Featured
Fight the Zombie Pattern Library - RWD Summit 2016
Avatar for Marcelo Somers marcelosomers
234
17k
What's in a price? How to price your products and services
Avatar for Michael Herold michaelherold
247
13k
Evolution of real-time – Irina Nazarova, EuRuKo, 2024
Avatar for Irina Nazarova irinanazarova
9
1.1k
Mozcon NYC 2025: Stop Losing SEO Traffic
Avatar for Sam Torres samtorres
0
120
How to Build an AI Search Optimization Roadmap - Criteria and Steps to Take #SEOIRL
Avatar for Aleyda Solis aleyda
1
1.8k
AI Search:
Where Are We & What Can We Do About It?
Avatar for Aleyda Solis aleyda
0
6.9k
How to build an LLM SEO readiness audit: a practical framework
Avatar for Nick Samuel nmsamuel
1
620
Data-driven link building: lessons from a $708K investment (BrightonSEO talk)
Avatar for Szymon szymonslowik
1
890
The Power of CSS Pseudo Elements
Avatar for Geoffrey Crofte geoffreycrofte
80
6.1k
YesSQL, Process and Tooling at Scale
Avatar for Rocio Delgado rocio
174
15k
Everyday Curiosity
Avatar for Cassini Nazir cassininazir
0
120
Noah Learner - AI + Me: how we built a GSC Bulk Export data pipeline
Avatar for Tech SEO Connect techseoconnect
PRO
0
90

Transcript

  1. 誰が為の Pull Requestか？ モバイル開発グループ 日野森 寛也

  2. みなさん

  3. Pull Request をお願いする時

  4. 自分が書いたコードを ちゃんと説明できてますか？

  5. コード書いたんだから見てよ！ 急いでるから早くApproveくださいいい！

  6. Point 1 PRの中に入れる変更内容は そのPRに沿った内容になっているか？

  7. Point2 難しい仕様や、伝わりづらそうな実装内容に コメントを添える

  8. Point3 PRのテンプレートをうまく活用していきましょう

  9. 🍶