Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Review is DEAD
Search
Tatsuya Sato
November 05, 2014
Technology
19
710
Review is DEAD
社内で開催されたコードレビューの勉強会のLTで使った資料
Tatsuya Sato
November 05, 2014
Tweet
Share
More Decks by Tatsuya Sato
See All by Tatsuya Sato
受託開発受注のためのちょっとしたコツ 〜「何でもかんでもやります」じゃなく、まずはデモ〜 / demonstation first
satoryu
0
1.5k
これが私のXP 〜 eXtreme Punning 〜 変化をウケろ / this is my XP
satoryu
1
1.9k
音のような言葉 〜ちゃちゃっとチャットで楽しむちょっとしたコツ〜 / words like sounds
satoryu
1
3.6k
ふらっと立ち寄れる 廊下のある風景 - フラットでオープンネスがもたらす魅力 / The Corridor
satoryu
1
2.8k
Make it fun
satoryu
1
4k
なぜ私はチームにい続けるのか。あるいは、エンジニアとしての成長のためのチームの活用について。 / Why I continue to be in the team #RSGT2021
satoryu
0
6.3k
リモート時代のソロプログラミング - soloprogramming for work from home
satoryu
0
1.3k
Why do you fear contributing OSS? #xpjug
satoryu
5
12k
あるOSSの死と再生、それとこれから先 / How an OSS also arises
satoryu
0
310
Other Decks in Technology
See All in Technology
生成AIでwebアプリケーションを作ってみた
tajimon
2
150
Agentic Workflowという選択肢を考える
tkikuchi1002
1
490
A2Aのクライアントを自作する
rynsuke
1
170
AWS アーキテクチャ作図入門/aws-architecture-diagram-101
ma2shita
29
11k
“社内”だけで完結していた私が、AWS Community Builder になるまで
nagisa53
1
380
VISITS_AIIoTビジネス共創ラボ登壇資料.pdf
iotcomjpadmin
0
160
変化する開発、進化する体系時代に適応するソフトウェアエンジニアの知識と考え方(JaSST'25 Kansai)
mizunori
1
210
【TiDB GAME DAY 2025】Shadowverse: Worlds Beyond にみる TiDB 活用術
cygames
0
1.1k
Uniadex__公開版_20250617-AIxIoTビジネス共創ラボ_ツナガルチカラ_.pdf
iotcomjpadmin
0
160
PHP開発者のためのSOLID原則再入門 #phpcon / PHP Conference Japan 2025
shogogg
4
730
生成AIで小説を書くためにプロンプトの制約や原則について学ぶ / prompt-engineering-for-ai-fiction
nwiizo
3
1.2k
地図も、未来も、オープンに。 〜OSGeo.JPとFOSS4Gのご紹介〜
wata909
0
110
Featured
See All Featured
Build your cross-platform service in a week with App Engine
jlugia
231
18k
Why Our Code Smells
bkeepers
PRO
337
57k
Bootstrapping a Software Product
garrettdimon
PRO
307
110k
Reflections from 52 weeks, 52 projects
jeffersonlam
351
20k
Visualizing Your Data: Incorporating Mongo into Loggly Infrastructure
mongodb
46
9.6k
The Cult of Friendly URLs
andyhume
79
6.5k
Practical Tips for Bootstrapping Information Extraction Pipelines
honnibal
PRO
20
1.3k
Building a Scalable Design System with Sketch
lauravandoore
462
33k
[RailsConf 2023] Rails as a piece of cake
palkan
55
5.6k
Building Applications with DynamoDB
mza
95
6.5k
No one is an island. Learnings from fostering a developers community.
thoeni
21
3.3k
Product Roadmaps are Hard
iamctodd
PRO
54
11k
Transcript
Review is DEAD Tatsuya “Botcher” Sato
Who I am • Tatsuya “Botcher” Sato • @sato_ryu •
Rubyist & Scrum Master
Botcher? ʲ໊ʳ ʪӳʫ΅৬ਓɺमཧͷԼखͳਓ
NO
ʲ໊ʳ΅ͬͪͳਓ
Review is Evil ϨϏϡʔѱ
Evil Reviews
Evil Reviews Code Review Specification Review Design Review
Review as a Gate
When the evils appear Specification Design Code
When the evils appear Specification Design Code Review Review Review
When the evils appear Specification Design Code Review Review Review
• Each Review stops the progress. • Each Review makes us go back to the beginning.
“The GateKeeper” Reviewer
“The GateKeeper” Reviewer • “Reviewer” vs “Reviewee” • Reviewer believes
s/he SHOULD point out anything as possible. • Review makes UNWISHED WARS.
Diversity of Background
Diversity of Background • Pros • Diversity of view points
• Cons • Need communications for CONSENSUS.
All Reviews Should be Passed
Wastes much time…
–Wikipedia http://en.wikipedia.org/wiki/Development_hell “development hell is a state during which a
film or other project remains in development without progressing to production.”
Review is Evil ϨϏϡʔѱ
ॾ܅ɺ ඞཁͳ͜ͱ Կ͔ʁ
Consensus
Consensus • σϓϩΠͯ͠ྑ͍ͱ͍͏߹ҙ • ίʔυʹࣗ৴Λ࣋ͯΔͱ͍͏߹ҙ
Review is DEAD?
Review is still Alive ϨϏϡʔੜ͖͍ͯΔɻ
Code Review is alive
Discovery increases over phases Specification Design Code Discovery
Code Review is still alive • Two passback do NOT
make sense. • But pass back from Code Review has emergency but valuable Specification Design Code Review Review Review
How? Ͳ͏Δͷ͔ʁ
Backlog Refinement
Backlog Refinement • The process through which product backlog items
are reviewed by the Scrum team and revised, providing more detail and ensuring that there is greater clarity in the requirements for that item.
Collaborative or Not? Specification Design Code
Discuss all members not only developers, involve a product owner.
–ɹBABYMETAL “ΠδϝɺμϝɺθολΠ” ΑΓ “ΠδϝɺμϝɺθολΠ”