Upgrade to PRO for Only $50/Year—Limited-Time Offer! 🔥
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code review - English version
Search
Sébastien Charrier
October 20, 2017
Programming
0
67
Code review - English version
Is code review a fucking waste of time?
Video [FR]:
https://www.youtube.com/watch?v=6aQK6GoTbxM
Sébastien Charrier
October 20, 2017
Tweet
Share
More Decks by Sébastien Charrier
See All by Sébastien Charrier
Prenez la parole !
scharrier
0
170
Code review - DevFest Nantes
scharrier
3
680
Tous UX designers !
scharrier
1
310
Angers.io - 8 mois après le lancement
scharrier
0
92
De l'idée au produit pour 4999€
scharrier
0
150
Web et vie privée
scharrier
0
80
Mainelabs en 1 an
scharrier
0
88
Remote
scharrier
4
160
Comment (ne pas) foirer un produit en beauté - Blendwebmix
scharrier
1
240
Other Decks in Programming
See All in Programming
Microservices rules: What good looks like
cer
PRO
0
120
Module Harmony
petamoriken
2
580
テストやOSS開発に役立つSetup PHP Action
matsuo_atsushi
0
110
251126 TestState APIってなんだっけ?Step Functionsテストどう変わる?
east_takumi
0
290
AIエージェントでのJava開発がはかどるMCPをAIを使って開発してみた / java mcp for jjug
kishida
4
830
MAP, Jigsaw, Code Golf 振り返り会 by 関東Kaggler会|Jigsaw 15th Solution
hasibirok0
0
180
JEP 496 と JEP 497 から学ぶ耐量子計算機暗号入門 / Learning Post-Quantum Crypto Basics from JEP 496 & 497
mackey0225
2
510
Stay Hacker 〜九州で生まれ、Perlに出会い、コミュニティで育つ〜
pyama86
2
3.1k
Microservices Platforms: When Team Topologies Meets Microservices Patterns
cer
PRO
1
720
All(?) About Point Sets
hole
0
230
Building AI with AI
inesmontani
PRO
1
430
Media Capture and Streams: W3C仕様と現場での知見
nowaki28
0
100
Featured
See All Featured
Sharpening the Axe: The Primacy of Toolmaking
bcantrill
46
2.6k
Java REST API Framework Comparison - PWX 2021
mraible
34
9k
Stop Working from a Prison Cell
hatefulcrawdad
273
21k
Building Better People: How to give real-time feedback that sticks.
wjessup
370
20k
How Fast Is Fast Enough? [PerfNow 2025]
tammyeverts
3
360
How GitHub (no longer) Works
holman
316
140k
A better future with KSS
kneath
239
18k
Rebuilding a faster, lazier Slack
samanthasiow
84
9.3k
Agile that works and the tools we love
rasmusluckow
331
21k
Site-Speed That Sticks
csswizardry
13
970
Building Applications with DynamoDB
mza
96
6.8k
A Modern Web Designer's Workflow
chriscoyier
697
190k
Transcript
#CODE A fucking waste of time. DEVFEST NANTES - 20/10/2017
REVIEW
Sébastien Charrier scharrier
None
BACK TO THE PAST, WHEN WORKING WITH SVN, OR CVS.
CODING WAS FAST
None
GIT, Then, we got GITHUB, GITLAB, BITBUCKET…
SOME GOOD TOOLS TOGETHER TO WORK AND CODE
PULL* REQUEST * or merge
CODE REVIEW Yea. We could do before merging.
Ask a peer to read and validate our code before
merging it into the product.
Fuck, it takes too much time. Your boss
AT LEAST 30% OF MY TIME * personal estimation
None
COSTS Yep, it but…
QUALITY,
CONSISTENCY,
LEARNING.
IT’S AN INVESTMENT. Finally,
There are two important things.
STATE OF MIND
None
We work together to create the best product we can.
GUIDELINES
None
Write code style rules and review rules.
In order to not repeat yourself, and avoid conflicts.
SOME OF MY RULES
FOR EVERYBODY
EMPATHY
STAY HUMBLE EMPATHY
STAY HUMBLE NO IRONY EMPATHY
STAY HUMBLE NO IRONY NO FUCKING INSULTS * * true
story. EMPATHY
None
I AM THE REVIEWER
QUESTIONS, NO ORDERS
QUESTIONS, NO ORDERS BE EXPLICIT
QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF
QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF BE RESPONSIBLE
None
I AM REVIEWED
KEEP PRS SMALL
BE GRATEFUL KEEP PRS SMALL
BE GRATEFUL EXPLAIN YOUR CHOICES KEEP PRS SMALL
BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS KEEP PRS
SMALL
BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS DO NOT
GIVE UP KEEP PRS SMALL
STILL DISAGREE ?
None
CLOSE COMPUTERS AND DISCUSS IRL
OR ASK SOMEBODY ELSE’S POINT OF VIEW.
None
THE FINAL DECISION Finally, let the maintainer take (but do
another PR later.)
THANKS. http://bump.sh Psssst !