Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review - English version

Avatar for Sébastien Charrier Sébastien Charrier
October 20, 2017
Programming
0
60

Code review - English version

Is code review a fucking waste of time?

Video [FR]: https://www.youtube.com/watch?v=6aQK6GoTbxM
Avatar for Sébastien Charrier

Sébastien Charrier

October 20, 2017
Tweet

More Decks by Sébastien Charrier

See All by Sébastien Charrier
Prenez la parole !
Avatar for Sébastien Charrier scharrier
0
160
Code review - DevFest Nantes
Avatar for Sébastien Charrier scharrier
3
670
Tous UX designers !
Avatar for Sébastien Charrier scharrier
1
280
Angers.io - 8 mois après le lancement
Avatar for Sébastien Charrier scharrier
0
88
De l'idée au produit pour 4999€
Avatar for Sébastien Charrier scharrier
0
150
Web et vie privée
Avatar for Sébastien Charrier scharrier
0
71
Mainelabs en 1 an
Avatar for Sébastien Charrier scharrier
0
79
Remote
Avatar for Sébastien Charrier scharrier
4
160
Comment (ne pas) foirer un produit en beauté - Blendwebmix
Avatar for Sébastien Charrier scharrier
1
230

Other Decks in Programming

See All in Programming
20250429 - CNTUG Meetup #67 / DevOps Taiwan Meetup #69 - Deep Dive into Tetragon: Building Runtime Security and Observability with eBPF
Avatar for ChengHao Yang tico88612
0
160
iOSアプリで測る！名古屋駅までの 方向と距離
Avatar for Ryu-nakayama ryunakayama
0
150
generative-ai-use-cases(GenU)の推しポイント ～2025年4月版～
Avatar for Hideyuki Nagata hideg
1
370
KawaiiLT 登壇資料　キャリアとモチベーション
Avatar for 柊 hiiragi
0
160
インプロセスQAにおいて大事にしていること / In-process QA Meetup
Avatar for MEDLEY, INC. medley
0
140
音声プラットフォームのアーキテクチャ変遷から学ぶ、クラウドネイティブなバッチ処理 (20250422_CNDS2025_Batch_Architecture)
Avatar for Koki Senda thousanda
0
380
エンジニアが挑む、限界までの越境
Avatar for Nealle nealle
1
310
AIコーディングエージェントを 「使いこなす」ための実践知と現在地 in ログラス / How to Use AI Coding Agent in Loglass
Avatar for r-kagaya rkaga
4
1.2k
Golangci-lint v2爆誕: 君たちはどうすべきか
Avatar for logica / Takuto Nagami logica0419
1
230
UMAPをざっくりと理解 / Overview of UMAP
Avatar for kaityo256 kaityo256
PRO
3
1.4k
今話題のMCPサーバーをFastAPIでサッと作ってみた
Avatar for Yuuki Shimizu yuukis
0
110
一緒に働きたくなるプログラマの思想 #QiitaConference
Avatar for mu_zaru mu_zaru
78
20k

Featured

See All Featured
Why Our Code Smells
Avatar for Brandon Keepers bkeepers
PRO
336
57k
Testing 201, or: Great Expectations
Avatar for Joseph Mastey jmmastey
42
7.5k
Sharpening the Axe: The Primacy of Toolmaking
Avatar for Bryan Cantrill bcantrill
41
2.3k
How to Ace a Technical Interview
Avatar for Jacob Kaplan-Moss jacobian
276
23k
How to train your dragon (web standard)
Avatar for Monica Dinculescu notwaldorf
91
6k
[RailsConf 2023] Rails as a piece of cake
Avatar for Vladimir Dementyev palkan
54
5.5k
Statistics for Hackers
Avatar for Jake VanderPlas jakevdp
798
220k
Building Adaptive Systems
Avatar for Chris Keathley keathley
41
2.5k
Measuring & Analyzing Core Web Vitals
Avatar for Philip Tellis bluesmoon
7
410
We Have a Design System, Now What?
Avatar for Morgane Peng morganepeng
52
7.5k
The Cost Of JavaScript in 2023
Avatar for Addy Osmani addyosmani
49
7.8k
Templates, Plugins, & Blocks: Oh My! Creating the theme that thinks of everything
Avatar for Michelle Schulp Hunt marktimemedia
30
2.3k

Transcript

  1. #CODE A fucking waste of time. DEVFEST NANTES - 20/10/2017

    REVIEW

  2. Sébastien 
 Charrier scharrier

  3. None

  4. BACK TO THE PAST, WHEN WORKING WITH SVN, OR CVS.

  5. CODING WAS FAST

  6. None

  7. GIT, Then, we got GITHUB, GITLAB, BITBUCKET…

  8. SOME GOOD TOOLS TOGETHER TO WORK AND CODE

  9. PULL* REQUEST * or merge

  10. CODE REVIEW Yea. We could do before merging.

  11. Ask a peer to read and validate our code before

    merging it into the product.

  12. Fuck, it takes too much time. Your boss

  13. AT LEAST 30% OF MY TIME * personal estimation

  14. None

  15. COSTS Yep, it but…

  16. QUALITY,

  17. CONSISTENCY,

  18. LEARNING.

  19. IT’S AN INVESTMENT. Finally,

  20. There are two important things.

  21. STATE OF MIND

  22. None

  23. We work together to create the best product we can.

  24. GUIDELINES

  25. None

  26. Write code style rules and review rules.

  27. In order to not repeat yourself, and avoid conflicts.

  28. SOME OF MY RULES

  29. FOR EVERYBODY

  30. EMPATHY

  31. STAY HUMBLE EMPATHY

  32. STAY HUMBLE NO IRONY EMPATHY

  33. STAY HUMBLE NO IRONY NO FUCKING INSULTS * * true

    story. EMPATHY
  34. None

  35. I AM THE REVIEWER

  36. QUESTIONS, NO ORDERS

  37. QUESTIONS, NO ORDERS BE EXPLICIT

  38. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF

  39. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF BE RESPONSIBLE

  40. None

  41. I AM REVIEWED

  42. KEEP PRS SMALL

  43. BE GRATEFUL KEEP PRS SMALL

  44. BE GRATEFUL EXPLAIN YOUR CHOICES KEEP PRS SMALL

  45. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS KEEP PRS

    SMALL

  46. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS DO NOT

    GIVE UP KEEP PRS SMALL

  47. STILL DISAGREE ?

  48. None

  49. CLOSE COMPUTERS AND DISCUSS IRL

  50. OR ASK SOMEBODY ELSE’S POINT OF VIEW.

  51. None

  52. THE FINAL DECISION Finally, let the maintainer take (but do

    another PR later.)

  53. THANKS. http://bump.sh Psssst !