Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review - English version

Sponsored · SiteGround - Reliable hosting with speed, security, and support you can count on. →
Avatar for Sébastien Charrier Sébastien Charrier
October 20, 2017
Programming
0
72

Code review - English version

Is code review a fucking waste of time?

Video [FR]: https://www.youtube.com/watch?v=6aQK6GoTbxM

Avatar for Sébastien Charrier

Sébastien Charrier

October 20, 2017
Tweet

More Decks by Sébastien Charrier

See All by Sébastien Charrier
Prenez la parole !
Avatar for Sébastien Charrier scharrier
0
170
Code review - DevFest Nantes
Avatar for Sébastien Charrier scharrier
3
690
Tous UX designers !
Avatar for Sébastien Charrier scharrier
1
340
Angers.io - 8 mois après le lancement
Avatar for Sébastien Charrier scharrier
0
99
De l'idée au produit pour 4999€
Avatar for Sébastien Charrier scharrier
0
160
Web et vie privée
Avatar for Sébastien Charrier scharrier
0
85
Mainelabs en 1 an
Avatar for Sébastien Charrier scharrier
0
97
Remote
Avatar for Sébastien Charrier scharrier
4
170
Comment (ne pas) foirer un produit en beauté - Blendwebmix
Avatar for Sébastien Charrier scharrier
1
240

Other Decks in Programming

See All in Programming
2026年は Rust 置き換えが流行る！ / 20260220-niigata-5min-tech
Avatar for girigiribauer girigiribauer
0
230
DSPy入門 Pythonで実現する自動プロンプト最適化 〜人手によるプロンプト調整からの卒業〜
Avatar for sea-turt1e seaturt1e
1
610
go directiveを最新にしすぎないで欲しい話──あるいは、Go 1.26からgo mod initで作られるgo directiveの値が変わる話 / Go 1.26 リリースパーティ
Avatar for Arthur arthur1
2
510
CDIの誤解しがちな仕様とその対処TIPS
Avatar for futokiyo futokiyo
0
190
Claude Code、ちょっとした工夫で開発体験が変わる
Avatar for Toranosuke Minamikawa tigertora7571
0
200
エラーログのマスキングの仕組みづくりに役立ったASTの話
Avatar for Kenichi Shihota kumoichi
0
120
ベクトル検索のフィルタを用いた機械学習モデルとの統合 / python-meetup-fukuoka-06-vector-attr
Avatar for monochromegane monochromegane
2
340
AIに任せる範囲を安全に広げるためにやっていること
Avatar for Masashi Fukuzawa fukucheee
0
120
コーディングルールの鮮度を保ちたい / keep-fresh-go-internal-conventions
Avatar for NAGATA Hiroaki handlename
0
170
Swift ConcurrencyでよりSwiftyに
Avatar for 野瀬田　裕樹 yuukiw00w
0
250
手戻りゼロ？ Spec Driven Developmentとは@KAG AI week
Avatar for Tomoki Hirai tmhirai
1
170
Codex の「自走力」を高める
Avatar for yorifuji yorifuji
0
1.1k

Featured

See All Featured
Gemini Prompt Engineering: Practical Techniques for Tangible AI Outcomes
Avatar for Mfonobong Umondia mfonobong
2
310
Side Projects
Avatar for Sacha Greif sachag
455
43k
The Art of Delivering Value - GDevCon NA Keynote
Avatar for David Neal reverentgeek
16
1.9k
Conquering PDFs: document understanding beyond plain text
Avatar for Ines Montani inesmontani
PRO
4
2.4k
[RailsConf 2023] Rails as a piece of cake
Avatar for Vladimir Dementyev palkan
59
6.4k
Color Theory Basics | Prateek | Gurzu
Avatar for Gurzu gurzu
0
240
Test your architecture with Archunit
Avatar for Yoan thirion
1
2.2k
A brief & incomplete history of 
UX Design for the World Wide Web: 1989–2019
Avatar for Jason CranfordTeague jct
1
320
[SF Ruby Conf 2025] Rails X
Avatar for Vladimir Dementyev palkan
2
820
The Myth of the Modular Monolith - Day 2 Keynote - Rails World 2024
Avatar for Eileen M. Uchitelle eileencodes
26
3.4k
How To Speak Unicorn (iThemes Webinar)
Avatar for Michelle Schulp Hunt marktimemedia
1
400
How Fast Is Fast Enough? [PerfNow 2025]
Avatar for Tammy Everts tammyeverts
3
480

Transcript

  1. #CODE A fucking waste of time. DEVFEST NANTES - 20/10/2017

    REVIEW

  2. Sébastien 
 Charrier scharrier

  3. None

  4. BACK TO THE PAST, WHEN WORKING WITH SVN, OR CVS.

  5. CODING WAS FAST

  6. None

  7. GIT, Then, we got GITHUB, GITLAB, BITBUCKET…

  8. SOME GOOD TOOLS TOGETHER TO WORK AND CODE

  9. PULL* REQUEST * or merge

  10. CODE REVIEW Yea. We could do before merging.

  11. Ask a peer to read and validate our code before

    merging it into the product.

  12. Fuck, it takes too much time. Your boss

  13. AT LEAST 30% OF MY TIME * personal estimation

  14. None

  15. COSTS Yep, it but…

  16. QUALITY,

  17. CONSISTENCY,

  18. LEARNING.

  19. IT’S AN INVESTMENT. Finally,

  20. There are two important things.

  21. STATE OF MIND

  22. None

  23. We work together to create the best product we can.

  24. GUIDELINES

  25. None

  26. Write code style rules and review rules.

  27. In order to not repeat yourself, and avoid conflicts.

  28. SOME OF MY RULES

  29. FOR EVERYBODY

  30. EMPATHY

  31. STAY HUMBLE EMPATHY

  32. STAY HUMBLE NO IRONY EMPATHY

  33. STAY HUMBLE NO IRONY NO FUCKING INSULTS * * true

    story. EMPATHY
  34. None

  35. I AM THE REVIEWER

  36. QUESTIONS, NO ORDERS

  37. QUESTIONS, NO ORDERS BE EXPLICIT

  38. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF

  39. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF BE RESPONSIBLE

  40. None

  41. I AM REVIEWED

  42. KEEP PRS SMALL

  43. BE GRATEFUL KEEP PRS SMALL

  44. BE GRATEFUL EXPLAIN YOUR CHOICES KEEP PRS SMALL

  45. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS KEEP PRS

    SMALL

  46. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS DO NOT

    GIVE UP KEEP PRS SMALL

  47. STILL DISAGREE ?

  48. None

  49. CLOSE COMPUTERS AND DISCUSS IRL

  50. OR ASK SOMEBODY ELSE’S POINT OF VIEW.

  51. None

  52. THE FINAL DECISION Finally, let the maintainer take (but do

    another PR later.)

  53. THANKS. http://bump.sh Psssst !