Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review - English version

Avatar for Sébastien Charrier Sébastien Charrier
October 20, 2017
Programming
0
62

Code review - English version

Is code review a fucking waste of time?

Video [FR]: https://www.youtube.com/watch?v=6aQK6GoTbxM
Avatar for Sébastien Charrier

Sébastien Charrier

October 20, 2017
Tweet

More Decks by Sébastien Charrier

See All by Sébastien Charrier
Prenez la parole !
Avatar for Sébastien Charrier scharrier
0
160
Code review - DevFest Nantes
Avatar for Sébastien Charrier scharrier
3
680
Tous UX designers !
Avatar for Sébastien Charrier scharrier
1
290
Angers.io - 8 mois après le lancement
Avatar for Sébastien Charrier scharrier
0
90
De l'idée au produit pour 4999€
Avatar for Sébastien Charrier scharrier
0
150
Web et vie privée
Avatar for Sébastien Charrier scharrier
0
77
Mainelabs en 1 an
Avatar for Sébastien Charrier scharrier
0
81
Remote
Avatar for Sébastien Charrier scharrier
4
160
Comment (ne pas) foirer un produit en beauté - Blendwebmix
Avatar for Sébastien Charrier scharrier
1
230

Other Decks in Programming

See All in Programming
商品比較サービス「マイベスト」における パーソナライズレコメンドの第一歩
Avatar for Ucchiii ucchiii43
0
180
DMMを支える決済基盤の技術的負債にどう立ち向かうか / Addressing Technical Debt in Payment Infrastructure
Avatar for yoshiyoshifujii yoshiyoshifujii
4
420
「App Intent」よくわからんけどすごい！
Avatar for rinngo rinngo0302
1
110
[SRE NEXT] 複雑なシステムにおけるUser Journey SLOの導入
Avatar for yakenji yakenji
0
150
Claude Code派？Gemini CLI派？ みんなで比較LT会！_20250716
Avatar for じゅん junholee
1
550
GPUを計算資源として使おう！
Avatar for prime number primenumber
1
250
おやつのお供はお決まりですか？@WWDC25 Recap -Japan-\(region).swift
Avatar for gangan shingangan
0
140
「次に何を学べばいいか分からない」あなたへ──若手エンジニアのための学習地図
Avatar for panda_program panda_program
1
290
リバースエンジニアリング新時代へ！
GhidraとClaude DesktopをMCPで繋ぐ/findy202507
Avatar for @tkmru tkmru
3
1k
構文解析器入門
Avatar for ydah ydah
3
330
イベントストーミング図からコードへの変換手順 / Procedure for Converting Event Storming Diagrams to Code
Avatar for nrs nrslib
2
1.1k
AI Agent 時代のソフトウェア開発を支える AWS Cloud Development Kit (CDK)
Avatar for Kenji Kono konokenj
6
810

Featured

See All Featured
Let's Do A Bunch of Simple Stuff to Make Websites Faster
Avatar for Chris Coyier chriscoyier
507
140k
実際に使うSQLの書き方 徹底解説 / pgcon21j-tutorial
Avatar for soudai sone soudai
PRO
181
54k
The Language of Interfaces
Avatar for Des Traynor destraynor
158
25k
Helping Users Find Their Own Way: Creating Modern Search Experiences
Avatar for Dan Newman danielanewman
29
2.7k
Automating Front-end Workflow
Avatar for Addy Osmani addyosmani
1370
200k
Balancing Empowerment & Direction
Avatar for Lara Hogan lara
1
460
Visualization
Avatar for Eitan Lees eitanlees
146
16k
VelocityConf: Rendering Performance Case Studies
Avatar for Addy Osmani addyosmani
332
24k
Become a Pro
Avatar for Speaker Deck speakerdeck
PRO
29
5.4k
ReactJS: Keep Simple. Everything can be a component!
Avatar for Pedro Nauck pedronauck
667
120k
The Cult of Friendly URLs
Avatar for Andy Hume andyhume
79
6.5k
It's Worth the Effort
Avatar for 3n 3n
185
28k

Transcript

  1. #CODE A fucking waste of time. DEVFEST NANTES - 20/10/2017

    REVIEW

  2. Sébastien 
 Charrier scharrier

  3. None

  4. BACK TO THE PAST, WHEN WORKING WITH SVN, OR CVS.

  5. CODING WAS FAST

  6. None

  7. GIT, Then, we got GITHUB, GITLAB, BITBUCKET…

  8. SOME GOOD TOOLS TOGETHER TO WORK AND CODE

  9. PULL* REQUEST * or merge

  10. CODE REVIEW Yea. We could do before merging.

  11. Ask a peer to read and validate our code before

    merging it into the product.

  12. Fuck, it takes too much time. Your boss

  13. AT LEAST 30% OF MY TIME * personal estimation

  14. None

  15. COSTS Yep, it but…

  16. QUALITY,

  17. CONSISTENCY,

  18. LEARNING.

  19. IT’S AN INVESTMENT. Finally,

  20. There are two important things.

  21. STATE OF MIND

  22. None

  23. We work together to create the best product we can.

  24. GUIDELINES

  25. None

  26. Write code style rules and review rules.

  27. In order to not repeat yourself, and avoid conflicts.

  28. SOME OF MY RULES

  29. FOR EVERYBODY

  30. EMPATHY

  31. STAY HUMBLE EMPATHY

  32. STAY HUMBLE NO IRONY EMPATHY

  33. STAY HUMBLE NO IRONY NO FUCKING INSULTS * * true

    story. EMPATHY
  34. None

  35. I AM THE REVIEWER

  36. QUESTIONS, NO ORDERS

  37. QUESTIONS, NO ORDERS BE EXPLICIT

  38. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF

  39. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF BE RESPONSIBLE

  40. None

  41. I AM REVIEWED

  42. KEEP PRS SMALL

  43. BE GRATEFUL KEEP PRS SMALL

  44. BE GRATEFUL EXPLAIN YOUR CHOICES KEEP PRS SMALL

  45. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS KEEP PRS

    SMALL

  46. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS DO NOT

    GIVE UP KEEP PRS SMALL

  47. STILL DISAGREE ?

  48. None

  49. CLOSE COMPUTERS AND DISCUSS IRL

  50. OR ASK SOMEBODY ELSE’S POINT OF VIEW.

  51. None

  52. THE FINAL DECISION Finally, let the maintainer take (but do

    another PR later.)

  53. THANKS. http://bump.sh Psssst !