Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review - English version

Sébastien Charrier
October 20, 2017
Programming
0
56

Code review - English version

Is code review a fucking waste of time?

Video [FR]: https://www.youtube.com/watch?v=6aQK6GoTbxM

Sébastien Charrier

October 20, 2017
Tweet

More Decks by Sébastien Charrier

See All by Sébastien Charrier
Prenez la parole !
scharrier
0
160
Code review - DevFest Nantes
scharrier
3
660
Tous UX designers !
scharrier
1
260
Angers.io - 8 mois après le lancement
scharrier
0
86
De l'idée au produit pour 4999€
scharrier
0
150
Web et vie privée
scharrier
0
67
Mainelabs en 1 an
scharrier
0
76
Remote
scharrier
4
150
Comment (ne pas) foirer un produit en beauté - Blendwebmix
scharrier
1
220

Other Decks in Programming

See All in Programming
Linux && Docker 研修/Linux && Docker training
forrep
24
4.5k
ARA Ansible for the teams
kksat
0
150
AIの力でお手軽Chrome拡張機能作り
taiseiue
0
170
『テスト書いた方が開発が早いじゃん』を解き明かす #phpcon_nagoya
o0h
PRO
2
290
バックエンドのためのアプリ内課金入門 (サブスク編)
qnighy
8
1.8k
GAEログのコスト削減
mot_techtalk
0
120
ソフトウェアエンジニアの成長
masuda220
PRO
12
1.7k
苦しいTiDBへの移行を乗り越えて快適な運用を目指す
leveragestech
0
630
密集、ドキュメントのコロケーション with AWS Lambda
satoshi256kbyte
0
190
Kubernetes History Inspector(KHI)を触ってみた
bells17
0
230
第3回 Snowflake 中部ユーザ会 - dbt × Snowflake ハンズオン
hoto17296
4
370
Honoをフロントエンドで使う 3つのやり方
yusukebe
7
3.3k

Featured

See All Featured
Rebuilding a faster, lazier Slack
samanthasiow
80
8.8k
GraphQLとの向き合い方2022年版
quramy
44
13k
Distributed Sagas: A Protocol for Coordinating Microservices
caitiem20
330
21k
JavaScript: Past, Present, and Future - NDC Porto 2020
reverentgeek
47
5.2k
A Modern Web Designer's Workflow
chriscoyier
693
190k
Gamification - CAS2011
davidbonilla
80
5.1k
Side Projects
sachag
452
42k
The Success of Rails: Ensuring Growth for the Next 100 Years
eileencodes
44
7k
The Cost Of JavaScript in 2023
addyosmani
47
7.3k
What's in a price? How to price your products and services
michaelherold
244
12k
Easily Structure & Communicate Ideas using Wireframe
afnizarnur
193
16k
Speed Design
sergeychernyshev
27
790

Transcript

  1. #CODE A fucking waste of time. DEVFEST NANTES - 20/10/2017

    REVIEW

  2. Sébastien 
 Charrier scharrier

  3. None

  4. BACK TO THE PAST, WHEN WORKING WITH SVN, OR CVS.

  5. CODING WAS FAST

  6. None

  7. GIT, Then, we got GITHUB, GITLAB, BITBUCKET…

  8. SOME GOOD TOOLS TOGETHER TO WORK AND CODE

  9. PULL* REQUEST * or merge

  10. CODE REVIEW Yea. We could do before merging.

  11. Ask a peer to read and validate our code before

    merging it into the product.

  12. Fuck, it takes too much time. Your boss

  13. AT LEAST 30% OF MY TIME * personal estimation

  14. None

  15. COSTS Yep, it but…

  16. QUALITY,

  17. CONSISTENCY,

  18. LEARNING.

  19. IT’S AN INVESTMENT. Finally,

  20. There are two important things.

  21. STATE OF MIND

  22. None

  23. We work together to create the best product we can.

  24. GUIDELINES

  25. None

  26. Write code style rules and review rules.

  27. In order to not repeat yourself, and avoid conflicts.

  28. SOME OF MY RULES

  29. FOR EVERYBODY

  30. EMPATHY

  31. STAY HUMBLE EMPATHY

  32. STAY HUMBLE NO IRONY EMPATHY

  33. STAY HUMBLE NO IRONY NO FUCKING INSULTS * * true

    story. EMPATHY
  34. None

  35. I AM THE REVIEWER

  36. QUESTIONS, NO ORDERS

  37. QUESTIONS, NO ORDERS BE EXPLICIT

  38. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF

  39. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF BE RESPONSIBLE

  40. None

  41. I AM REVIEWED

  42. KEEP PRS SMALL

  43. BE GRATEFUL KEEP PRS SMALL

  44. BE GRATEFUL EXPLAIN YOUR CHOICES KEEP PRS SMALL

  45. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS KEEP PRS

    SMALL

  46. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS DO NOT

    GIVE UP KEEP PRS SMALL

  47. STILL DISAGREE ?

  48. None

  49. CLOSE COMPUTERS AND DISCUSS IRL

  50. OR ASK SOMEBODY ELSE’S POINT OF VIEW.

  51. None

  52. THE FINAL DECISION Finally, let the maintainer take (but do

    another PR later.)

  53. THANKS. http://bump.sh Psssst !