Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review - English version

Avatar for Sébastien Charrier Sébastien Charrier
October 20, 2017
Programming
0
65

Code review - English version

Is code review a fucking waste of time?

Video [FR]: https://www.youtube.com/watch?v=6aQK6GoTbxM

Avatar for Sébastien Charrier

Sébastien Charrier

October 20, 2017
Tweet

More Decks by Sébastien Charrier

See All by Sébastien Charrier
Prenez la parole !
Avatar for Sébastien Charrier scharrier
0
170
Code review - DevFest Nantes
Avatar for Sébastien Charrier scharrier
3
680
Tous UX designers !
Avatar for Sébastien Charrier scharrier
1
300
Angers.io - 8 mois après le lancement
Avatar for Sébastien Charrier scharrier
0
91
De l'idée au produit pour 4999€
Avatar for Sébastien Charrier scharrier
0
150
Web et vie privée
Avatar for Sébastien Charrier scharrier
0
79
Mainelabs en 1 an
Avatar for Sébastien Charrier scharrier
0
84
Remote
Avatar for Sébastien Charrier scharrier
4
160
Comment (ne pas) foirer un produit en beauté - Blendwebmix
Avatar for Sébastien Charrier scharrier
1
240

Other Decks in Programming

See All in Programming
お前も Gemini CLI extensions を作らないか？
Avatar for SatohJohn satohjohn
0
110
alien-signals と自作 OSS で実現する フレームワーク非依存な ロジック共通化の探求 / Exploring Framework-Agnostic Logic Sharing with alien-signals and Custom OSS
Avatar for aose aoseyuu
3
5.6k
Dive into Triton Internals
Avatar for Liam Jongsu Kim appleparan
0
450
O Que É e Como Funciona o PHP-FPM?
Avatar for Marcel dos Santos marcelgsantos
0
250
The Past, Present, and Future of Enterprise Java
Avatar for ivargrimstad ivargrimstad
0
560
contribution to astral-sh/uv
Avatar for Shunsuke Tsuchiya shunsock
0
580
「10分以内に機能を消せる状態」 の実現のためにやっていること
Avatar for おぎ togishima
1
100
SwiftDataを使って10万件のデータを読み書きする
Avatar for akidon0000 akidon0000
0
250
Designing Repeatable Edits: The Architecture of . in Vim
Avatar for Satoru Kitaguchi satorunooshie
0
240
GitHub Copilotを使いこなせ！/mastering_github_copilot!
Avatar for Kota Kageyama kotakageyama
2
780
퇴근 후 1억이 거래되는 서비스 만들기 | 내가 AI를 사용하는 방법
Avatar for Seungmin 마량 maryang
2
470
KoogではじめるAIエージェント開発
Avatar for hiro hiroaki404
1
330

Featured

See All Featured
Docker and Python
Avatar for Tania Allard trallard
46
3.6k
Building a Scalable Design System with Sketch
Avatar for Laura Van Doore lauravandoore
463
33k
Testing 201, or: Great Expectations
Avatar for Joseph Mastey jmmastey
46
7.7k
[RailsConf 2023] Rails as a piece of cake
Avatar for Vladimir Dementyev palkan
57
6k
Designing for humans not robots
Avatar for Tammie Lister tammielis
254
26k
Imperfection Machines: The Place of Print at Facebook
Avatar for Scott Boms scottboms
269
13k
Distributed Sagas: A Protocol for Coordinating Microservices
Avatar for Caitie McCaffrey caitiem20
333
22k
The Psychology of Web Performance [Beyond Tellerrand 2023]
Avatar for Tammy Everts tammyeverts
49
3.2k
Optimizing for Happiness
Avatar for Tom Preston-Werner mojombo
379
70k
A designer walks into a library…
Avatar for Paul Jervis Heath pauljervisheath
209
24k
No one is an island. Learnings from fostering a developers community.
Avatar for Antonio thoeni
21
3.5k
Sharpening the Axe: The Primacy of Toolmaking
Avatar for Bryan Cantrill bcantrill
46
2.5k

Transcript

  1. #CODE A fucking waste of time. DEVFEST NANTES - 20/10/2017

    REVIEW

  2. Sébastien 
 Charrier scharrier

  3. None

  4. BACK TO THE PAST, WHEN WORKING WITH SVN, OR CVS.

  5. CODING WAS FAST

  6. None

  7. GIT, Then, we got GITHUB, GITLAB, BITBUCKET…

  8. SOME GOOD TOOLS TOGETHER TO WORK AND CODE

  9. PULL* REQUEST * or merge

  10. CODE REVIEW Yea. We could do before merging.

  11. Ask a peer to read and validate our code before

    merging it into the product.

  12. Fuck, it takes too much time. Your boss

  13. AT LEAST 30% OF MY TIME * personal estimation

  14. None

  15. COSTS Yep, it but…

  16. QUALITY,

  17. CONSISTENCY,

  18. LEARNING.

  19. IT’S AN INVESTMENT. Finally,

  20. There are two important things.

  21. STATE OF MIND

  22. None

  23. We work together to create the best product we can.

  24. GUIDELINES

  25. None

  26. Write code style rules and review rules.

  27. In order to not repeat yourself, and avoid conflicts.

  28. SOME OF MY RULES

  29. FOR EVERYBODY

  30. EMPATHY

  31. STAY HUMBLE EMPATHY

  32. STAY HUMBLE NO IRONY EMPATHY

  33. STAY HUMBLE NO IRONY NO FUCKING INSULTS * * true

    story. EMPATHY
  34. None

  35. I AM THE REVIEWER

  36. QUESTIONS, NO ORDERS

  37. QUESTIONS, NO ORDERS BE EXPLICIT

  38. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF

  39. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF BE RESPONSIBLE

  40. None

  41. I AM REVIEWED

  42. KEEP PRS SMALL

  43. BE GRATEFUL KEEP PRS SMALL

  44. BE GRATEFUL EXPLAIN YOUR CHOICES KEEP PRS SMALL

  45. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS KEEP PRS

    SMALL

  46. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS DO NOT

    GIVE UP KEEP PRS SMALL

  47. STILL DISAGREE ?

  48. None

  49. CLOSE COMPUTERS AND DISCUSS IRL

  50. OR ASK SOMEBODY ELSE’S POINT OF VIEW.

  51. None

  52. THE FINAL DECISION Finally, let the maintainer take (but do

    another PR later.)

  53. THANKS. http://bump.sh Psssst !