Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
つらくないコードレビューの運用
Search
Kazuhiro Serizawa
May 25, 2016
Programming
43
20k
つらくないコードレビューの運用
コード改善 meetup #1 発表スライドです
Kazuhiro Serizawa
May 25, 2016
Tweet
Share
More Decks by Kazuhiro Serizawa
See All by Kazuhiro Serizawa
Accelerating Machine Learning I/O by Overlapping Data Staging and Mini-batch Generations
serihiro
1
310
hpc170_slide.pdf
serihiro
0
66
画像解像度別ImageNetの100 iterationの合計処理時間比較
serihiro
0
110
深層ニューラルネットワークにおける訓練高速化のための自動最適化
serihiro
0
63
Introduction to Parallel Computing 2.2
serihiro
0
62
My summer internship result at Treasure Data 2018 #td_intern
serihiro
0
2.1k
startupでもrails使うなら これだけはやっとけ的 tips集
serihiro
19
10k
5分で分かるかもしれないjava8 Stream API
serihiro
1
2.3k
Other Decks in Programming
See All in Programming
Devinで実践する!AIエージェントと協働する開発組織の作り方
masahiro_nishimi
6
1.4k
tsconfigのオプションで変わる型世界
keisukeikeda
1
110
Agent Rules as Domain Parser
yodakeisuke
1
130
DevDay2025-OracleDatabase-kernel-addressing-history
oracle4engineer
PRO
5
1.5k
テスト分析入門/Test Analysis Tutorial
goyoki
8
2.4k
primeNumberでのRBS導入の現在 && RBS::Traceでinline RBSを拡充してみた
mnmandahalf
0
120
TSConfigからTypeScriptの世界を覗く
planck16
2
1.2k
RubyKaigi Hack Space in Tokyo & 函館最速 "予習" 会 / RubyKaigi Hack Space in Tokyo & The Fastest Briefing of RubyKaigi 2026 in Hakodate
moznion
1
100
CRUD から CQRS へ ~ 分離が可能にする柔軟性
tkawae
0
200
型安全なDrag and Dropの設計を考える
yudppp
5
610
AI時代のリアーキテクチャ戦略 / Re-architecture Strategy in the AI Era
dachi023
0
180
Reactive Thinking with Signals, Resource API, and httpResource @Devm.io Angular 20 Launch Party
manfredsteyer
PRO
0
110
Featured
See All Featured
Git: the NoSQL Database
bkeepers
PRO
430
65k
Fashionably flexible responsive web design (full day workshop)
malarkey
407
66k
Responsive Adventures: Dirty Tricks From The Dark Corners of Front-End
smashingmag
251
21k
The Myth of the Modular Monolith - Day 2 Keynote - Rails World 2024
eileencodes
24
2.8k
Helping Users Find Their Own Way: Creating Modern Search Experiences
danielanewman
29
2.6k
Speed Design
sergeychernyshev
30
960
Building an army of robots
kneath
305
45k
How to Think Like a Performance Engineer
csswizardry
23
1.6k
10 Git Anti Patterns You Should be Aware of
lemiorhan
PRO
656
60k
Into the Great Unknown - MozCon
thekraken
38
1.8k
What's in a price? How to price your products and services
michaelherold
245
12k
Automating Front-end Workflow
addyosmani
1370
200k
Transcript
ͭΒ͘ͳ͍ ίʔυϨϏϡʔͷӡ༻ ίʔυվળ meetup #1 2016.5.26
About me • Kazuhiro Serizawa • github: serihiro • work
at • serverside engineer • like %i(ruby erlang elixir)
ࠓ͞ͳ͍͜ͱ • ίʔυϨϏϡʔͷ۩ମతͳํ๏ • ޮՌతͳίʔυϨϏϡʔͷํ http://www.slideshare.net/rootmoon/7-37892729 ͓͢͢Ίʂ
ࠓ͢͜ͱ ίʔυϨϏϡʔ ΈΜͳͰΕ ͭΒ͘ͳ͍
ίʔυϨϏϡʔ͋Δ͋Δ • ϨϏϡʔ͓͡͞Μ͕͍Δ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ࠓϨϏϡʔͰ͕̍ऴΘ͓ͬͨʜ
ίʔυϨϏϡʔ͋Δ͋Δ • ༷ʹৄ͍͠ਓ͚͕ͩϨϏϡʔ͍ͯ͠Δ ϨϏϡʔ͓ئ͍͠·͢ʂ ͔͜͜Βͳ͍ΜͰ "͞ΜʹϨϏϡʔ͓ئ͍ͯ͠ ࠓϨϏϡʔָ͕͍͓͠ʜ ͡Ό͋"͞Μ͓ئ͍͠·͢ʂ
ίʔυϨϏϡʔ͋Δ͋Δ • ͰɺproductionͰόά͕ݟ͔ͭΔͱ "͞Μ͕ϨϏϡʔ ͯ͘͠Εͨͷʹʜ ͪΐ͏ͪΐʜͪΐ͏ͪΐʜ "͞Μʜ
ʮϨϏϡʔ͓͡͞Μʯ • ʢ΄΅ʣಛఆͷਓ͚͕ͩϨϏϡʔ͍ͯ͠Δ • ʢ΄΅ʣಛఆͷਓ͚͕ͩϨϏϡʔ͢Δͱ • ಛఆͷਓͷෛ୲͕େ͖ͯͭ͘Β͍ࢥ͍Λ͢Δ • νʔϜͰίʔυͷݟ͕ڞ༗͞Εͳ͍ •
νʔϜϝϯόʔͷϨϏϡʔྗ͕ҭͨͳ͍ • ͍ͭ·Ͱ͋ΒΏΔ͜ͱ͕ଐਓతͰεέʔϧ͠ͳ͍৫ʹ…
ͳͥʮϨϏϡʔ͓͡͞Μʯ͕ ੜ·Εͯ͠·͏ͷ͔ • ৭ʑཧ༝͋Δͱࢥ͍·͢ • ͘ӡ༻ͯ͠ΔͷͰ৽ࢀϝϯόʔ͕͠Βͳ͍͜ͱ͕ଟ͍ • ϝϯόʔͷ࣮ྗ͕ࠩେ͖͍ • ͳΜͱͳ͘
̋̋͞Μ͕Βͳ͍ͱμϝͳؾ͕͢Δ or ࠷ॳʹ࡞ͬͨਓ͕ϨϏϡʔ͠ͳ͍ͱμϝͳؾ͕͢Δ or ͓ͬ͞Μ͕ϨϏϡʔ͠ͳ͍ͱμϝͳؾ͕͢Δ
Ͱ͜Εͬͯ ͜͏͢Εղܾ͢ΔͷͰʁ • ͘ӡ༻ͯ͠ΔͷͰ৽ࢀϝϯόʔ͕͠Βͳ͍ ͜ͱ͕ଟ͍ • ϝϯόʔͷ࣮ྗ͕ࠩେ͖͍ • ͳΜͱͳ͘ →ֶʂ
→͑Ζʂ →ཧ༝͕ͳ͍ͳΒࢭΊΑ͏ʂ
͜ΕΛղܾ͢ΔͨΊͷఏҊ νʔϜશһͰ ϨϏϡʔ͠Α͏
͠νʔϜશһͰϨϏϡʔ͢Δ Α͏ʹͳΔͱ • ୭͕ޓ͍ͷίʔυΛϨϏϡʔ͢Δ • ϓϩμΫτͷ͕ڞ༗͞ΕΔ • ίʔυͷ༷Λ͘ڞ༗͢Δ • ݁Ռͱͯ͠ϨϏϡʔ͓͡͞Μ͕͍ͳ͘ͳΓɺ୭͔
͕ͭΒ͍ࢥ͍Λ͢Δ։ൃͳ͘ͳΔʂ …ͷ͔ʁ
Α͋͘Δݱ࣮ ࣗͷλεΫͰखҰഋͩ ͔ΒϨϏϡʔ͢Δͷେม ࣄͰͦΜͳʹ ษڧͨ͘͠ͳ͍ ͬͺΓԶ͕ϨϏϡʔ͠ͳ͍ͱෆ҆ ͪΌΜͱϨϏϡʔ Ͱ͖Δࣗ৴͕ͳ͍
ͰϨϏϡʔΒͳ͍ͱ Ͱ͖ΔΑ͏ʹͳΔͷ͍͠ʢܦݧ্ʣ • ͷͰͬͺΓνʔϜͰϨϏϡʔΛճͤΔΑ͏ ʹͳͬͯཉ͍͠ͱݸਓతʹࢥ͏ • ͳͷͰνʔϜͰϨϏϡʔΛճ͘͢͢͠Δͨ Ίʹ࣮ࡍʹࢲ͕͍ͬͯΔtipsΛ͍͔ͭ͘հ
ϨϏϡʔͯ͠΄͍͠༰ͷઆ໌Λ ৄࡉʹॻ͘Α͏ʹΈԽ͢Δ • PullRequestͷDescriptionΛςϯϓϨԽ
ϨϏϡΞʔhubotͰ ެฏʹׂΓৼΔ • hubot pluginʰhubot-reviewer-lottoʱΛ͏ https://github.com/sakatam/hubot-reviewer-lotto
ϨϏϡΞʔΛؾݣ͏ • ʮ͜Ε͔ͨ͠͠Β͍͔͠ͳʙʯ ͱࢥͬͨΒϨϏϡΞʔʹΛ͔͚ͯΈΔ • ͓ޓ͍ʹෆ໌ͳΛฉ͖͘͢͢Δ งғؾͮ͘Γ͕ॏཁ
ʮϨϏϡʔ=ษڧͷʯͱͯ͠ ೝࣝ͢Δ • ࢦఠ͢Δ͜ͱ͕ͳ༷ͯ͘ͰΘ͔Βͳ͍ॴ͕͋ͬͨ Βੵۃతʹ࣭͢Δ • ࢦఠ͢Δ͜ͱ͕ͳ࣭ͯ͘͢Δ͚ͩͰϨϏϡΞʔɾ ϨϏϡʔΠํͷؾ͖ͮʹͭͳ͕Δࣄଟ͍ • ʮԿ͔ࢦఠ͠ͳ͍ͱ͍͚ͳ͍ʯͱ͍͏ϓϨογϟʔ͕
͋ΔͱϨϏϡʔͨ͘͠ͳ͘ͳΔɻੵۃతʹΈΜͳͰ࣭ ͋ͬͯͦ͠͏͍͏ϓϨογϟʔΛͳ͘͢͜ͱ͕ॏཁ
ʮϨϏϡʔ=ษڧͷʯͱͯ͠ ೝࣝ͢Δ • ซͤͯಡΈ͍ͨ http://qiita.com/kkoide1332/items/c6ee6f007617114c8f0b
·ͱΊ • ίʔυϨϏϡʔ͓͡͞Μੜ·Ε͍͢ • ίʔυϨϏϡʔ͓͡͞Μ͕͍ΔνʔϜ͍Ζ ͍ΖͭΒ͍ • ΈΜͳͰίʔυϨϏϡʔΛճ͢͜ͱͰɺͭΒ ͍ίʔυϨϏϡʔ͔ΒϝϯόʔʹϝϦοτ͕ ͋ͬͯͭΒ͘ͳ͍ίʔυϨϏϡʔ