Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
つらくないコードレビューの運用
Search
Kazuhiro Serizawa
May 25, 2016
Programming
43
20k
つらくないコードレビューの運用
コード改善 meetup #1 発表スライドです
Kazuhiro Serizawa
May 25, 2016
Tweet
Share
More Decks by Kazuhiro Serizawa
See All by Kazuhiro Serizawa
Accelerating Machine Learning I/O by Overlapping Data Staging and Mini-batch Generations
serihiro
1
310
hpc170_slide.pdf
serihiro
0
64
画像解像度別ImageNetの100 iterationの合計処理時間比較
serihiro
0
110
深層ニューラルネットワークにおける訓練高速化のための自動最適化
serihiro
0
61
Introduction to Parallel Computing 2.2
serihiro
0
60
My summer internship result at Treasure Data 2018 #td_intern
serihiro
0
2.1k
startupでもrails使うなら これだけはやっとけ的 tips集
serihiro
19
10k
5分で分かるかもしれないjava8 Stream API
serihiro
1
2.3k
Other Decks in Programming
See All in Programming
eBPF超入門「o11yに使える」とは (20250424_eBPF_o11y)
thousanda
1
110
Memory API : Patterns, Performance et Cas d'Utilisation
josepaumard
1
170
プロダクト横断分析に役立つ、事前集計しないサマリーテーブル設計
hanon52_
3
530
flutter_kaigi_mini_4.pdf
nobu74658
0
140
エンジニアが挑む、限界までの越境
nealle
1
310
The New Developer Workflow: How AI Transforms Ideas into Code
danielsogl
0
100
2025-04-25 GitHub Copilot Agent ライブデモ(スクリプト)
goataka
0
100
個人開発の学生アプリが企業譲渡されるまで
akidon0000
2
1.1k
Serving TUIs over SSH with Go
caarlos0
0
570
Optimizing JRuby 10
headius
0
570
Dissecting and Reconstructing Ruby Syntactic Structures
ydah
3
2k
RubyKaigi Dev Meeting 2025
tenderlove
1
1.3k
Featured
See All Featured
Improving Core Web Vitals using Speculation Rules API
sergeychernyshev
13
820
YesSQL, Process and Tooling at Scale
rocio
172
14k
Six Lessons from altMBA
skipperchong
28
3.7k
For a Future-Friendly Web
brad_frost
177
9.7k
The Web Performance Landscape in 2024 [PerfNow 2024]
tammyeverts
5
550
Performance Is Good for Brains [We Love Speed 2024]
tammyeverts
10
780
"I'm Feeling Lucky" - Building Great Search Experiences for Today's Users (#IAC19)
danielanewman
227
22k
Measuring & Analyzing Core Web Vitals
bluesmoon
7
410
ReactJS: Keep Simple. Everything can be a component!
pedronauck
667
120k
The Myth of the Modular Monolith - Day 2 Keynote - Rails World 2024
eileencodes
23
2.7k
We Have a Design System, Now What?
morganepeng
52
7.5k
What's in a price? How to price your products and services
michaelherold
245
12k
Transcript
ͭΒ͘ͳ͍ ίʔυϨϏϡʔͷӡ༻ ίʔυվળ meetup #1 2016.5.26
About me • Kazuhiro Serizawa • github: serihiro • work
at • serverside engineer • like %i(ruby erlang elixir)
ࠓ͞ͳ͍͜ͱ • ίʔυϨϏϡʔͷ۩ମతͳํ๏ • ޮՌతͳίʔυϨϏϡʔͷํ http://www.slideshare.net/rootmoon/7-37892729 ͓͢͢Ίʂ
ࠓ͢͜ͱ ίʔυϨϏϡʔ ΈΜͳͰΕ ͭΒ͘ͳ͍
ίʔυϨϏϡʔ͋Δ͋Δ • ϨϏϡʔ͓͡͞Μ͕͍Δ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ࠓϨϏϡʔͰ͕̍ऴΘ͓ͬͨʜ
ίʔυϨϏϡʔ͋Δ͋Δ • ༷ʹৄ͍͠ਓ͚͕ͩϨϏϡʔ͍ͯ͠Δ ϨϏϡʔ͓ئ͍͠·͢ʂ ͔͜͜Βͳ͍ΜͰ "͞ΜʹϨϏϡʔ͓ئ͍ͯ͠ ࠓϨϏϡʔָ͕͍͓͠ʜ ͡Ό͋"͞Μ͓ئ͍͠·͢ʂ
ίʔυϨϏϡʔ͋Δ͋Δ • ͰɺproductionͰόά͕ݟ͔ͭΔͱ "͞Μ͕ϨϏϡʔ ͯ͘͠Εͨͷʹʜ ͪΐ͏ͪΐʜͪΐ͏ͪΐʜ "͞Μʜ
ʮϨϏϡʔ͓͡͞Μʯ • ʢ΄΅ʣಛఆͷਓ͚͕ͩϨϏϡʔ͍ͯ͠Δ • ʢ΄΅ʣಛఆͷਓ͚͕ͩϨϏϡʔ͢Δͱ • ಛఆͷਓͷෛ୲͕େ͖ͯͭ͘Β͍ࢥ͍Λ͢Δ • νʔϜͰίʔυͷݟ͕ڞ༗͞Εͳ͍ •
νʔϜϝϯόʔͷϨϏϡʔྗ͕ҭͨͳ͍ • ͍ͭ·Ͱ͋ΒΏΔ͜ͱ͕ଐਓతͰεέʔϧ͠ͳ͍৫ʹ…
ͳͥʮϨϏϡʔ͓͡͞Μʯ͕ ੜ·Εͯ͠·͏ͷ͔ • ৭ʑཧ༝͋Δͱࢥ͍·͢ • ͘ӡ༻ͯ͠ΔͷͰ৽ࢀϝϯόʔ͕͠Βͳ͍͜ͱ͕ଟ͍ • ϝϯόʔͷ࣮ྗ͕ࠩେ͖͍ • ͳΜͱͳ͘
̋̋͞Μ͕Βͳ͍ͱμϝͳؾ͕͢Δ or ࠷ॳʹ࡞ͬͨਓ͕ϨϏϡʔ͠ͳ͍ͱμϝͳؾ͕͢Δ or ͓ͬ͞Μ͕ϨϏϡʔ͠ͳ͍ͱμϝͳؾ͕͢Δ
Ͱ͜Εͬͯ ͜͏͢Εղܾ͢ΔͷͰʁ • ͘ӡ༻ͯ͠ΔͷͰ৽ࢀϝϯόʔ͕͠Βͳ͍ ͜ͱ͕ଟ͍ • ϝϯόʔͷ࣮ྗ͕ࠩେ͖͍ • ͳΜͱͳ͘ →ֶʂ
→͑Ζʂ →ཧ༝͕ͳ͍ͳΒࢭΊΑ͏ʂ
͜ΕΛղܾ͢ΔͨΊͷఏҊ νʔϜશһͰ ϨϏϡʔ͠Α͏
͠νʔϜશһͰϨϏϡʔ͢Δ Α͏ʹͳΔͱ • ୭͕ޓ͍ͷίʔυΛϨϏϡʔ͢Δ • ϓϩμΫτͷ͕ڞ༗͞ΕΔ • ίʔυͷ༷Λ͘ڞ༗͢Δ • ݁Ռͱͯ͠ϨϏϡʔ͓͡͞Μ͕͍ͳ͘ͳΓɺ୭͔
͕ͭΒ͍ࢥ͍Λ͢Δ։ൃͳ͘ͳΔʂ …ͷ͔ʁ
Α͋͘Δݱ࣮ ࣗͷλεΫͰखҰഋͩ ͔ΒϨϏϡʔ͢Δͷେม ࣄͰͦΜͳʹ ษڧͨ͘͠ͳ͍ ͬͺΓԶ͕ϨϏϡʔ͠ͳ͍ͱෆ҆ ͪΌΜͱϨϏϡʔ Ͱ͖Δࣗ৴͕ͳ͍
ͰϨϏϡʔΒͳ͍ͱ Ͱ͖ΔΑ͏ʹͳΔͷ͍͠ʢܦݧ্ʣ • ͷͰͬͺΓνʔϜͰϨϏϡʔΛճͤΔΑ͏ ʹͳͬͯཉ͍͠ͱݸਓతʹࢥ͏ • ͳͷͰνʔϜͰϨϏϡʔΛճ͘͢͢͠Δͨ Ίʹ࣮ࡍʹࢲ͕͍ͬͯΔtipsΛ͍͔ͭ͘հ
ϨϏϡʔͯ͠΄͍͠༰ͷઆ໌Λ ৄࡉʹॻ͘Α͏ʹΈԽ͢Δ • PullRequestͷDescriptionΛςϯϓϨԽ
ϨϏϡΞʔhubotͰ ެฏʹׂΓৼΔ • hubot pluginʰhubot-reviewer-lottoʱΛ͏ https://github.com/sakatam/hubot-reviewer-lotto
ϨϏϡΞʔΛؾݣ͏ • ʮ͜Ε͔ͨ͠͠Β͍͔͠ͳʙʯ ͱࢥͬͨΒϨϏϡΞʔʹΛ͔͚ͯΈΔ • ͓ޓ͍ʹෆ໌ͳΛฉ͖͘͢͢Δ งғؾͮ͘Γ͕ॏཁ
ʮϨϏϡʔ=ษڧͷʯͱͯ͠ ೝࣝ͢Δ • ࢦఠ͢Δ͜ͱ͕ͳ༷ͯ͘ͰΘ͔Βͳ͍ॴ͕͋ͬͨ Βੵۃతʹ࣭͢Δ • ࢦఠ͢Δ͜ͱ͕ͳ࣭ͯ͘͢Δ͚ͩͰϨϏϡΞʔɾ ϨϏϡʔΠํͷؾ͖ͮʹͭͳ͕Δࣄଟ͍ • ʮԿ͔ࢦఠ͠ͳ͍ͱ͍͚ͳ͍ʯͱ͍͏ϓϨογϟʔ͕
͋ΔͱϨϏϡʔͨ͘͠ͳ͘ͳΔɻੵۃతʹΈΜͳͰ࣭ ͋ͬͯͦ͠͏͍͏ϓϨογϟʔΛͳ͘͢͜ͱ͕ॏཁ
ʮϨϏϡʔ=ษڧͷʯͱͯ͠ ೝࣝ͢Δ • ซͤͯಡΈ͍ͨ http://qiita.com/kkoide1332/items/c6ee6f007617114c8f0b
·ͱΊ • ίʔυϨϏϡʔ͓͡͞Μੜ·Ε͍͢ • ίʔυϨϏϡʔ͓͡͞Μ͕͍ΔνʔϜ͍Ζ ͍ΖͭΒ͍ • ΈΜͳͰίʔυϨϏϡʔΛճ͢͜ͱͰɺͭΒ ͍ίʔυϨϏϡʔ͔ΒϝϯόʔʹϝϦοτ͕ ͋ͬͯͭΒ͘ͳ͍ίʔυϨϏϡʔ