Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Getting Clean, Keeping Lean
Search
Joe Birch
March 17, 2017
Programming
10
630
Getting Clean, Keeping Lean
Joe Birch
March 17, 2017
Tweet
Share
More Decks by Joe Birch
See All by Joe Birch
Learning to play guitar with Actions on Google
hitherejoe
1
91
Making Change as an Ally
hitherejoe
1
420
Tensorflow for Android Developers
hitherejoe
3
250
Learning to play the guitar with Actions on Google
hitherejoe
0
120
For Optimists, our UI is pretty Pessimistic
hitherejoe
4
2.7k
Android Things: Building for the IoT
hitherejoe
2
150
Android TV: Building Apps with Google’s Leanback Library
hitherejoe
1
890
Building Beautiful Apps with the Design Support Library
hitherejoe
3
230
Other Decks in Programming
See All in Programming
受け取る人から提供する人になるということ
little_rubyist
0
250
Snowflake x dbtで作るセキュアでアジャイルなデータ基盤
tsoshiro
2
520
Quine, Polyglot, 良いコード
qnighy
4
650
ペアーズにおけるAmazon Bedrockを⽤いた障害対応⽀援 ⽣成AIツールの導⼊事例 @ 20241115配信AWSウェビナー登壇
fukubaka0825
6
2k
EMになってからチームの成果を最大化するために取り組んだこと/ Maximize team performance as EM
nashiusagi
0
100
macOS でできる リアルタイム動画像処理
biacco42
9
2.4k
Hotwire or React? ~アフタートーク・本編に含めなかった話~ / Hotwire or React? after talk
harunatsujita
1
120
Laravel や Symfony で手っ取り早く OpenAPI のドキュメントを作成する
azuki
2
120
A Journey of Contribution and Collaboration in Open Source
ivargrimstad
0
1k
イベント駆動で成長して委員会
happymana
1
340
.NET のための通信フレームワーク MagicOnion 入門 / Introduction to MagicOnion
mayuki
1
1.7k
Micro Frontends Unmasked Opportunities, Challenges, Alternatives
manfredsteyer
PRO
0
110
Featured
See All Featured
Dealing with People You Can't Stand - Big Design 2015
cassininazir
364
24k
The Cost Of JavaScript in 2023
addyosmani
45
6.8k
BBQ
matthewcrist
85
9.3k
Designing Experiences People Love
moore
138
23k
Measuring & Analyzing Core Web Vitals
bluesmoon
4
130
YesSQL, Process and Tooling at Scale
rocio
169
14k
Fireside Chat
paigeccino
34
3k
Practical Orchestrator
shlominoach
186
10k
Thoughts on Productivity
jonyablonski
67
4.3k
実際に使うSQLの書き方 徹底解説 / pgcon21j-tutorial
soudai
169
50k
Refactoring Trust on Your Teams (GOTO; Chicago 2020)
rmw
31
2.7k
What's new in Ruby 2.0
geeforr
343
31k
Transcript
Getting clean. Keeping lean.
@hitherejoe hitherejoe joebirch.co Joe Birch - Android Engineer @ Buffer
@buffer buffer.com
Greenfield projects
None
- High-level of technical debt - Extremely tightly coupled concepts
- No unit or UI tests - Difficult to know what is going on and where No longer lean
- YOU know what is what - YOU know where
class X is - YOU know where logic for Y is - But what about along the line… No longer lean (for now) (for now) (for now)
25 50 75 100 Output Debt
25 50 75 100 Output Debt
For the sake of yours and future developers sanity -
have empathy. Be mindful of the consequences and think before you craft.
Buffer for Android
None
None
None
- Lack of architecture - Bloated activities with multiple responsibilities
- Difficult to test - Difficult to extend and maintain - Duplication of concepts == no reuse
Moving to MVP - Fear of changing too much -
Helped separate presentation logic - DataManagers to house data operations - Increased test coverage
None
None
Not enough. - Bloated DataManager classes - Future changes, offline
- where? - Presentation linked to specific data source - No clear line between responsibilites - Buffer is a big app. Data types, features, sources
Architecture “The art of planning, designing and constructing buildings”
Architecture “The art of planning, designing and constructing buildings concepts”
None
None
None
None
None
Think outside of your team.
Clean Architecture
None
Separation of Concerns
- Layers are independent of frameworks - Code becomes more
testable - Inner layers independant of UI - Inner layers independant of external parties Separation of Concerns - Bugs more isolated
None
Layer Models - Each layer has own Model classes -
Removes dependancy on external models - Easily map with Mapper classes
ModelA Mapper Model Mapper Model
Enterprise Business Rules - Application Business Objects (Entities) - Unaffected
by operational change - Can create before touching any UI
public class TournamentModel { public String id; public String
name; @SerializedName("full_name") public String status; @SerializedName("date_start") public String dateStart; @SerializedName("date_end") public String dateEnd; public int size; }
Application Business Rules - Application specific business rules - Uses
Cases - Affected by operational change - Isolated from external concerns
public class GetSchedules extends UseCase<ProfileSchedules> { private final SchedulesRepository
schedulesRepository; @Inject public GetSchedules(SchedulesRepository schedulesRepository) { this.schedulesRepository = schedulesRepository; } @Override public Single<ProfileSchedules> buildUseCaseObservable() { return schedulesRepository.getSchedules(); } }
None
Use Case Interface Interface Impl Activity Application Business Rules Interface
Adapters
Interface Adapters - Contains MVP architecture of our app -
Presenters contain ‘callbacks’ - Views define contract for implementation - Mapper converts data from external form
public class UpdatesPresenter extends BasePresenter<UpdatesMvpView> implements SingleObserver<List<Update>> { @Override public
void onSubscribe(Disposable d) { … } @Override public void onSuccess(List<Match> matches) { … } @Override public void onError(Throwable e) { … } }
Presenter Interface Interface Impl Activity Interface Adapters Frameworks & Drivers
Frameworks & Drivers - UI components (Activities, Fragments) - Networking
actions (Retrofit) - Storage (Cache & DB) - Repository Pattern for interacting with these
Repository Interface Repository Impl DataStore Interface DataStore Impl DataStore Impl
DataStore Factory
None
Layer Boundaries - Communication via abstractions (interfaces) - No direct
name references in inner layers - Instead, inner layer provides this interface - aka, The Dependancy Inversion Principle
Not limited to these layers Layer 1 Layer 2 Layer
3 Layer 4
Not limited to these layers Layer 1 Layer 2 Layer
3
Not limited to these layers Layer 1 Layer 2 Layer
3 Layer 4 Layer 5 Layer 6
Test Coverage
None
Learnings
Advantages. - High percentage of code coverage - Incredibly easy
to navigate package structure - Easier to maintain - Allows us to move faster - Focused classes and test classes
- Seperation of concerns - Define, Test, Stabilise before UI
- Futureproof implementations - Clear discipline, good practice - and more…
Disadvantages - Adds initial overhead - Takes time to get
used to - Can feel overkill for some tasks - Difficult to make decisions - Conversion of models between layers
Winston Enterprise Business Rules Application Business Rules Interface Adapters Mobile
UI TV UI Wear UI Frameworks & Drivers
Winston Enterprise Business Rules Application Business Rules Interface Adapters Mobile
UI TV UI Wear UI Frameworks & Drivers @hitherejoe hitherejoe joebirch.co
Resources https://overflow.buffer.com/2016/12/22/rebuild- android-composer/ https://github.com/googlesamples/android- architecture Clean Architecture: A Craftsman's Guide
to Software Structure and Design (Robert C. Martin)