phpBB, Meet Symfony (php[world 16)

Transcript

1. PHPBB, MEET SYMFONY PHP[WORLD] 2016 @MICHAELCULLUMUK
2. ME?
3. MICHAEL CULLUM @MICHAELCULLUMUK
6. 25 MILLION
7. PHPBB FORUMS
8. USES COMPONENTS 3.1 3.2 3.3 3.4
13. NEW WAY OF THINKING
14. GETTING OFF THE ISLAND
15. ROMANCE
16. AWWW
17. PHPBB 3.1 RELEASE
18. COMPONENTS
20. EVENT DISPATCHER
21. EVENT DISPATCHER
22. COMPOSER
23. COMPOSER
24. EVENTS
25. EVENT DISPATCHER <?php class phpbb_event_dispatcher extends EventDispatcher { public function trigger_event($eventName, $data = array()) { $event = new phpbb_event_data($data); $this->dispatch($eventName, $event); return $event->get_data_filtered(array_keys($data)); } }
26. EVENT DISPATCHER <?php class dispatcher extends ContainerAwareEventDispatcher implements dispatcher_interface { public function trigger_event($eventName, $data = array()) { $event = new \phpbb\event\data($data); $this->dispatch($eventName, $event); return $event->get_data_filtered(array_keys($data)); } public function dispatch($eventName, Event $event = null) { if ($this->disabled) { return $event; } return parent::dispatch($eventName, $event); } }
27. EVENT DISPATCHER $vars = array('page_title', 'display_online_list', 'item_id', 'item', ‘page_header_override'); extract($phpbb_dispatcher->trigger_event('core.page_header', compact($vars)));
28. PHP VERSION
29. PHP VERSION
31. DEPENDENCY INJECTION CONTAINER
32. DEPENDENCY INJECTION $storage = new SessionStorage('SESSION_ID'); $user = new User($storage);
33. DEPENDENCY INJECTION function foo() { global $storage; } Warning: Ugly PHP 4 / phpBB 3.0 code!!!
34. DEPENDENCY INJECTION CONTAINER
35. DEPENDENCY INJECTION CONTAINER
36. DEPENDENCY INJECTION CONTAINER $phpbb_container_builder = new \phpbb\di\container_builder($phpbb_root_path, $phpEx); $phpbb_container = $phpbb_container_builder->with_config($phpbb_config_php_file)->get_container();
38. DEPENDENCY INJECTION CONTAINER protected function dump_container($container_filename) { $dumper = new PhpDumper($this->container); $cached_container_dump = $dumper->dump(array( 'class' => 'phpbb_cache_container', 'base_class' => 'Symfony\\Component\\DependencyInjection\\ContainerBuilder', )); file_put_contents($container_filename, $cached_container_dump); }
39. DEPENDENCY INJECTION CONTAINER $container_filename = $this->get_container_filename(); if (!defined('DEBUG_CONTAINER') && $this->dump_container && file_exists($container_filename)) { require($container_filename); $this->container = new \phpbb_cache_container(); } else { // ...
40. DEPENDENCY INJECTION CONTAINER protected function create_container(array $extensions) { $container = new ContainerBuilder(); foreach ($extensions as $extension) { $container->registerExtension($extension); $container->loadFromExtension($extension->getAlias()); } return $container; }
41. DEPENDENCY INJECTION CONTAINER /** * Loads a specific configuration. * * @param array $config An array of configuration values * @param ContainerBuilder $container A ContainerBuilder instance * * @throws \InvalidArgumentException When provided tag is not defined in this extension */ public function load(array $config, ContainerBuilder $container) { $loader = new YamlFileLoader($container, new FileLocator(phpbb_realpath($this->config_path))); $loader->load('services.yml'); }
42. COMPILER PASSES if ($this->use_custom_pass) { // Symfony Kernel Listeners $this->container->addCompilerPass(new \phpbb\di\pass\collection_pass()); $this->container->addCompilerPass( new RegisterListenersPass('dispatcher', 'event.listener_listener', ‘event.listener')); if ($this->use_kernel_pass) { $this->container->addCompilerPass(new RegisterListenersPass('dispatcher')); } }
43. COMPILER PASSES public function process(ContainerBuilder $container) { foreach ($container->findTaggedServiceIds('service_collection') as $id => $data) { $definition = $container->getDefinition($id); foreach ($container->findTaggedServiceIds($data[0]['tag']) as $service_id => $service_data) { $definition->addMethodCall('add', array($service_id)); } } }
45. HTTP *
46. FRONT CONTROLLER <?php define('IN_PHPBB', true); $phpbb_root_path = PHPBB_ROOT_PATH; $phpEx = substr(strrchr(__FILE__, '.'), 1); include($phpbb_root_path . 'common.' . $phpEx); // Start session management $user->session_begin(); $auth->acl($user->data); $user->setup('app');
47. FRONT CONTROLLER $http_kernel = $phpbb_container->get('http_kernel'); $symfony_request = $phpbb_container->get('symfony_request'); $response = $http_kernel->handle($symfony_request); $response->send(); $http_kernel->terminate($symfony_request, $response);
48. HTTP * <?php class symfony_request extends Request { public function __construct(\phpbb\request\request_interface $phpbb_request) { $get_parameters = $phpbb_request->get_super_global(\phpbb\request\request_interface::GET); $post_parameters = $phpbb_request->get_super_global(\phpbb\request\request_interface::POST); $server_parameters = $phpbb_request->get_super_global(\phpbb\request\request_interface::SERVER); $files_parameters = $phpbb_request->get_super_global(\phpbb\request\request_interface::FILES); $cookie_parameters = $phpbb_request->get_super_global(\phpbb\request\request_interface::COOKIE); parent::__construct($get_parameters, $post_parameters, array(), $cookie_parameters, $files_parameters, $server_parameters); } }
49. HTTP * <?php /** * Find a list of controllers * * @param string $base_path Base path to prepend to file paths * @return provider */ public function find($base_path = '') { $this->routes = new RouteCollection; foreach ($this->routing_files as $file_path) { $loader = new YamlFileLoader(new FileLocator(phpbb_realpath($base_path))); $this->routes->addCollection($loader->load($file_path)); } return $this; }
51. CONSOLE
52. CONSOLE <?php if (php_sapi_name() != 'cli') { echo 'This program must be run from the command line.' . PHP_EOL; exit(1); } define('IN_PHPBB', true); $phpbb_root_path = __DIR__ . '/../'; $phpEx = substr(strrchr(__FILE__, '.'), 1); require($phpbb_root_path . 'includes/startup.' . $phpEx); require($phpbb_root_path . 'config.' . $phpEx); require($phpbb_root_path . 'includes/constants.' . $phpEx); require($phpbb_root_path . 'includes/functions.' . $phpEx); require($phpbb_root_path . 'includes/functions_container.' . $phpEx); require($phpbb_root_path . 'phpbb/class_loader.' . $phpEx); $phpbb_class_loader = new \phpbb\class_loader('phpbb\\', "{$phpbb_root_path}phpbb/", $phpEx); $phpbb_class_loader->register(); $phpbb_class_loader_ext = new \phpbb\class_loader('\\', "{$phpbb_root_path}ext/", $phpEx); $phpbb_class_loader_ext->register(); $phpbb_container = phpbb_create_update_container($phpbb_root_path, $phpEx, "$phpbb_root_path/config"); $application = new \phpbb\console\application('phpBB Console', PHPBB_VERSION); $application->register_container_commands($phpbb_container); $application->run();
53. CONSOLE <?php if ($input->hasParameterOption(array('--safe-mode'))) { $phpbb_container_builder->set_use_extensions(false); $phpbb_container_builder->set_dump_container(false); } // ... $user = $phpbb_container->get('user'); $user->data['user_id'] = ANONYMOUS; $user->ip = '127.0.0.1'; $user->add_lang('acp/common'); $user->add_lang('cli');
55. TWIG
57. TWIG
58. TWIG
59. TWIG
60. FIXING TOKENS Strip Quotes: <!-- INCLUDE '{TEST}.html' to <!-- INCLUDE {TEST}.html Fix tokens: <!-- INCLUDE '{TEST}.html' to <!-- INCLUDE ' ~ {TEST} ~ '.html Add surrounding quotes: <!-- INCLUDE '{TEST}.html' to <!-- INCLUDE '' ~ {TEST} ~ '.html'
61. Replace ELSE IF with ELSEIF Replace our "div by" with Twig's divisibleby Replace $TEST with definition.TEST Replace .foo with loops.foo|length Replace .foo.bar with foo.bar|length
62. TWIG
63. TWIG public function getTag() { return 'EVENT'; }
64. PARSER <?php public function parse(\Twig_Token $token) { $expr = $this->parser->getExpressionParser()->parseExpression(); $stream = $this->parser->getStream(); $stream->expect(\Twig_Token::BLOCK_END_TYPE); return new \phpbb\template\twig\node\event( $expr, $this->parser->getEnvironment(), $token->getLine(), $this->getTag() ); }
65. COMPILER
67. BROWSER KIT
 CSS SELECTOR
 DOM CRAWLER
70. COMING SOON
72. TWIG
73. FORMS & VALIDATOR
74. STOPWATCH
75. SERIALISER
76. MONOLOG
77. DOCTRINE
79. EXTENDING
81. ON PREFORMED IDEAS
83. 12 YEARS AGO (IN A GALAXY FAR FAR AWAY?)
84. SQL INJECTION
85. UPDATE CONFLICTS
86. SPAM
88. “But it was my first experience with phpBB as a forum software, and so too easily I formed the opinion that phpBB was easy to inject exploits into. So then subsequently whenever I needed forum software, I shyed away from it. I didn't want my reputation and my clients' sites to be easily compromised.”
89. PHPBB 3.0 RELEASE
90. SECURITY
91. BUT STILL…
92. PHPBB 3.1 RELEASE
93. SYMFONY COMPONENTS
98. PHP
99. “Tonight's talk made me realise that having that preformed opinion and idea about how phpBB performed in the wild, from 12 years ago, was indicative of how closed my mind could be to certain topics. I'd liken it to the same way I felt about Ruby, based on “hipsters” and the plethora of “ninja rockstar guru” developer positions”
100. “Tonight I realised I still held the "insecure and outdated" opinion of phpBB, despite not having touched it since back then - and that saddened me, that I hadn't taken time to be more aware of where it was at.”
101. PREFORMED IDEAS
102. PREFORMED OPINIONS
103. PREFORMED CONCLUSIONS
104. DAMAGING
105. TOWARDS A: PROJECT
 LANGUAGE
 FRAMEWORK PERSON
106. “After my Ruby experience a couple of years ago, I resolved to be more open-minded about topics on which I had little experience. Michael's talk this evening made me resolve to do that more.”
107. THANKS @MICHAELCULLUMUK
108. QUESTIONS? @MICHAELCULLUMUK
109. phpbb/phpbb PHPBB.COM/GET-INVOLVED/
110. BIT.LY/WORLD16-PHPBB @MICHAELCULLUMUK
111. 2016 2016 @MICHAELCULLUMUK
112. PHPBB, MEET SYMFONY PHP[WORLD] 2016 @MICHAELCULLUMUK