Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code Review

Avatar for pluulove (노현석) pluulove (노현석)
May 03, 2019
Education
2
520

Code Review

회사 사내 팀에서 라이트닝토크로 발표한
Code Review에 대한 발표자료입니다.

Avatar for pluulove (노현석)

pluulove (노현석)

May 03, 2019
Tweet

More Decks by pluulove (노현석)

See All by pluulove (노현석)
Google I/O Extended Incheon 2025 ~ What's new in Android development tools
Avatar for pluulove (노현석) pluu
1
370
N.E.X.T LEVEL
Avatar for pluulove (노현석) pluu
3
540
안드로이드 기술 이력서의 최소 조건
Avatar for pluulove (노현석) pluu
1
3.1k
I/O Extended Android in Korea 2024 ~ Whats new in Android development tools
Avatar for pluulove (노현석) pluu
0
700
Android Studio와 좀 더 친해지기
Avatar for pluulove (노현석) pluu
0
200
우리모두 삽질한다
Avatar for pluulove (노현석) pluu
0
1.4k
Re:Android Studio 설정 살펴보기 및 생산성 올리기
Avatar for pluulove (노현석) pluu
0
1.7k
What's new in Android development tools
Avatar for pluulove (노현석) pluu
1
910
What's new in 
Android development tools
Avatar for pluulove (노현석) pluu
1
460

Other Decks in Education

See All in Education
DIP_2_Spatial
Avatar for Mohammed Hachama hachama
0
190
GOVERNOR ADDRESS：2025年9月29日合同公式訪問例会：2720 Japan O.K. ロータリーEクラブ、2025年10月6日卓話：藤田 千克由 氏（国際ロータリー第2720地区 2025－2026年度 ガバナー・大分中央ロータリークラブ・大分トキハタクシー（株）顧問）
Avatar for 2720 Japan O.K. ロータリーEクラブ 2720japanoke
0
670
吉岡研究室紹介(2025年度）
Avatar for Yoshioka Lab (Keio CSG) kentaroy47
0
510
理想の英語力に一直線！最高効率な英語学習のすゝめ
Avatar for Takuto Nagami logica0419
6
440
Презентация "Знаю Россию"
Avatar for Evgeniy Tyurikov spilsart
0
300
[FUN Open Campus 2025] 何でもセンシングしていいですか？
Avatar for Shigemi ISHIDA pman0214
0
260
SISTEMA DE MEMORIA Y SU IMPACTO EN LAS DECISIONES.
Avatar for José Vicente Pérez Cubias jvpcubias
0
180
Evaluation Methods - Lecture 6 - Human-Computer Interaction (1023841ANR)
Avatar for Beat Signer signer
PRO
0
1.1k
DIP_1_Introduction
Avatar for Mohammed Hachama hachama
0
280
仏教の源流からの奈良県中南和_奈良まほろば館‗飛鳥・藤原DAO/asuka-fujiwara_Saraswati
Avatar for Tomohiro Kimura tkimura12
0
150
Introduction - Lecture 1 - Web Technologies (1019888BNR)
Avatar for Beat Signer signer
PRO
0
5.7k
Alumnote inc. Company Deck
Avatar for Alumnote yukinumata
0
4.9k

Featured

See All Featured
Mobile First: as difficult as doing things right
Avatar for Swwweet swwweet
225
10k
No one is an island. Learnings from fostering a developers community.
Avatar for Antonio thoeni
21
3.5k
YesSQL, Process and Tooling at Scale
Avatar for Rocio Delgado rocio
174
15k
Building an army of robots
Avatar for Kyle Neath kneath
306
46k
Done Done
Avatar for chrislema chrislema
185
16k
Exploring the Power of Turbo Streams & Action Cable | RailsConf2023
Avatar for Kevin Liebholz kevinliebholz
36
6.1k
Docker and Python
Avatar for Tania Allard trallard
46
3.6k
Creating an realtime collaboration tool: Agile Flush - .NET Oxford
Avatar for Marc Duiker marcduiker
34
2.3k
Practical Tips for Bootstrapping Information Extraction Pipelines
Avatar for Matthew Honnibal honnibal
PRO
23
1.5k
実際に使うSQLの書き方 徹底解説 / pgcon21j-tutorial
Avatar for soudai sone soudai
PRO
190
55k
Testing 201, or: Great Expectations
Avatar for Joseph Mastey jmmastey
45
7.7k
Speed Design
Avatar for Sergey Chernyshev sergeychernyshev
32
1.2k

Transcript

  1. Code Review by Pluu

  2. None

  3. ৵ ܻ࠭о ઺ਃೠо? 1 2 ੌନ Ѿೣਸ ߊѼೞҊ Ҋ஖ӝ ਤ೧

    ௏٘ ߬੉झ੄ ੉೧ܳ ҕਬܳ ా೧ ࢲ۽ ߓ਎ ࣻ ੓׮ ٣੗ੋҗ ҳഅীࢲ ੌҙࢿਸ ਬ૑ೞӝ ਤ೧ 3

  4. ৵ ܻ࠭о ઺ਃೠо? 4 5 ౱ ੹୓ী ൔೠ (common) Ѿೣਸ

    ୓௼ 6 ׮ܲ ҙ੼ਸ ыח׮. زܐ੄ ܻ࠭ח ޙઁܳ ߊѼೞӝ ਤ೧ ೙ਃೠ Ѣܻܳ ઁҕ ੉೧੄ Ӑ١਷ ౱ ݯߡٜ੄ Ү؀ী ب਑ਸ ળ׮

  5. ৵ ܻ࠭о ઺ਃೠо? 7 8 ੗ࠗब/ࠁ࢚. ௏٬ ӝ۝੄ ੋ੿਷ ઺ਃೠ

    ࠁ࢚ ౱੄ ਽૘۱. ౱ ݯߡٜрী ؊ оөਕ૕ ࣻ ੓ѱ ب਑
  6. None

  7. Code Review Checklist General • ௏٘о ੘ز೤פө? ੄ب ೠ ӝמਸ

    ࣻ೯೤פө, ֤ܻо ৢ߄ܲ૑ ١. • ݽٚ ௏٘ܳ औѱ ੉೧ೡ ࣻ ੓णפө? • https://pl.kotl.in/MR0H0GQ_7 • ೤੄ೠ ௏٬ ӏ஗ਸ ળࣻ೤פө? ੉Ѫٜ਷ ؀ѐ ઺Қഐ, ߸ࣻ ߂ ೣ ࣻ ੉ܴ, ઴ ӡ੉, ٜৈ ॳӝ, ࢲध ߂ ઱ࢳ੄ ਤ஖ܳ ನೣ೤פ׮. • ઺ࠂغѢա ઺ࠂ ػ ௏٘о ੓णפө?

  8. Code Review Checklist General • оמೠ ௏٘ܳ ݽٕച ೠ Ѫੑפө?

    • https://pl.kotl.in/A9ZVqkTBC • ݽٚ ੹৉ ߸ࣻܳ ߄Ե ࣻ ੓णפө? • ઱ࢳ ୊ܻ ػ ௏٘о ੓णפө? • Do ܖ೐ח ࢸ੿ػ ӡ੉৬ ৢ߄ܲ ઙܐ ઑѤਸ о૑Ҋ ੓णפө? • ೐۽Ӓ۔ীࢲ ࢎਊ ػ ੉ܴ੉ ੄بܳ ੹׳೤פө?

  9. Code Review Checklist Performance • ࢿמਸ ೱ࢚दఆ ഛपೠ ୭੸ചо ੓णפө?

    • ௏٘ܳ ۄ੉࠳۞ܻ ա ղ੢ ೣࣻ۽ ؀୓ ೡ ࣻ ੓णפө? • https://pl.kotl.in/qLizl3RrH • ۽Ӧ ژח ٣ߡӦ ௏٘ܳ ઁѢ ೡ ࣻ ੓णפө?

  10. Code Review Checklist Security • ݽٚ ؘ੉ఠ ੑ۱ਸ ੼Ѩ (ৢ߄ܲ

    ਬഋ, ӡ੉, ഋध ߂ ߧਤ)ೞҊ ੋ ௏٬ ೮णפө? • ఋࢎ ਬ౰ܻ౭ܳ ࢎਊೞח ҃਋ ߈ജغח য়ܨо ߊѼؾפө? • ୹۱ чਸ ѨࢎೞҊ ੋ௏٬೤פө? • ੜޅػ ݒѐ ߸ࣻ ч੉ ୊ܻؾפө?

  11. Code Review Checklist Documentation • ઱ࢳ੉ ઓ੤ೞҊ ௏٘੄ ੄بܳ ࢸݺ೤פө?

    • ݽٚ ೣࣻо ઱ࢳ ୊ܻ غ঻णפө? • ࠺੿࢚੸ੋ ز੘੉ա о੢੗ܻ ா੉झ ୊ܻо ࢸݺغয ੓णפө? • ఋࢎ ۄ੉࠳۞ܻ੄ ࢎਊҗ ӝמ੉ ޙࢲചغয ੓णפө? • ؘ੉ఠ ҳઑ৬ ஏ੿ ױਤо ࢸݺ غ঻णפө? • ࠛ৮੹ೠ ௏٘о ੓णפө? Ӓۧ׮ݶ 'TODO'৬ э਷ ੸੺ೠ ݃ழ ܳ ࢎਊೞৈ ઁѢೞѢա ೒ېӒܳ ૑੿೧ঠ೤פө?

  12. Code Review Checklist Testing • ௏٘ܳ పझ౟ ೡ ࣻ ੓णפө?

    ௏٘о ցޖ ݆Ѣա ઙࣘޛਸ ऀӝ ૑ ঋҊ, ё୓ܳ ୡӝച ೡ ࣻ হਵݴ, పझ౟ ೐ۨ੐ ਕ௼о ݫࣗ٘ ١ਸ ࢎਊೡ ࣻ ੓ب۾ ҳઑചغযঠ೤פ׮. • పझ౟о ઓ੤ೞݴ ನҚ੸ੑפө? • पઁ۽ ௏٘о ਗೞח ӝמਸ ࣻ೯ೞח૑ పझ౟೤פө? • పझ౟ ௏٘ܳ ӝઓ APIܳ ࢎਊೞৈ ؀୓ ೡ ࣻ ੓णפө?

  13. ܻ࠭যܳ ਤೠ ౲ 1 2 ࢎۈ ؀नী ௏٘ܳ ࠺ಣೞۄ. ѐߊ੗ীѱ

    ஘੺, ௏٘ী ؀೧ࢶ ࠛ஘੺ೞۄ. 3 ૒ਤ۽ࠗఠо ইצ ૑धਵ۽ࠗఠ੄ ૓੿ೠ ӂਤ ׼नࠁ׮ ؊ ݽܰח ࢎۈਸ ઓ҃, ઓ઺, ੋղबਵ۽ ࢎۈਸ ؀ೞۄ

  14. ܻ࠭যܳ ਤೠ ౲ 4 5 ܻ࠭ ഥ੄ח ޙઁܳ ೧Ѿೞӝ ਤೠ

    ഥ੄о ইשਸ ઱੄ 6 “Why”ۄח ૕ޙਸ ೖೞۄ ޙ੢ࠁ׮ח ૕ޙਸ ೞۄ

  15. ܻ࠭যܳ ਤೠ ౲ 7 8 டଲೞח Ѫਸ ੕૑݃ۄ 9 ೧Ѿ଼ী

    ੽Ӕೞӝ ਤೠ ೠо૑ ੉࢚੄ ӡ੉ ੓׮ח Ѫਸ ӝরೞۄ. ׼न਷ ׼न੉ ଵઑೞח જ਷ ಴ળ ௏٬ਸ о૑Ҋ ੓׮ח Ѫਸ ݺबೞۄ

  16. ܻ࠭যܳ ਤೠ ౲ 10 11 ௏٘ ܻ࠭ܳ ࢲفܰ૑ ঋইب ػ׮.

    ೞ૑݅ ߄۽ ೧ঠೡ ೙ਃо ੓׮. ೠߣী 200~400 ۄੋࠁ׮ ੸਷ ௏٘ܳ ܻ࠭ೞۄ

  17. Reference • Effective Code Reviews ~ Code Review Checklist •

    Embedded System Code Review Checklist • Code review guidelines – Part 1 • https://flyburi.com/576