Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review
Search
pluulove (노현석)
May 03, 2019
Education
2
490
Code Review
회사 사내 팀에서 라이트닝토크로 발표한
Code Review에 대한 발표자료입니다.
pluulove (노현석)
May 03, 2019
Tweet
Share
More Decks by pluulove (노현석)
See All by pluulove (노현석)
I/O Extended Android in Korea 2024 ~ Whats new in Android development tools
pluu
0
420
Android Studio와 좀 더 친해지기
pluu
0
80
우리모두 삽질한다
pluu
0
1.2k
Re:Android Studio 설정 살펴보기 및 생산성 올리기
pluu
0
1.4k
What's new in Android development tools
pluu
1
790
What's new in Android development tools
pluu
1
390
개발자 Side Next Step ~ 커뮤니티 x Android
pluu
2
220
Modern Android Developer ~ 안내서
pluu
1
2.8k
I/O Extended 2022 in Android ~ Whats new in Android development tools
pluu
1
3.1k
Other Decks in Education
See All in Education
Qualtricsで相互作用実験する「SMARTRIQS」入門編
kscscr
0
250
week15@tcue2024
nonxxxizm
0
550
データハンドリング/data_handling
florets1
2
120
H5P-työkalut
matleenalaakso
4
35k
非techスキルどう伸ばす? / non_tech_skill_progress
shiina417
0
2.3k
week13@tcue2024
nonxxxizm
0
540
Flinga
matleenalaakso
2
13k
AGU情報社会論 2024 #07 "フェアユース"
fullfull
0
100
ブームだけで終わらせない、組織内でコーチングを活用する方法/How to Use Coaching in Your Organization Without It Being Just a Fad
yuko_yokouchi
1
250
Os pápeis do UX Design
wagnerbeethoven
0
150
不登校予防・再登校支援プログラムを提供するToCo (トーコ) の会社紹介資料 toco.mom
toco3week
0
210
電子計算機のイロハ
kosugitti
1
1.5k
Featured
See All Featured
Building an army of robots
kneath
302
42k
Faster Mobile Websites
deanohume
304
30k
CSS Pre-Processors: Stylus, Less & Sass
bermonpainter
354
29k
Easily Structure & Communicate Ideas using Wireframe
afnizarnur
190
16k
Navigating Team Friction
lara
183
13k
5 minutes of I Can Smell Your CMS
philhawksworth
202
19k
Six Lessons from altMBA
skipperchong
26
3.4k
Bootstrapping a Software Product
garrettdimon
PRO
304
110k
The Invisible Side of Design
smashingmag
296
50k
Typedesign – Prime Four
hannesfritz
39
2.3k
Making Projects Easy
brettharned
113
5.8k
The Straight Up "How To Draw Better" Workshop
denniskardys
230
130k
Transcript
Code Review by Pluu
None
৵ ܻ࠭о ਃೠо? 1 2 ੌନ Ѿೣਸ ߊѼೞҊ Ҋӝ ਤ೧
٘ ߬झ ೧ܳ ҕਬܳ ా೧ ࢲ۽ ߓ ࣻ ٣ੋҗ ҳഅীࢲ ੌҙࢿਸ ਬೞӝ ਤ೧ 3
৵ ܻ࠭о ਃೠо? 4 5 ী ൔೠ (common) Ѿೣਸ
6 ܲ ҙਸ ыח. زܐ ܻ࠭ח ޙઁܳ ߊѼೞӝ ਤ೧ ਃೠ Ѣܻܳ ઁҕ ೧ Ӑ١ ݯߡٜ Үী بਸ ળ
৵ ܻ࠭о ਃೠо? 7 8 ࠗब/ࠁ࢚. ٬ ӝ ੋ ਃೠ
ࠁ࢚ ۱. ݯߡٜрী ؊ оөਕ ࣻ ѱ ب
None
Code Review Checklist General • ٘о زפө? ب ೠ ӝמਸ
ࣻ೯פө, ֤ܻо ৢ߄ܲ ١. • ݽٚ ٘ܳ औѱ ೧ೡ ࣻ णפө? • https://pl.kotl.in/MR0H0GQ_7 • ೠ ٬ ӏਸ ળࣻפө? Ѫٜ ѐ Қഐ, ߸ࣻ ߂ ೣ ࣻ ܴ, ӡ, ٜৈ ॳӝ, ࢲध ߂ ࢳ ਤܳ ನೣפ. • ࠂغѢա ࠂ ػ ٘о णפө?
Code Review Checklist General • оמೠ ٘ܳ ݽٕച ೠ Ѫੑפө?
• https://pl.kotl.in/A9ZVqkTBC • ݽٚ ߸ࣻܳ ߄Ե ࣻ णפө? • ࢳ ܻ ػ ٘о णפө? • Do ܖח ࢸػ ӡ৬ ৢ߄ܲ ઙܐ ઑѤਸ оҊ णפө? • ۽Ӓ۔ীࢲ ࢎਊ ػ ܴ بܳ ׳פө?
Code Review Checklist Performance • ࢿמਸ ೱ࢚दఆ ഛपೠ ୭ചо णפө?
• ٘ܳ ۄ࠳۞ܻ ա ղ ೣࣻ۽ ೡ ࣻ णפө? • https://pl.kotl.in/qLizl3RrH • ۽Ӧ ژח ٣ߡӦ ٘ܳ ઁѢ ೡ ࣻ णפө?
Code Review Checklist Security • ݽٚ ؘఠ ੑ۱ਸ Ѩ (ৢ߄ܲ
ਬഋ, ӡ, ഋध ߂ ߧਤ)ೞҊ ੋ ٬ ೮णפө? • ఋࢎ ਬܻ౭ܳ ࢎਊೞח ҃ ߈ജغח য়ܨо ߊѼؾפө? • ۱ чਸ ѨࢎೞҊ ੋ٬פө? • ੜޅػ ݒѐ ߸ࣻ ч ܻؾפө?
Code Review Checklist Documentation • ࢳ ઓೞҊ ٘ بܳ ࢸݺפө?
• ݽٚ ೣࣻо ࢳ ܻ غणפө? • ࠺࢚ੋ زա оܻ ாझ ܻо ࢸݺغয णפө? • ఋࢎ ۄ࠳۞ܻ ࢎਊҗ ӝמ ޙࢲചغয णפө? • ؘఠ ҳઑ৬ ஏ ױਤо ࢸݺ غणפө? • ࠛ৮ೠ ٘о णפө? Ӓۧݶ 'TODO'৬ э ೠ ݃ழ ܳ ࢎਊೞৈ ઁѢೞѢա ېӒܳ ೧ঠפө?
Code Review Checklist Testing • ٘ܳ పझ ೡ ࣻ णפө?
٘о ցޖ ݆Ѣա ઙࣘޛਸ ऀӝ ঋҊ, ёܳ ୡӝച ೡ ࣻ হਵݴ, పझ ۨ ਕо ݫࣗ٘ ١ਸ ࢎਊೡ ࣻ ب۾ ҳઑചغযঠפ. • పझо ઓೞݴ ನҚੑפө? • पઁ۽ ٘о ਗೞח ӝמਸ ࣻ೯ೞח పझפө? • పझ ٘ܳ ӝઓ APIܳ ࢎਊೞৈ ೡ ࣻ णפө?
ܻ࠭যܳ ਤೠ 1 2 ࢎۈ नী ٘ܳ ࠺ಣೞۄ. ѐߊীѱ
, ٘ী ೧ࢶ ࠛೞۄ. 3 ਤ۽ࠗఠо ইצ धਵ۽ࠗఠ ೠ ӂਤ नࠁ ؊ ݽܰח ࢎۈਸ ઓ҃, ઓ, ੋղबਵ۽ ࢎۈਸ ೞۄ
ܻ࠭যܳ ਤೠ 4 5 ܻ࠭ ഥח ޙઁܳ ೧Ѿೞӝ ਤೠ
ഥо ইשਸ 6 “Why”ۄח ޙਸ ೖೞۄ ޙࠁח ޙਸ ೞۄ
ܻ࠭যܳ ਤೠ 7 8 டଲೞח Ѫਸ ݃ۄ 9 ೧Ѿ଼ী
Ӕೞӝ ਤೠ ೠо ࢚ ӡ ח Ѫਸ ӝরೞۄ. न न ଵઑೞח જ ળ ٬ਸ оҊ ח Ѫਸ ݺबೞۄ
ܻ࠭যܳ ਤೠ 10 11 ٘ ܻ࠭ܳ ࢲفܰ ঋইب ػ.
ೞ݅ ߄۽ ೧ঠೡ ਃо . ೠߣী 200~400 ۄੋࠁ ٘ܳ ܻ࠭ೞۄ
Reference • Effective Code Reviews ~ Code Review Checklist •
Embedded System Code Review Checklist • Code review guidelines – Part 1 • https://flyburi.com/576