Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code Review

Sponsored · Your Podcast. Everywhere. Effortlessly. Share. Educate. Inspire. Entertain. You do you. We'll handle the rest. →
Avatar for pluulove (노현석) pluulove (노현석)
May 03, 2019
Education
2
520

Code Review

회사 사내 팀에서 라이트닝토크로 발표한
Code Review에 대한 발표자료입니다.

Avatar for pluulove (노현석)

pluulove (노현석)

May 03, 2019
Tweet

More Decks by pluulove (노현석)

See All by pluulove (노현석)
Google I/O Extended Incheon 2025 ~ What's new in Android development tools
Avatar for pluulove (노현석) pluu
1
450
N.E.X.T LEVEL
Avatar for pluulove (노현석) pluu
3
580
안드로이드 기술 이력서의 최소 조건
Avatar for pluulove (노현석) pluu
1
3.6k
I/O Extended Android in Korea 2024 ~ Whats new in Android development tools
Avatar for pluulove (노현석) pluu
0
720
Android Studio와 좀 더 친해지기
Avatar for pluulove (노현석) pluu
0
220
우리모두 삽질한다
Avatar for pluulove (노현석) pluu
0
1.4k
Re:Android Studio 설정 살펴보기 및 생산성 올리기
Avatar for pluulove (노현석) pluu
0
1.7k
What's new in Android development tools
Avatar for pluulove (노현석) pluu
1
930
What's new in 
Android development tools
Avatar for pluulove (노현석) pluu
1
490

Other Decks in Education

See All in Education
20251119 如果是勇者欣美爾的話, 他會怎麼做? 東海資工
Avatar for Phil Huang pichuang
1
180
Generative AI Leader 認定試験範囲の解説
Avatar for Cloud Ace cloudace
0
130
XML and Related Technologies - Lecture 7 - Web Technologies (1019888BNR)
Avatar for Beat Signer signer
PRO
0
3.3k
滑空スポーツ講習会2025(実技講習）EMFT講習　実施要領/JSA EMFT 2025 procedure
Avatar for JSA seminar jsaseminar
0
130
コマンドラインを見直そう（1995年からタイムリープ）
Avatar for sapi_kawahara sapi_kawahara
0
680
Introduction - Lecture 1 - Information Visualisation (4019538FNR)
Avatar for Beat Signer signer
PRO
0
5.2k
Information Architectures - Lecture 2 - Next Generation User Interfaces (4018166FNR)
Avatar for Beat Signer signer
PRO
1
1.8k
NUTMEG紹介スライド
Avatar for Mugicha mugiiicha
0
1.1k
資格支援制度-株式会社HIT
Avatar for 株式会社HIT kabushikigaisya_hit
0
290
160人の中高生にAI・技術体験の講師をしてみた話
Avatar for ShuntaToda shuntatoda
1
330
Going over the Edge
Avatar for Jono Alderson jonoalderson
0
700
Cifrado asimétrico
Avatar for i-rochiño irocho
1
400

Featured

See All Featured
Game over? The fight for quality and originality in the time of robots
Avatar for Wayne Barker wayneb77
1
130
The #1 spot is gone: here's how to win anyway
Avatar for Tamara Novitovic tamaranovitovic
2
960
Understanding Cognitive Biases in Performance Measurement
Avatar for Philip Tellis bluesmoon
32
2.8k
Distributed Sagas: A Protocol for Coordinating Microservices
Avatar for Caitie McCaffrey caitiem20
333
22k
Leo the Paperboy
Avatar for Maya Tellez mayatellez
4
1.5k
Practical Orchestrator
Avatar for Shlomi Noach shlominoach
191
11k
The B2B funnel & how to create a winning content strategy
Avatar for Katarina Dahlin katarinadahlin
PRO
1
290
How Fast Is Fast Enough? [PerfNow 2025]
Avatar for Tammy Everts tammyeverts
3
460
What Being in a Rock Band Can Teach Us About Real World SEO
Avatar for Ade Holder 427marketing
0
180
Effective software design: The role of men in debugging patriarchy in IT @ Voxxed Days AMS
Avatar for Kenny Baas-Schwegler baasie
0
240
Exploring the relationship between traditional SERPs and Gen AI search
Avatar for Ray Grieselhuber raygrieselhuber
PRO
2
3.7k
Crafting Experiences
Avatar for Bethany Jepchumba bethany
1
65

Transcript

  1. Code Review by Pluu

  2. None

  3. ৵ ܻ࠭о ઺ਃೠо? 1 2 ੌନ Ѿೣਸ ߊѼೞҊ Ҋ஖ӝ ਤ೧

    ௏٘ ߬੉झ੄ ੉೧ܳ ҕਬܳ ా೧ ࢲ۽ ߓ਎ ࣻ ੓׮ ٣੗ੋҗ ҳഅীࢲ ੌҙࢿਸ ਬ૑ೞӝ ਤ೧ 3

  4. ৵ ܻ࠭о ઺ਃೠо? 4 5 ౱ ੹୓ী ൔೠ (common) Ѿೣਸ

    ୓௼ 6 ׮ܲ ҙ੼ਸ ыח׮. زܐ੄ ܻ࠭ח ޙઁܳ ߊѼೞӝ ਤ೧ ೙ਃೠ Ѣܻܳ ઁҕ ੉೧੄ Ӑ١਷ ౱ ݯߡٜ੄ Ү؀ী ب਑ਸ ળ׮

  5. ৵ ܻ࠭о ઺ਃೠо? 7 8 ੗ࠗब/ࠁ࢚. ௏٬ ӝ۝੄ ੋ੿਷ ઺ਃೠ

    ࠁ࢚ ౱੄ ਽૘۱. ౱ ݯߡٜрী ؊ оөਕ૕ ࣻ ੓ѱ ب਑
  6. None

  7. Code Review Checklist General • ௏٘о ੘ز೤פө? ੄ب ೠ ӝמਸ

    ࣻ೯೤פө, ֤ܻо ৢ߄ܲ૑ ١. • ݽٚ ௏٘ܳ औѱ ੉೧ೡ ࣻ ੓णפө? • https://pl.kotl.in/MR0H0GQ_7 • ೤੄ೠ ௏٬ ӏ஗ਸ ળࣻ೤פө? ੉Ѫٜ਷ ؀ѐ ઺Қഐ, ߸ࣻ ߂ ೣ ࣻ ੉ܴ, ઴ ӡ੉, ٜৈ ॳӝ, ࢲध ߂ ઱ࢳ੄ ਤ஖ܳ ನೣ೤פ׮. • ઺ࠂغѢա ઺ࠂ ػ ௏٘о ੓णפө?

  8. Code Review Checklist General • оמೠ ௏٘ܳ ݽٕച ೠ Ѫੑפө?

    • https://pl.kotl.in/A9ZVqkTBC • ݽٚ ੹৉ ߸ࣻܳ ߄Ե ࣻ ੓णפө? • ઱ࢳ ୊ܻ ػ ௏٘о ੓णפө? • Do ܖ೐ח ࢸ੿ػ ӡ੉৬ ৢ߄ܲ ઙܐ ઑѤਸ о૑Ҋ ੓णפө? • ೐۽Ӓ۔ীࢲ ࢎਊ ػ ੉ܴ੉ ੄بܳ ੹׳೤פө?

  9. Code Review Checklist Performance • ࢿמਸ ೱ࢚दఆ ഛपೠ ୭੸ചо ੓णפө?

    • ௏٘ܳ ۄ੉࠳۞ܻ ա ղ੢ ೣࣻ۽ ؀୓ ೡ ࣻ ੓णפө? • https://pl.kotl.in/qLizl3RrH • ۽Ӧ ژח ٣ߡӦ ௏٘ܳ ઁѢ ೡ ࣻ ੓णפө?

  10. Code Review Checklist Security • ݽٚ ؘ੉ఠ ੑ۱ਸ ੼Ѩ (ৢ߄ܲ

    ਬഋ, ӡ੉, ഋध ߂ ߧਤ)ೞҊ ੋ ௏٬ ೮णפө? • ఋࢎ ਬ౰ܻ౭ܳ ࢎਊೞח ҃਋ ߈ജغח য়ܨо ߊѼؾפө? • ୹۱ чਸ ѨࢎೞҊ ੋ௏٬೤פө? • ੜޅػ ݒѐ ߸ࣻ ч੉ ୊ܻؾפө?

  11. Code Review Checklist Documentation • ઱ࢳ੉ ઓ੤ೞҊ ௏٘੄ ੄بܳ ࢸݺ೤פө?

    • ݽٚ ೣࣻо ઱ࢳ ୊ܻ غ঻णפө? • ࠺੿࢚੸ੋ ز੘੉ա о੢੗ܻ ா੉झ ୊ܻо ࢸݺغয ੓णפө? • ఋࢎ ۄ੉࠳۞ܻ੄ ࢎਊҗ ӝמ੉ ޙࢲചغয ੓णפө? • ؘ੉ఠ ҳઑ৬ ஏ੿ ױਤо ࢸݺ غ঻णפө? • ࠛ৮੹ೠ ௏٘о ੓णפө? Ӓۧ׮ݶ 'TODO'৬ э਷ ੸੺ೠ ݃ழ ܳ ࢎਊೞৈ ઁѢೞѢա ೒ېӒܳ ૑੿೧ঠ೤פө?

  12. Code Review Checklist Testing • ௏٘ܳ పझ౟ ೡ ࣻ ੓णפө?

    ௏٘о ցޖ ݆Ѣա ઙࣘޛਸ ऀӝ ૑ ঋҊ, ё୓ܳ ୡӝച ೡ ࣻ হਵݴ, పझ౟ ೐ۨ੐ ਕ௼о ݫࣗ٘ ١ਸ ࢎਊೡ ࣻ ੓ب۾ ҳઑചغযঠ೤פ׮. • పझ౟о ઓ੤ೞݴ ನҚ੸ੑפө? • पઁ۽ ௏٘о ਗೞח ӝמਸ ࣻ೯ೞח૑ పझ౟೤פө? • పझ౟ ௏٘ܳ ӝઓ APIܳ ࢎਊೞৈ ؀୓ ೡ ࣻ ੓णפө?

  13. ܻ࠭যܳ ਤೠ ౲ 1 2 ࢎۈ ؀नী ௏٘ܳ ࠺ಣೞۄ. ѐߊ੗ীѱ

    ஘੺, ௏٘ী ؀೧ࢶ ࠛ஘੺ೞۄ. 3 ૒ਤ۽ࠗఠо ইצ ૑धਵ۽ࠗఠ੄ ૓੿ೠ ӂਤ ׼नࠁ׮ ؊ ݽܰח ࢎۈਸ ઓ҃, ઓ઺, ੋղबਵ۽ ࢎۈਸ ؀ೞۄ

  14. ܻ࠭যܳ ਤೠ ౲ 4 5 ܻ࠭ ഥ੄ח ޙઁܳ ೧Ѿೞӝ ਤೠ

    ഥ੄о ইשਸ ઱੄ 6 “Why”ۄח ૕ޙਸ ೖೞۄ ޙ੢ࠁ׮ח ૕ޙਸ ೞۄ

  15. ܻ࠭যܳ ਤೠ ౲ 7 8 டଲೞח Ѫਸ ੕૑݃ۄ 9 ೧Ѿ଼ী

    ੽Ӕೞӝ ਤೠ ೠо૑ ੉࢚੄ ӡ੉ ੓׮ח Ѫਸ ӝরೞۄ. ׼न਷ ׼न੉ ଵઑೞח જ਷ ಴ળ ௏٬ਸ о૑Ҋ ੓׮ח Ѫਸ ݺबೞۄ

  16. ܻ࠭যܳ ਤೠ ౲ 10 11 ௏٘ ܻ࠭ܳ ࢲفܰ૑ ঋইب ػ׮.

    ೞ૑݅ ߄۽ ೧ঠೡ ೙ਃо ੓׮. ೠߣী 200~400 ۄੋࠁ׮ ੸਷ ௏٘ܳ ܻ࠭ೞۄ

  17. Reference • Effective Code Reviews ~ Code Review Checklist •

    Embedded System Code Review Checklist • Code review guidelines – Part 1 • https://flyburi.com/576