Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code Review

Sponsored · Your Podcast. Everywhere. Effortlessly. Share. Educate. Inspire. Entertain. You do you. We'll handle the rest. →
Avatar for pluulove (노현석) pluulove (노현석)
May 03, 2019
Education
2
520

Code Review

회사 사내 팀에서 라이트닝토크로 발표한
Code Review에 대한 발표자료입니다.

Avatar for pluulove (노현석)

pluulove (노현석)

May 03, 2019
Tweet

More Decks by pluulove (노현석)

See All by pluulove (노현석)
Google I/O Extended Incheon 2025 ~ What's new in Android development tools
Avatar for pluulove (노현석) pluu
1
440
N.E.X.T LEVEL
Avatar for pluulove (노현석) pluu
3
570
안드로이드 기술 이력서의 최소 조건
Avatar for pluulove (노현석) pluu
1
3.5k
I/O Extended Android in Korea 2024 ~ Whats new in Android development tools
Avatar for pluulove (노현석) pluu
0
720
Android Studio와 좀 더 친해지기
Avatar for pluulove (노현석) pluu
0
210
우리모두 삽질한다
Avatar for pluulove (노현석) pluu
0
1.4k
Re:Android Studio 설정 살펴보기 및 생산성 올리기
Avatar for pluulove (노현석) pluu
0
1.7k
What's new in Android development tools
Avatar for pluulove (노현석) pluu
1
930
What's new in 
Android development tools
Avatar for pluulove (노현석) pluu
1
480

Other Decks in Education

See All in Education
学習指導要領と解説に基づく学習内容の構造化の試み / Course of study Commentary LOD JAET 2025
Avatar for Masao Takaku masao
0
120
LotusScript でエージェント情報を出力してみた
Avatar for Haruyuki Nakano harunakano
0
120
RGBでも蛍光を!? / RayTracingCamp11
Avatar for kugi kugimasa
2
370
悩める リーダー達に 届けたい書籍|レジリエントマネジメント 書籍イントロダクション-260126
Avatar for mimoza60 mimoza60
0
130
10分で学ぶ すてきなモナド
Avatar for soukouki soukouki
1
140
1202
Avatar for cbtlibrary cbtlibrary
0
200
渡辺研Slackの使い方 / Slack Local Rule
Avatar for kaityo256 kaityo256
PRO
10
11k
1021
Avatar for cbtlibrary cbtlibrary
0
400
外国籍エンジニアの挑戦・新卒半年後、気づきと成長の物語
Avatar for 蛋白（たんぱく・TANPACT） hypebeans
0
720
1008
Avatar for cbtlibrary cbtlibrary
0
130
Semantic Web and Web 3.0 - Lecture 9 - Web Technologies (1019888BNR)
Avatar for Beat Signer signer
PRO
2
3.2k
Node-REDで広がるプログラミング教育の可能性
Avatar for ueponx ueponx
1
260

Featured

See All Featured
Refactoring Trust on Your Teams (GOTO; Chicago 2020)
Avatar for Rebecca Miller-Webster rmw
35
3.3k
Raft: Consensus for Rubyists
Avatar for Patrick Van Stee vanstee
141
7.3k
Building Adaptive Systems
Avatar for Chris Keathley keathley
44
2.9k
A better future with KSS
Avatar for Kyle Neath kneath
240
18k
ピンチをチャンスに：未来をつくるプロダクトロードマップ #pmconf2020
Avatar for Aki / @LoveIdahoBurger aki_iinuma
128
55k
The Cult of Friendly URLs
Avatar for Andy Hume andyhume
79
6.8k
エンジニアに許された特別な時間の終わり
Avatar for watany watany
106
230k
Distributed Sagas: A Protocol for Coordinating Microservices
Avatar for Caitie McCaffrey caitiem20
333
22k
The Invisible Side of Design
Avatar for Vitaly Friedman smashingmag
302
51k
The Limits of Empathy - UXLibs8
Avatar for Cassini Nazir cassininazir
1
210
Designing for humans not robots
Avatar for Tammie Lister tammielis
254
26k
The Straight Up "How To Draw Better" Workshop
Avatar for Dennis Kardys denniskardys
239
140k

Transcript

  1. Code Review by Pluu

  2. None

  3. ৵ ܻ࠭о ઺ਃೠо? 1 2 ੌନ Ѿೣਸ ߊѼೞҊ Ҋ஖ӝ ਤ೧

    ௏٘ ߬੉झ੄ ੉೧ܳ ҕਬܳ ా೧ ࢲ۽ ߓ਎ ࣻ ੓׮ ٣੗ੋҗ ҳഅীࢲ ੌҙࢿਸ ਬ૑ೞӝ ਤ೧ 3

  4. ৵ ܻ࠭о ઺ਃೠо? 4 5 ౱ ੹୓ী ൔೠ (common) Ѿೣਸ

    ୓௼ 6 ׮ܲ ҙ੼ਸ ыח׮. زܐ੄ ܻ࠭ח ޙઁܳ ߊѼೞӝ ਤ೧ ೙ਃೠ Ѣܻܳ ઁҕ ੉೧੄ Ӑ١਷ ౱ ݯߡٜ੄ Ү؀ী ب਑ਸ ળ׮

  5. ৵ ܻ࠭о ઺ਃೠо? 7 8 ੗ࠗब/ࠁ࢚. ௏٬ ӝ۝੄ ੋ੿਷ ઺ਃೠ

    ࠁ࢚ ౱੄ ਽૘۱. ౱ ݯߡٜрী ؊ оөਕ૕ ࣻ ੓ѱ ب਑
  6. None

  7. Code Review Checklist General • ௏٘о ੘ز೤פө? ੄ب ೠ ӝמਸ

    ࣻ೯೤פө, ֤ܻо ৢ߄ܲ૑ ١. • ݽٚ ௏٘ܳ औѱ ੉೧ೡ ࣻ ੓णפө? • https://pl.kotl.in/MR0H0GQ_7 • ೤੄ೠ ௏٬ ӏ஗ਸ ળࣻ೤פө? ੉Ѫٜ਷ ؀ѐ ઺Қഐ, ߸ࣻ ߂ ೣ ࣻ ੉ܴ, ઴ ӡ੉, ٜৈ ॳӝ, ࢲध ߂ ઱ࢳ੄ ਤ஖ܳ ನೣ೤פ׮. • ઺ࠂغѢա ઺ࠂ ػ ௏٘о ੓णפө?

  8. Code Review Checklist General • оמೠ ௏٘ܳ ݽٕച ೠ Ѫੑפө?

    • https://pl.kotl.in/A9ZVqkTBC • ݽٚ ੹৉ ߸ࣻܳ ߄Ե ࣻ ੓णפө? • ઱ࢳ ୊ܻ ػ ௏٘о ੓णפө? • Do ܖ೐ח ࢸ੿ػ ӡ੉৬ ৢ߄ܲ ઙܐ ઑѤਸ о૑Ҋ ੓णפө? • ೐۽Ӓ۔ীࢲ ࢎਊ ػ ੉ܴ੉ ੄بܳ ੹׳೤פө?

  9. Code Review Checklist Performance • ࢿמਸ ೱ࢚दఆ ഛपೠ ୭੸ചо ੓णפө?

    • ௏٘ܳ ۄ੉࠳۞ܻ ա ղ੢ ೣࣻ۽ ؀୓ ೡ ࣻ ੓णפө? • https://pl.kotl.in/qLizl3RrH • ۽Ӧ ژח ٣ߡӦ ௏٘ܳ ઁѢ ೡ ࣻ ੓णפө?

  10. Code Review Checklist Security • ݽٚ ؘ੉ఠ ੑ۱ਸ ੼Ѩ (ৢ߄ܲ

    ਬഋ, ӡ੉, ഋध ߂ ߧਤ)ೞҊ ੋ ௏٬ ೮णפө? • ఋࢎ ਬ౰ܻ౭ܳ ࢎਊೞח ҃਋ ߈ജغח য়ܨо ߊѼؾפө? • ୹۱ чਸ ѨࢎೞҊ ੋ௏٬೤פө? • ੜޅػ ݒѐ ߸ࣻ ч੉ ୊ܻؾפө?

  11. Code Review Checklist Documentation • ઱ࢳ੉ ઓ੤ೞҊ ௏٘੄ ੄بܳ ࢸݺ೤פө?

    • ݽٚ ೣࣻо ઱ࢳ ୊ܻ غ঻णפө? • ࠺੿࢚੸ੋ ز੘੉ա о੢੗ܻ ா੉झ ୊ܻо ࢸݺغয ੓णפө? • ఋࢎ ۄ੉࠳۞ܻ੄ ࢎਊҗ ӝמ੉ ޙࢲചغয ੓णפө? • ؘ੉ఠ ҳઑ৬ ஏ੿ ױਤо ࢸݺ غ঻णפө? • ࠛ৮੹ೠ ௏٘о ੓णפө? Ӓۧ׮ݶ 'TODO'৬ э਷ ੸੺ೠ ݃ழ ܳ ࢎਊೞৈ ઁѢೞѢա ೒ېӒܳ ૑੿೧ঠ೤פө?

  12. Code Review Checklist Testing • ௏٘ܳ పझ౟ ೡ ࣻ ੓णפө?

    ௏٘о ցޖ ݆Ѣա ઙࣘޛਸ ऀӝ ૑ ঋҊ, ё୓ܳ ୡӝച ೡ ࣻ হਵݴ, పझ౟ ೐ۨ੐ ਕ௼о ݫࣗ٘ ١ਸ ࢎਊೡ ࣻ ੓ب۾ ҳઑചغযঠ೤פ׮. • పझ౟о ઓ੤ೞݴ ನҚ੸ੑפө? • पઁ۽ ௏٘о ਗೞח ӝמਸ ࣻ೯ೞח૑ పझ౟೤פө? • పझ౟ ௏٘ܳ ӝઓ APIܳ ࢎਊೞৈ ؀୓ ೡ ࣻ ੓णפө?

  13. ܻ࠭যܳ ਤೠ ౲ 1 2 ࢎۈ ؀नী ௏٘ܳ ࠺ಣೞۄ. ѐߊ੗ীѱ

    ஘੺, ௏٘ী ؀೧ࢶ ࠛ஘੺ೞۄ. 3 ૒ਤ۽ࠗఠо ইצ ૑धਵ۽ࠗఠ੄ ૓੿ೠ ӂਤ ׼नࠁ׮ ؊ ݽܰח ࢎۈਸ ઓ҃, ઓ઺, ੋղबਵ۽ ࢎۈਸ ؀ೞۄ

  14. ܻ࠭যܳ ਤೠ ౲ 4 5 ܻ࠭ ഥ੄ח ޙઁܳ ೧Ѿೞӝ ਤೠ

    ഥ੄о ইשਸ ઱੄ 6 “Why”ۄח ૕ޙਸ ೖೞۄ ޙ੢ࠁ׮ח ૕ޙਸ ೞۄ

  15. ܻ࠭যܳ ਤೠ ౲ 7 8 டଲೞח Ѫਸ ੕૑݃ۄ 9 ೧Ѿ଼ী

    ੽Ӕೞӝ ਤೠ ೠо૑ ੉࢚੄ ӡ੉ ੓׮ח Ѫਸ ӝরೞۄ. ׼न਷ ׼न੉ ଵઑೞח જ਷ ಴ળ ௏٬ਸ о૑Ҋ ੓׮ח Ѫਸ ݺबೞۄ

  16. ܻ࠭যܳ ਤೠ ౲ 10 11 ௏٘ ܻ࠭ܳ ࢲفܰ૑ ঋইب ػ׮.

    ೞ૑݅ ߄۽ ೧ঠೡ ೙ਃо ੓׮. ೠߣী 200~400 ۄੋࠁ׮ ੸਷ ௏٘ܳ ܻ࠭ೞۄ

  17. Reference • Effective Code Reviews ~ Code Review Checklist •

    Embedded System Code Review Checklist • Code review guidelines – Part 1 • https://flyburi.com/576