Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Decoding Code Review - Elixir Conf US
Search
Elaine Naomi
September 07, 2023
Programming
4
240
Decoding Code Review - Elixir Conf US
Lightning Talk
Elaine Naomi
September 07, 2023
Tweet
Share
More Decks by Elaine Naomi
See All by Elaine Naomi
Code Smells in Elixir - CODE BEAM EU 2023
elainenaomi
3
110
Exploring Code Smells - ElixirConf US 2023
elainenaomi
1
350
Getting Started With Phoenix - ElixirConf UY
elainenaomi
3
180
Decodificando o Code Review - Lovecoding 2022
elainenaomi
2
130
Mantendo sistemas Ruby e Elixir: lições aprendidas
elainenaomi
3
360
Decoding code review - Tech & Beers
elainenaomi
3
160
Elixir Conf EU - Lessons Learned from Elixir Learning Paths
elainenaomi
4
410
Elixir Brasil 2020 - Code Smells, Refactoring e Elixir
elainenaomi
5
220
Decodificando o Code Review - Webinar
elainenaomi
6
400
Other Decks in Programming
See All in Programming
JavaScript Closure
asoluka
0
1.9k
戦略的DDDは重いのか? / Is strategic DDD heavy?
pictiny
3
1.5k
WinActorの勉強を継続する方法
tamai_63
0
110
TypeScriptコードの漸進的改善 / Progressive Improvement of TypeScript Code
medley
1
360
TypeScriptでもLLMアプリケーション開発 / LLM Application In Typescript
rkaga
5
1.3k
禅の心を手に入れよ
eltociear
2
460
Amazon Aurora Serverless v2が意外と高かった話と、AWS Database Migration Serviceの話
satoshi256kbyte
1
100
PHPはいつから死んでいるかの調査
chiroruxx
2
440
Build Apps for iOS, Android & Desktop in 100% Kotlin With Compose Multiplatform (mDevCamp 2024)
zsmb
0
500
Jetpack Composeとデザインシステム
rmakiyama
0
190
SIMD Parallel Programming with the Vector API
josepaumard
0
250
“Seeing Like a Programmer”—Resiliency, Limits, and Moral Hazards in Software Engineering (LambdaConf 2024)
chriskrycho
0
400
Featured
See All Featured
jQuery: Nuts, Bolts and Bling
dougneiner
60
7.2k
Fantastic passwords and where to find them - at NoRuKo
philnash
39
2.5k
Code Review Best Practice
trishagee
56
15k
Building Flexible Design Systems
yeseniaperezcruz
320
37k
The Straight Up "How To Draw Better" Workshop
denniskardys
228
130k
The Cult of Friendly URLs
andyhume
74
5.7k
Faster Mobile Websites
deanohume
300
30k
Thoughts on Productivity
jonyablonski
60
3.9k
Templates, Plugins, & Blocks: Oh My! Creating the theme that thinks of everything
marktimemedia
20
1.8k
Code Reviewing Like a Champion
maltzj
515
39k
Why Our Code Smells
bkeepers
PRO
331
56k
Understanding Cognitive Biases in Performance Measurement
bluesmoon
12
1.1k
Transcript
DECODING CODE REVIEW ElixirConf US - 2023
ELAINE NAOMI WATANABE B.Sc. in Computer Engineering M.Sc. in Computer
Science Senior Software Engineer @ TheRealReal twitter.com/elaine_nw speakerdeck.com/elainenaomi linkedin.com/in/elainenaomi slides
None
CODE REVIEW
2001
60% of defects can be identified in code review process
Boehm, Barry, and Victor R. Basili. "Top 10 list [software development]." Computer 34.1 (2001): 135-137
2009
Code review is a valuable tool for identifying code evolvability-related
defects that are not detectable during the testing phase Mäntylä, Mika V., and Casper Lassenius. "What types of defects are really discovered in code reviews?." IEEE Transactions on Software Engineering 35.3 (2009): 430-448
http://agilemodeling.com/essays/modelReviews.htm Dev. Cost of Change Time Requirements Analysis and Design
Review Tests Production
http://agilemodeling.com/essays/modelReviews.htm Dev. Cost of Change Time Requirements Analysis and Design
Review Tests Production
As an Author
Self-descriptive title Motivation (Business Context) List previous questions and discussions
GIFs, screenshots from the changes
Coherent commit messages Complete, tested code Small changes Single responsibility
principle
Review your own PR Tag people as reviewers Apply necessary
changes Respond to all comments
RubyConf 2018 - A Branch in Time https://www.youtube.com/watch?v=8OOTVxKDwe0 capture the
why, not the what
As a Reviewer
Identify defects (bugs) Suggest alternatives, refactorings Reinforce patterns Validate functionality
(code + business)
Identify security issues Analyze performance impact Suggest documentation Validate the
code quality
Be introduced to new functionalities Learn new technologies Share knowledge
and questions
#
Feedback is about the source code, not about people
Promote the participation of everyone in your team
None
Toxic behaviors in code review may not be so obvious…
Toxic behaviors in code review may not be so obvious…
ask feedback
Toxic behaviors in code review may not be so obvious…
read about Non-Violent Communication
"This PR should not be merged" Opinion-based comment, lacking concrete
action, imperative
"Why haven't you created a new module?" A question with
a judgmental tone "Why didn't you think of that?"
Code reviews like a Human https://mtlynch.io/human-code-reviews-1/ https://mtlynch.io/human-code-reviews-2/
it's about adding comments in a more constructive manner
"Why haven't you created a new module?" A question with
a judgmental tone "Why didn't you think of that?"
constructive manner "What do you think about extracting this logic
into a module? I think it will improve readability and reduce complexity"
no assumptions, just a suggestion "I don't know if you've
already considered this, but wouldn't it be worth creating a new module for this case?"
Be mindful about unconscious bias
For example, about seniority bias
Don't assume that a junior engineer needs explanation for everything
And also, about gender bias
Please, don't try to explain what Elixir is to a
female Elixir engineer
Pay attention for not assuming a female Elixir engineer is
a junior engineer
#
None
None
https://sourcelevel.io/code-review-ebook
None
None
google.github.io/eng-practices/review/reviewer/standard.html
None
railsgirls.com.br
None
CARNIVAL EDITION
speakerdeck.com/elainenaomi elainenaomi.dev Muito obrigada illustrations from undraw.co translation: thank you
so much! slides