Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Decoding Code Review - Elixir Conf US
Search
Elaine Naomi
September 07, 2023
Programming
4
280
Decoding Code Review - Elixir Conf US
Lightning Talk
Elaine Naomi
September 07, 2023
Tweet
Share
More Decks by Elaine Naomi
See All by Elaine Naomi
Trem on Rails - Prompt Engineering com Ruby
elainenaomi
1
100
Rails Girls SP 2025 - Codando com IA
elainenaomi
0
22
Desenvolvimento Web com Elixir, Phoenix e Ecto - ELUG SP 2024
elainenaomi
1
71
Code Smells in Elixir - CODE BEAM EU 2023
elainenaomi
4
180
Exploring Code Smells - ElixirConf US 2023
elainenaomi
2
430
Getting Started With Phoenix - ElixirConf UY
elainenaomi
3
250
Decodificando o Code Review - Lovecoding 2022
elainenaomi
2
170
Mantendo sistemas Ruby e Elixir: lições aprendidas
elainenaomi
3
400
Decoding code review - Tech & Beers
elainenaomi
4
200
Other Decks in Programming
See All in Programming
『リコリス・リコイル』に学ぶ!! 〜キャリア戦略における計画的偶発性理論と変わる勇気の重要性〜
wanko_it
1
590
TDD 実践ミニトーク
contour_gara
0
140
物語を動かす行動"量" #エンジニアニメ
konifar
14
5.4k
Dart 参戦!!静的型付き言語界の隠れた実力者
kno3a87
0
200
CEDEC2025 長期運営ゲームをあと10年続けるための0から始める自動テスト ~4000項目を50%自動化し、月1→毎日実行にした3年間~
akatsukigames_tech
0
150
LLMOpsのパフォーマンスを支える技術と現場で実践した改善
po3rin
8
980
実践 Dev Containers × Claude Code
touyu
1
240
20250808_AIAgent勉強会_ClaudeCodeデータ分析の実運用〜競馬を題材に回収率100%の先を目指すメソッドとは〜
kkakeru
0
200
一人でAIプロダクトを作るための工夫 〜技術選定・開発プロセス編〜 / I want AI to work harder
rkaga
13
2.8k
Portapad紹介プレゼンテーション
gotoumakakeru
1
130
書き捨てではなく継続開発可能なコードをAIコーディングエージェントで書くために意識していること
shuyakinjo
1
300
【第4回】関東Kaggler会「Kaggleは執筆に役立つ」
mipypf
0
760
Featured
See All Featured
Writing Fast Ruby
sferik
628
62k
I Don’t Have Time: Getting Over the Fear to Launch Your Podcast
jcasabona
33
2.4k
Embracing the Ebb and Flow
colly
87
4.8k
Why Our Code Smells
bkeepers
PRO
338
57k
10 Git Anti Patterns You Should be Aware of
lemiorhan
PRO
656
61k
Making the Leap to Tech Lead
cromwellryan
134
9.5k
Being A Developer After 40
akosma
90
590k
Thoughts on Productivity
jonyablonski
69
4.8k
Why You Should Never Use an ORM
jnunemaker
PRO
59
9.5k
Side Projects
sachag
455
43k
CSS Pre-Processors: Stylus, Less & Sass
bermonpainter
358
30k
A Modern Web Designer's Workflow
chriscoyier
695
190k
Transcript
DECODING CODE REVIEW ElixirConf US - 2023
ELAINE NAOMI WATANABE B.Sc. in Computer Engineering M.Sc. in Computer
Science Senior Software Engineer @ TheRealReal twitter.com/elaine_nw speakerdeck.com/elainenaomi linkedin.com/in/elainenaomi slides
None
CODE REVIEW
2001
60% of defects can be identified in code review process
Boehm, Barry, and Victor R. Basili. "Top 10 list [software development]." Computer 34.1 (2001): 135-137
2009
Code review is a valuable tool for identifying code evolvability-related
defects that are not detectable during the testing phase Mäntylä, Mika V., and Casper Lassenius. "What types of defects are really discovered in code reviews?." IEEE Transactions on Software Engineering 35.3 (2009): 430-448
http://agilemodeling.com/essays/modelReviews.htm Dev. Cost of Change Time Requirements Analysis and Design
Review Tests Production
http://agilemodeling.com/essays/modelReviews.htm Dev. Cost of Change Time Requirements Analysis and Design
Review Tests Production
As an Author
Self-descriptive title Motivation (Business Context) List previous questions and discussions
GIFs, screenshots from the changes
Coherent commit messages Complete, tested code Small changes Single responsibility
principle
Review your own PR Tag people as reviewers Apply necessary
changes Respond to all comments
RubyConf 2018 - A Branch in Time https://www.youtube.com/watch?v=8OOTVxKDwe0 capture the
why, not the what
As a Reviewer
Identify defects (bugs) Suggest alternatives, refactorings Reinforce patterns Validate functionality
(code + business)
Identify security issues Analyze performance impact Suggest documentation Validate the
code quality
Be introduced to new functionalities Learn new technologies Share knowledge
and questions
#
Feedback is about the source code, not about people
Promote the participation of everyone in your team
None
Toxic behaviors in code review may not be so obvious…
Toxic behaviors in code review may not be so obvious…
ask feedback
Toxic behaviors in code review may not be so obvious…
read about Non-Violent Communication
"This PR should not be merged" Opinion-based comment, lacking concrete
action, imperative
"Why haven't you created a new module?" A question with
a judgmental tone "Why didn't you think of that?"
Code reviews like a Human https://mtlynch.io/human-code-reviews-1/ https://mtlynch.io/human-code-reviews-2/
it's about adding comments in a more constructive manner
"Why haven't you created a new module?" A question with
a judgmental tone "Why didn't you think of that?"
constructive manner "What do you think about extracting this logic
into a module? I think it will improve readability and reduce complexity"
no assumptions, just a suggestion "I don't know if you've
already considered this, but wouldn't it be worth creating a new module for this case?"
Be mindful about unconscious bias
For example, about seniority bias
Don't assume that a junior engineer needs explanation for everything
And also, about gender bias
Please, don't try to explain what Elixir is to a
female Elixir engineer
Pay attention for not assuming a female Elixir engineer is
a junior engineer
#
None
None
https://sourcelevel.io/code-review-ebook
None
None
google.github.io/eng-practices/review/reviewer/standard.html
None
railsgirls.com.br
None
CARNIVAL EDITION
speakerdeck.com/elainenaomi elainenaomi.dev Muito obrigada illustrations from undraw.co translation: thank you
so much! slides