Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Decoding Code Review - Elixir Conf US
Search
Elaine Naomi
September 07, 2023
Programming
4
280
Decoding Code Review - Elixir Conf US
Lightning Talk
Elaine Naomi
September 07, 2023
Tweet
Share
More Decks by Elaine Naomi
See All by Elaine Naomi
Rails Girls SP 2025 - Codando com IA
elainenaomi
0
20
Desenvolvimento Web com Elixir, Phoenix e Ecto - ELUG SP 2024
elainenaomi
1
63
Code Smells in Elixir - CODE BEAM EU 2023
elainenaomi
4
180
Exploring Code Smells - ElixirConf US 2023
elainenaomi
2
420
Getting Started With Phoenix - ElixirConf UY
elainenaomi
3
240
Decodificando o Code Review - Lovecoding 2022
elainenaomi
2
160
Mantendo sistemas Ruby e Elixir: lições aprendidas
elainenaomi
3
400
Decoding code review - Tech & Beers
elainenaomi
4
200
Elixir Conf EU - Lessons Learned from Elixir Learning Paths
elainenaomi
4
460
Other Decks in Programming
See All in Programming
「App Intent」よくわからんけどすごい!
rinngo0302
1
100
イベントストーミング図からコードへの変換手順 / Procedure for Converting Event Storming Diagrams to Code
nrslib
2
1.1k
チームのテスト力を総合的に鍛えて品質、スピード、レジリエンスを共立させる/Testing approach that improves quality, speed, and resilience
goyoki
5
1.1k
Quand Symfony, ApiPlatform, OpenAI et LangChain s'allient pour exploiter vos PDF : de la théorie à la production…
ahmedbhs123
0
220
ニーリーにおけるプロダクトエンジニア
nealle
0
950
NEWT Backend Evolution
xpromx
1
140
システム成長を止めない!本番無停止テーブル移行の全貌
sakawe_ee
1
350
Rails Frontend Evolution: It Was a Setup All Along
skryukov
0
280
High-Level Programming Languages in AI Era -Human Thought and Mind-
hayat01sh1da
PRO
0
880
マッチングアプリにおけるフリックUIで苦労したこと
yuheiito
0
190
Claude Code + Container Use と Cursor で作る ローカル並列開発環境のススメ / ccc local dev
kaelaela
12
7k
たった 1 枚の PHP ファイルで実装する MCP サーバ / MCP Server with Vanilla PHP
okashoi
1
300
Featured
See All Featured
Become a Pro
speakerdeck
PRO
29
5.4k
Building Flexible Design Systems
yeseniaperezcruz
328
39k
Agile that works and the tools we love
rasmusluckow
329
21k
Sharpening the Axe: The Primacy of Toolmaking
bcantrill
44
2.4k
Six Lessons from altMBA
skipperchong
28
3.9k
Docker and Python
trallard
45
3.5k
Java REST API Framework Comparison - PWX 2021
mraible
31
8.7k
A better future with KSS
kneath
238
17k
CoffeeScript is Beautiful & I Never Want to Write Plain JavaScript Again
sstephenson
161
15k
StorybookのUI Testing Handbookを読んだ
zakiyama
30
5.9k
"I'm Feeling Lucky" - Building Great Search Experiences for Today's Users (#IAC19)
danielanewman
229
22k
Put a Button on it: Removing Barriers to Going Fast.
kastner
60
3.9k
Transcript
DECODING CODE REVIEW ElixirConf US - 2023
ELAINE NAOMI WATANABE B.Sc. in Computer Engineering M.Sc. in Computer
Science Senior Software Engineer @ TheRealReal twitter.com/elaine_nw speakerdeck.com/elainenaomi linkedin.com/in/elainenaomi slides
None
CODE REVIEW
2001
60% of defects can be identified in code review process
Boehm, Barry, and Victor R. Basili. "Top 10 list [software development]." Computer 34.1 (2001): 135-137
2009
Code review is a valuable tool for identifying code evolvability-related
defects that are not detectable during the testing phase Mäntylä, Mika V., and Casper Lassenius. "What types of defects are really discovered in code reviews?." IEEE Transactions on Software Engineering 35.3 (2009): 430-448
http://agilemodeling.com/essays/modelReviews.htm Dev. Cost of Change Time Requirements Analysis and Design
Review Tests Production
http://agilemodeling.com/essays/modelReviews.htm Dev. Cost of Change Time Requirements Analysis and Design
Review Tests Production
As an Author
Self-descriptive title Motivation (Business Context) List previous questions and discussions
GIFs, screenshots from the changes
Coherent commit messages Complete, tested code Small changes Single responsibility
principle
Review your own PR Tag people as reviewers Apply necessary
changes Respond to all comments
RubyConf 2018 - A Branch in Time https://www.youtube.com/watch?v=8OOTVxKDwe0 capture the
why, not the what
As a Reviewer
Identify defects (bugs) Suggest alternatives, refactorings Reinforce patterns Validate functionality
(code + business)
Identify security issues Analyze performance impact Suggest documentation Validate the
code quality
Be introduced to new functionalities Learn new technologies Share knowledge
and questions
#
Feedback is about the source code, not about people
Promote the participation of everyone in your team
None
Toxic behaviors in code review may not be so obvious…
Toxic behaviors in code review may not be so obvious…
ask feedback
Toxic behaviors in code review may not be so obvious…
read about Non-Violent Communication
"This PR should not be merged" Opinion-based comment, lacking concrete
action, imperative
"Why haven't you created a new module?" A question with
a judgmental tone "Why didn't you think of that?"
Code reviews like a Human https://mtlynch.io/human-code-reviews-1/ https://mtlynch.io/human-code-reviews-2/
it's about adding comments in a more constructive manner
"Why haven't you created a new module?" A question with
a judgmental tone "Why didn't you think of that?"
constructive manner "What do you think about extracting this logic
into a module? I think it will improve readability and reduce complexity"
no assumptions, just a suggestion "I don't know if you've
already considered this, but wouldn't it be worth creating a new module for this case?"
Be mindful about unconscious bias
For example, about seniority bias
Don't assume that a junior engineer needs explanation for everything
And also, about gender bias
Please, don't try to explain what Elixir is to a
female Elixir engineer
Pay attention for not assuming a female Elixir engineer is
a junior engineer
#
None
None
https://sourcelevel.io/code-review-ebook
None
None
google.github.io/eng-practices/review/reviewer/standard.html
None
railsgirls.com.br
None
CARNIVAL EDITION
speakerdeck.com/elainenaomi elainenaomi.dev Muito obrigada illustrations from undraw.co translation: thank you
so much! slides