Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Decoding Code Review - Elixir Conf US
Search
Elaine Naomi
September 07, 2023
Programming
4
270
Decoding Code Review - Elixir Conf US
Lightning Talk
Elaine Naomi
September 07, 2023
Tweet
Share
More Decks by Elaine Naomi
See All by Elaine Naomi
Desenvolvimento Web com Elixir, Phoenix e Ecto - ELUG SP 2024
elainenaomi
1
42
Code Smells in Elixir - CODE BEAM EU 2023
elainenaomi
4
170
Exploring Code Smells - ElixirConf US 2023
elainenaomi
2
410
Getting Started With Phoenix - ElixirConf UY
elainenaomi
3
220
Decodificando o Code Review - Lovecoding 2022
elainenaomi
2
150
Mantendo sistemas Ruby e Elixir: lições aprendidas
elainenaomi
3
390
Decoding code review - Tech & Beers
elainenaomi
4
190
Elixir Conf EU - Lessons Learned from Elixir Learning Paths
elainenaomi
4
450
Elixir Brasil 2020 - Code Smells, Refactoring e Elixir
elainenaomi
5
240
Other Decks in Programming
See All in Programming
Bedrock×MCPで社内ブログ執筆文化を育てたい!
har1101
6
1k
Make Parsers Compatible Using Automata Learning
makenowjust
2
5.2k
KawaiiLT 登壇資料 キャリアとモチベーション
hiiragi
0
120
VitestのIn-Source Testingが便利
taro28
6
2.1k
個人開発の学生アプリが企業譲渡されるまで
akidon0000
0
490
Qiita Bash
mercury_dev0517
2
200
これだけは知っておきたいクラス設計の基礎知識 version 2
masuda220
PRO
24
6.5k
七輪ライブラリー: Claude AI で作る Next.js アプリ
suneo3476
1
110
Making TCPSocket.new "Happy"!
coe401_
1
1.6k
サービスクラスのありがたみを発見したときの思い出 #phpcon_odawara
77web
4
680
Compose Hot Reload is here, stop re-launching your apps! (Android Makers 2025)
zsmb
1
520
大LLM時代にこの先生きのこるには-ITエンジニア編
fumiyakume
7
3.1k
Featured
See All Featured
ReactJS: Keep Simple. Everything can be a component!
pedronauck
667
120k
Navigating Team Friction
lara
184
15k
A better future with KSS
kneath
239
17k
Faster Mobile Websites
deanohume
306
31k
Making the Leap to Tech Lead
cromwellryan
133
9.2k
Six Lessons from altMBA
skipperchong
27
3.7k
Fontdeck: Realign not Redesign
paulrobertlloyd
83
5.5k
[RailsConf 2023] Rails as a piece of cake
palkan
54
5.4k
Java REST API Framework Comparison - PWX 2021
mraible
30
8.5k
Responsive Adventures: Dirty Tricks From The Dark Corners of Front-End
smashingmag
251
21k
Fashionably flexible responsive web design (full day workshop)
malarkey
407
66k
Optimizing for Happiness
mojombo
377
70k
Transcript
DECODING CODE REVIEW ElixirConf US - 2023
ELAINE NAOMI WATANABE B.Sc. in Computer Engineering M.Sc. in Computer
Science Senior Software Engineer @ TheRealReal twitter.com/elaine_nw speakerdeck.com/elainenaomi linkedin.com/in/elainenaomi slides
None
CODE REVIEW
2001
60% of defects can be identified in code review process
Boehm, Barry, and Victor R. Basili. "Top 10 list [software development]." Computer 34.1 (2001): 135-137
2009
Code review is a valuable tool for identifying code evolvability-related
defects that are not detectable during the testing phase Mäntylä, Mika V., and Casper Lassenius. "What types of defects are really discovered in code reviews?." IEEE Transactions on Software Engineering 35.3 (2009): 430-448
http://agilemodeling.com/essays/modelReviews.htm Dev. Cost of Change Time Requirements Analysis and Design
Review Tests Production
http://agilemodeling.com/essays/modelReviews.htm Dev. Cost of Change Time Requirements Analysis and Design
Review Tests Production
As an Author
Self-descriptive title Motivation (Business Context) List previous questions and discussions
GIFs, screenshots from the changes
Coherent commit messages Complete, tested code Small changes Single responsibility
principle
Review your own PR Tag people as reviewers Apply necessary
changes Respond to all comments
RubyConf 2018 - A Branch in Time https://www.youtube.com/watch?v=8OOTVxKDwe0 capture the
why, not the what
As a Reviewer
Identify defects (bugs) Suggest alternatives, refactorings Reinforce patterns Validate functionality
(code + business)
Identify security issues Analyze performance impact Suggest documentation Validate the
code quality
Be introduced to new functionalities Learn new technologies Share knowledge
and questions
#
Feedback is about the source code, not about people
Promote the participation of everyone in your team
None
Toxic behaviors in code review may not be so obvious…
Toxic behaviors in code review may not be so obvious…
ask feedback
Toxic behaviors in code review may not be so obvious…
read about Non-Violent Communication
"This PR should not be merged" Opinion-based comment, lacking concrete
action, imperative
"Why haven't you created a new module?" A question with
a judgmental tone "Why didn't you think of that?"
Code reviews like a Human https://mtlynch.io/human-code-reviews-1/ https://mtlynch.io/human-code-reviews-2/
it's about adding comments in a more constructive manner
"Why haven't you created a new module?" A question with
a judgmental tone "Why didn't you think of that?"
constructive manner "What do you think about extracting this logic
into a module? I think it will improve readability and reduce complexity"
no assumptions, just a suggestion "I don't know if you've
already considered this, but wouldn't it be worth creating a new module for this case?"
Be mindful about unconscious bias
For example, about seniority bias
Don't assume that a junior engineer needs explanation for everything
And also, about gender bias
Please, don't try to explain what Elixir is to a
female Elixir engineer
Pay attention for not assuming a female Elixir engineer is
a junior engineer
#
None
None
https://sourcelevel.io/code-review-ebook
None
None
google.github.io/eng-practices/review/reviewer/standard.html
None
railsgirls.com.br
None
CARNIVAL EDITION
speakerdeck.com/elainenaomi elainenaomi.dev Muito obrigada illustrations from undraw.co translation: thank you
so much! slides