Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Decoding Code Review - Elixir Conf US
Search
Elaine Naomi
September 07, 2023
Programming
4
250
Decoding Code Review - Elixir Conf US
Lightning Talk
Elaine Naomi
September 07, 2023
Tweet
Share
More Decks by Elaine Naomi
See All by Elaine Naomi
Code Smells in Elixir - CODE BEAM EU 2023
elainenaomi
4
140
Exploring Code Smells - ElixirConf US 2023
elainenaomi
2
370
Getting Started With Phoenix - ElixirConf UY
elainenaomi
3
190
Decodificando o Code Review - Lovecoding 2022
elainenaomi
2
130
Mantendo sistemas Ruby e Elixir: lições aprendidas
elainenaomi
3
360
Decoding code review - Tech & Beers
elainenaomi
4
170
Elixir Conf EU - Lessons Learned from Elixir Learning Paths
elainenaomi
4
410
Elixir Brasil 2020 - Code Smells, Refactoring e Elixir
elainenaomi
5
230
Decodificando o Code Review - Webinar
elainenaomi
6
410
Other Decks in Programming
See All in Programming
OpenAI/Gemini APIを使って EPUBを翻訳するCLIツールをつくってみた
tomiyan
0
790
Architectures with Lightweight Stores: New Rules and Options
manfredsteyer
PRO
0
100
SDCon2024: Enabling DevOps and Team Topologies thru architecture: architecting for fast flow
cer
PRO
0
780
CSC307 Lecture 13
javiergs
PRO
0
150
はしめてのプログラミングとロボット制御
watawatavoltage
0
290
TiDB Serverless ~理想のServerless DBを考える~
soso_15315
1
160
わかりやすい正解を捨てて、コトに向き合う - スクラムフェス金沢2024 スポンサーセッション
yusukekokubo
0
170
実用的かつリーズナブルな 「Azure × Gemini × LINE」~キャラクターBot 実装ライブデモ~
tomodo_ysys
1
170
3 Effective Rules for Success with Signals in Angular
manfredsteyer
PRO
0
120
Jetpack for KMP
fornewid
1
290
Polarsの成長: v0.14からv1.0までの変遷と今後の展望
zerebom
1
350
最近追加した型の紹介とその振り返り
aki19035vc
0
170
Featured
See All Featured
[RailsConf 2023] Rails as a piece of cake
palkan
35
4.4k
Reflections from 52 weeks, 52 projects
jeffersonlam
346
19k
Teambox: Starting and Learning
jrom
130
8.6k
Infographics Made Easy
chrislema
238
18k
Art, The Web, and Tiny UX
lynnandtonic
291
20k
Save Time (by Creating Custom Rails Generators)
garrettdimon
PRO
13
430
Build your cross-platform service in a week with App Engine
jlugia
227
17k
KATA
mclloyd
20
13k
Learning to Love Humans: Emotional Interface Design
aarron
269
39k
Adopting Sorbet at Scale
ufuk
71
8.8k
Visualizing Your Data: Incorporating Mongo into Loggly Infrastructure
mongodb
36
9.1k
The Psychology of Web Performance [Beyond Tellerrand 2023]
tammyeverts
24
1.8k
Transcript
DECODING CODE REVIEW ElixirConf US - 2023
ELAINE NAOMI WATANABE B.Sc. in Computer Engineering M.Sc. in Computer
Science Senior Software Engineer @ TheRealReal twitter.com/elaine_nw speakerdeck.com/elainenaomi linkedin.com/in/elainenaomi slides
None
CODE REVIEW
2001
60% of defects can be identified in code review process
Boehm, Barry, and Victor R. Basili. "Top 10 list [software development]." Computer 34.1 (2001): 135-137
2009
Code review is a valuable tool for identifying code evolvability-related
defects that are not detectable during the testing phase Mäntylä, Mika V., and Casper Lassenius. "What types of defects are really discovered in code reviews?." IEEE Transactions on Software Engineering 35.3 (2009): 430-448
http://agilemodeling.com/essays/modelReviews.htm Dev. Cost of Change Time Requirements Analysis and Design
Review Tests Production
http://agilemodeling.com/essays/modelReviews.htm Dev. Cost of Change Time Requirements Analysis and Design
Review Tests Production
As an Author
Self-descriptive title Motivation (Business Context) List previous questions and discussions
GIFs, screenshots from the changes
Coherent commit messages Complete, tested code Small changes Single responsibility
principle
Review your own PR Tag people as reviewers Apply necessary
changes Respond to all comments
RubyConf 2018 - A Branch in Time https://www.youtube.com/watch?v=8OOTVxKDwe0 capture the
why, not the what
As a Reviewer
Identify defects (bugs) Suggest alternatives, refactorings Reinforce patterns Validate functionality
(code + business)
Identify security issues Analyze performance impact Suggest documentation Validate the
code quality
Be introduced to new functionalities Learn new technologies Share knowledge
and questions
#
Feedback is about the source code, not about people
Promote the participation of everyone in your team
None
Toxic behaviors in code review may not be so obvious…
Toxic behaviors in code review may not be so obvious…
ask feedback
Toxic behaviors in code review may not be so obvious…
read about Non-Violent Communication
"This PR should not be merged" Opinion-based comment, lacking concrete
action, imperative
"Why haven't you created a new module?" A question with
a judgmental tone "Why didn't you think of that?"
Code reviews like a Human https://mtlynch.io/human-code-reviews-1/ https://mtlynch.io/human-code-reviews-2/
it's about adding comments in a more constructive manner
"Why haven't you created a new module?" A question with
a judgmental tone "Why didn't you think of that?"
constructive manner "What do you think about extracting this logic
into a module? I think it will improve readability and reduce complexity"
no assumptions, just a suggestion "I don't know if you've
already considered this, but wouldn't it be worth creating a new module for this case?"
Be mindful about unconscious bias
For example, about seniority bias
Don't assume that a junior engineer needs explanation for everything
And also, about gender bias
Please, don't try to explain what Elixir is to a
female Elixir engineer
Pay attention for not assuming a female Elixir engineer is
a junior engineer
#
None
None
https://sourcelevel.io/code-review-ebook
None
None
google.github.io/eng-practices/review/reviewer/standard.html
None
railsgirls.com.br
None
CARNIVAL EDITION
speakerdeck.com/elainenaomi elainenaomi.dev Muito obrigada illustrations from undraw.co translation: thank you
so much! slides