Code review beyond code style - PHP Tour Nantes

Reviewing code can feel like a secondary task. Discussing code can be easy though,
if you leave out syntax details. Following a couple of guide lines for pull requests can make code reviewing much easier.

Some code style rules can drastically reduce the mental overhead needed to understand code changes. Furthermore this talk will give some general guidelines on how to give feedback on PRs as a peer developer or coworker. These rules are not to keep for yourself, share them with your peers and your life will get easier.

Transcript

1. Code reviews @hannesvdvreken @afup #phptour
2. Hi, my name is Hannes.
3. !
4. madewithlove.be
5. Code reviews
6. What’s a code review?
7. push commits review commits reply approve
8. push commits review commits reply approve
9. git add -p WHAT MAKES A CODE REVIEW?
11. Why spend time on that?
12. WHY SPEND TIME ON THAT? Why spend time on that? as a submitter:
13. WHY SPEND TIME ON THAT? Why spend time on that? as a reviewer:
14. WHY SPEND TIME ON THAT? Why spend time on that? Management:
15. What should a submitter do?
17. What should a reviewer do? or NOT do?
18. don’ts ❌ WHAT SHOULD A REVIEWER DO?
19. do ✓ WHAT SHOULD A REVIEWER DO?
21. Language
22. OMG I'M A BIG FAN OF UR CODES LANGUAGE
23. LANGUAGE
24. LANGUAGE
25. LANGUAGE
28. Wrapping up
29. Thank you! @hannesvdvreken @afup #phptour
30. Time for questions. @hannesvdvreken @afup #phptour