Share
Embed
テストが辛いを解決するテスト駆動開発のアプローチ at PHPカンファレンス仙台2019
"テストが辛いを解決するテスト駆動開発のアプローチ" at PHPカンファレンス仙台2019
Kazuki Higashiguchi
January 24, 2019
Transcript
105 slides
-
WBS@EVNQ NF w ౦ޱᏻ ,B[VLJ)JHBTIJHVDIJ w !IHTHUL (JU)VC
5XJUUFS w 4FSWFSTJEF&OHJOFFS (P 1)1 FUD w ॴଐɿ#"4&#"/,גࣜձࣾ w #"4&גࣜձࣾࢠձࣾ -
Ϣχοτςετ͕ ਏ͍༷ʑͳཁҼ w ςετͷॻ͖ํ͕Θ͔Βͳ͍ w ৗʹҰࠁҰඵΛ૪͍ͬͯΔ w طଘίʔυʹςετ͕ͳ͍ w ςετΛॻ͘ͷ͕ԯ߷
w ςετΛॻ͘ͷ͕͍͠ίʔ υʹͳΔ w طଘςετ͕։ൃΛ͍͛ͯ Δ -
w ςετͷॻ͖ํ͕Θ͔Βͳ͍ w ৗʹҰࠁҰඵΛ૪͍ͬͯΔ w طଘίʔυʹςετ͕ͳ͍ w ςετΛॻ͘ͷ͕ԯ߷ w ςετΛॻ͘ͷ͕͍͠ίʔ
υʹͳΔ w طଘςετ͕։ൃΛ͍͛ͯ Δ w ςετͷॻ͖ํͷशಘ d$BVTFd d1PTTJCMZ4PMVUJPOd w ϓϩδΣΫτཧ w ϨΨγʔίʔυվળ w ςετͷॻ͖͍͢ઃܭ w Մಡੑɾϝϯςφϯεੑ ͷߴ͍Ϣχοτςετ w ࣮தͷςετͷҐஔͮ ͚ͷݟ͠ -
w ςετͷॻ͖ํ͕Θ͔Βͳ͍ w ৗʹҰࠁҰඵΛ૪͍ͬͯΔ w طଘίʔυʹςετ͕ͳ͍ w ςετΛॻ͘ͷ͕ԯ߷ w ςετΛॻ͘ͷ͕͍͠ίʔ
υʹͳΔ w طଘςετ͕։ൃΛ͍͛ͯ Δ d$BVTFd d1PTTJCMZ4PMVUJPOd w ςετͷॻ͖ํͷशಘ w ϓϩδΣΫτཧ w ϨΨγʔίʔυվળ w ςετͷॻ͖͍͢ઃܭ w Մಡੑɾϝϯςφϯεੑ ͷߴ͍Ϣχοτςετ w ࣮தͷςετͷҐஔͮ ͚ͷݟ͠ Focus points -
ςετۦಈ։ൃͷαΠΫϧ w ·ͣςετΛҰͭॻ͘ w ͯ͢ͷςετΛΒͤɺ৽͍͠ςετͷࣦഊ Λ֬ೝ͢Δ 3FE w খ͞ͳมߋΛߦ͏
w ͯ͢ͷςετΛΒͤɺͯ͢ޭ͢Δ͜ͱ Λ֬ೝ͢Δ (SFFO w ϦϑΝΫλϦϯάΛߦͬͯॏෳΛআڈ͢Δ 3FGBDUPS -
ςετۦಈ։ൃͷਐΊํ w 50%0ϦετΛ࡞͢Δ w ඞཁʹͳΓͦ͏ͳςετΛॻ͖ग़͍ͯ͘͠ w ్தͰؾ͕͍ͭͨ՝Λه͍ͯ͘͠ w ςετۦಈ։ൃͷαΠΫϧʢ3FE(SFFO 3FGBDUPS
Λճ͍ͯ͘͠ w 3FE͔Β(SFFOʹ͢ΔͨΊͷzԾ࣮zΛ͠ɺ ૉૣ͘αΠΫϧΛճ͢ -
ςετΛॻ͘ /** * @test */ public function هࣄৄࡉऔಘʹͯޭϨεϙϯε͕ฦ٫͞ΕΔ() { $this->configRequest([
'headers' => [ 'Accept' => 'application/json', ], ]); $this->get('/api/articles/view/first'); $this->assertResponseSuccess(); } DEMO ʢࢿྉެ։༻ʣ -
খ͞ͳมߋΛߦ͏ class ArticlesController extends AppController { public function view($slug =
null) { } } DEMO ʢࢿྉެ։༻ʣ -
খ͞ͳมߋΛߦ͏ class ArticlesController extends AppController { public function initialize() {
parent::initialize(); $this->loadComponent('RequestHandler'); } public function view($slug = null) { $this->set([ '_serialize' => ['article'], 'article' => [], ]); } } DEMO ʢࢿྉެ։༻ʣ -
ςετΛॻ͘ /** * @test */ public function هࣄৄࡉऔಘʹͯଘࡏ͢ΔϨίʔυͷ߹ɺهࣄใ͕ฦ٫͞ΕΔ() { $this->configRequest([
'headers' => [ 'Accept' => 'application/json', ], ]); $this->get('/api/articles/view/first'); $expected = [ 'article' => [ 'id' => 1, 'user_id' => 1, 'title' => 'First Article', 'slug' => 'first', 'body' => 'First Article Body', 'published' => 1, 'created' => '2018-01-07T15:47:01+00:00', 'modified' => '2018-01-07T15:47:02+00:00', ], ]; $expected = json_encode($expected, JSON_PRETTY_PRINT); $this->assertSame($expected, (string)$this->_response->getBody()); } DEMO ʢࢿྉެ։༻ʣ -
Ծ࣮ public function view($slug = null) { // TODO temporary
implement $article = [ 'id' => 1, 'user_id' => 1, 'title' => 'First Article', 'slug' => 'first', 'body' => 'First Article Body', 'published' => 1, 'created' => '2018-01-07T15:47:01+00:00', 'modified' => '2018-01-07T15:47:02+00:00', ]; $this->set([ '_serialize' => ['article'], 'article' => $article, ]); } DEMO ʢࢿྉެ։༻ʣ -
ϦϑΝΫλϦϯά public function view($slug = null) { $article = $this->Articles->findBySlug($slug)-
>firstOrFail(); $this->set([ '_serialize' => ['article'], 'article' => $article, ]); } DEMO ʢࢿྉެ։༻ʣ -
w ςετͷॻ͖ํ͕Θ͔Βͳ͍ w ৗʹҰࠁҰඵΛ૪͍ͬͯΔ w طଘίʔυʹςετ͕ͳ͍ w ςετΛॻ͘ͷ͕ԯ߷ w ςετΛॻ͘ͷ͕͍͠ίʔ
υʹͳΔ w طଘςετ͕։ൃΛ͍͛ͯ Δ d$BVTFd d1PTTJCMZ4PMVUJPOd w ςετͷॻ͖ํͷशಘ w ϓϩδΣΫτཧ w ϨΨγʔίʔυվળ w ςετͷॻ͖͍͢ઃܭ w Մಡੑɾϝϯςφϯεੑ ͷߴ͍Ϣχοτςετ w ࣮தͷςετͷҐஔͮ ͚ͷݟ͠ Focus points ৼΓฦΓ -
ݱ࣌ͷςετ /** * @test */ public function ͍߹ΘͤϖʔδʹΞΫηεͰ͖Δ() { $this->get('/inquiries/add');
$this->assertResponseOk(); } /** * @test */ public function ͍߹Θͤอଘޭ࣌ҰཡϖʔδϦμΠϨΫτ͢Δ() { $this->enableCsrfToken(); $this->enableSecurityToken(); $data = [ 'title' => 'sample', 'body' => 'sample', 'email' => '[email protected]', ]; $this->post('/inquiries/add', $data); $this->assertResponseSuccess(); $this->assertRedirect('/inquiries'); } -
ݱ࣌ͷ࣮ public function add() { $inquiry = $this->Inquiries->newEntity(); if ($this->request->is('post'))
{ // TODO save inquiry data return $this->redirect(['action' => 'index']); } $this->set(compact('inquiry')); } -
·ͣςετΛॻ͘ /** * @test */ public function ͍߹Θͤͨ͠༰͕inquiriesςʔϒϧʹอଘ͞ΕΔ() { $this->enableCsrfToken();
$this->enableSecurityToken(); $this->configRequest([ 'environment' => ['REMOTE_ADDR' => '12.34.56.78'], ]); $data = [ 'title' => 'sample', 'body' => 'sample', 'email' => '[email protected]', ]; $this->post('/inquiries/add', $data); /** @var Inquiry $saved_inquiry */ $saved_inquiry = TableRegistry::getTableLocator() ->get('inquiries')->find() ->where(['title' => 'sample'])->first(); $this->assertInstanceOf('\App\Model\Entity\Inquiry', $saved_inquiry); } -
ςετΛ௨ͨ͢ΊͷԾ࣮ public function add() { $inquiry = $this->Inquiries->newEntity(); if ($this->request->is('post'))
{ // FIXME temporary $inquiry->title = 'sample'; $inquiry->body = 'sample'; $inquiry->email = '[email protected]'; $inquiry->client_ip = ’12.34.56.78'; $this->Inquiries->save($inquiry); return $this->redirect(['action' => 'index']); } $this->set(compact('inquiry')); } -
࣮ऀ͕಄ʹු͔Μ࣮ͩ public function saveWithIp(Inquiry $entity, \Cake\Http\ServerRequest $request) { $entity->client_ip =
$request->clientIp(); return $this->save($entity); } w .PEFMʹϝιουΛ࡞ w ϦΫΤετΦϒδΣΫτΛड͚औͬͯอଘ -
ςετΛॻ͘ /** * @test */ public function ͍߹Θͤͨ͠༰͕inquiriesςʔϒϧʹอଘ͞ΕΔ() { $inquiry
= $this->Inquiries->newEntity( [ 'title' => 'sample', 'body' => 'sample', 'email' => '[email protected]', ] ); $request = new \Cake\Http\ServerRequest('/inquiries/ add'); $actual = $this->Inquiries->saveWithIp($inquiry, $request); // Assert something } w ϝιου࡞Λఆ͍ͯ͠Δ.PEFMʹςετΛॻ͘ -
ςετ͔ΒҧײΛټΈऔΔ /** * @test */ public function ͍߹Θͤͨ͠༰͕inquiriesςʔϒϧʹอଘ͞ΕΔ() { $inquiry
= $this->Inquiries->newEntity( [ 'title' => 'sample', 'body' => 'sample', 'email' => '[email protected]', ] ); $request = new \Cake\Http\ServerRequest('/inquiries/ add'); $actual = $this->Inquiries->saveWithIp($inquiry, $request); // Assert something } ϢχοτςετΛॻͨ͘Ίʹɺ ςετ༻ͷϦΫΤετΛੜ͢Δख͕ؒൃੜ ͍ͯ͠Δ -
ҧײ͔Βઃܭஅ͢Δ /** * @test */ public function ͍߹Θͤͨ͠༰͕inquiriesςʔϒϧʹอଘ͞ΕΔ() { $inquiry
= $this->Inquiries->newEntity( [ 'title' => 'sample', 'body' => 'sample', 'email' => '[email protected]', ] ); $request = new \Cake\Http\ServerRequest('/inquiries/ add'); $actual = $this->Inquiries->saveWithIp($inquiry, $request); // Assert something } ϞσϧΫϥε͕ɺ ϦΫΤετΫϥεʹґଘ͍ͯ͠Δઃܭɺ Ίͨ΄͏͕ྑͦ͞͏ͩ -
ςετΛม͑ͯΈΔ /** * @test */ public function ͍߹Θͤͨ͠༰͕inquiriesςʔϒϧʹอଘ͞ΕΔ() { $inquiry
= $this->Inquiries->newEntity( [ 'title' => 'sample', 'body' => 'sample', 'email' => '[email protected]', ‘client_ip' => ‘171.0.0.1’, ] ); $actual = $this->Inquiries->saveWithIp($inquiry); // Assert something } ϦΫΤετΫϥεͷґଘΛɺ ςετίʔυͷஈ֊Ͱഉআͨ͠ɻ -
ςετΛม͑ͯΈΔ /** * @test */ public function ͍߹Θͤͨ͠༰͕inquiriesςʔϒϧʹอଘ͞ΕΔ() { $inquiry
= $this->Inquiries->newEntity( [ 'title' => 'sample', 'body' => 'sample', 'email' => '[email protected]', ‘client_ip' => ‘171.0.0.1’, ] ); $actual = $this->Inquiries->saveWithIp($inquiry); // Assert something } ݁ՌతʹɺΤϯςΟςΟΛอଘ͢Δ͚ͩʹ ͳͬͨɻ ϝιουΛ࡞͢Δ͜ͱ͕ͦͦෆཁ ͱஅɻ -
Ծ࣮Λॻ͖͑Δ public function add() { $inquiry = $this->Inquiries->newEntity(); if ($this->request->is('post'))
{ $inquiry = $this->Inquiries->patchEntity($inquiry, $this- >request->getData()); $inquiry->client_ip = $this->request->clientIp(); if (!$this->Inquiries->save($inquiry)) { // TODO error handling } return $this->redirect(['action' => 'index']); } $this->set(compact('inquiry')); } -
ࣦഊ͢ΔςετΛॻ͘ /** * @test */ public function ΞΧϯτใ͕σʔλϕʔεʹอଘ͞ΕΔ() { $result
= $this->AccountService->register(); // σʔλϕʔεʹอଘ͞ΕͨΛΞαʔτ͢Δ } -
͞ΒʹςετΛՃ͢Δ /** * @test */ public function ΞΧϯτใ͕σʔλϕʔεʹอଘ͞ΕΔ() { $result
= $this->AccountService->register(); // σʔλϕʔεʹอଘ͞ΕͨΛΞαʔτ͢Δ } /** * @test */ public function ొྃϝʔϧΛૹ৴͞ΕΔ() { $result = $this->AccountService->register(); // ొྃϝʔϧ͕ૹ৴͞Εͨ͜ͱΛΞαʔτ͢Δ } -
ςετΛ௨࣮͢Λ͢Δ class AccountService { public function register() { // ΞΧϯτใอଘॲཧ
ɹɹɹɹ // ϝʔϧૹ৴ॲཧ } } -
ࣦഊ͢ΔςετΛॻ͘ /** * @test */ public function ొྃϝʔϧΛૹ৴͞ΕΔ() { $result
= $this->AccountMailer->send(); // ొྃϝʔϧ͕ૹ৴͞Εͨ͜ͱΛΞαʔτ͢Δ } w ϝʔϧૹ৴Λߦ͏"DDPVOU.BJMFSΫϥεͷςε τΛ࡞ɺ"DDPVOU4FSWJDF5FTU͔Βςετϝιο υΛҠಈ͢Δ -
ςετ͕ͳ͍ίʔυ public function index() { $articles = $this->Articles->find('all'); $this->set([ '_serialize'
=> ['articles'], 'articles' => $articles, ]); } w هࣄҰཡΛKTPOͰฦ٫͢Δγϯϓϧͳ"1* w lެ։͍ͯ͠Δ QVCMJTIFE zهࣄͷΈฦ٫͢ΔมߋΛఆ w ͔͠͠ɺલऀʹΑΔςετίʔυॻ͔Ε͍ͯͳ͔ͬͨ -
ରίʔυΛݺͼग़͢ /** * @test */ public function هࣄҰཡऔಘʹͯهࣄҰཡ͕ฦ٫͞ΕΔ() { $this->configRequest([
'headers' => [ 'Accept' => 'application/json', ], ]); $this->get('/api/articles/index'); } -
ࣦഊ͢Δද໌Λߦ͏ /** * @test */ public function هࣄҰཡऔಘʹͯهࣄҰཡ͕ฦ٫͞ΕΔ() { $this->configRequest([
'headers' => [ 'Accept' => 'application/json', ], ]); $this->get('/api/articles/index'); $expected = json_encode([], JSON_PRETTY_PRINT); $this->assertSame($expected, (string)$this- >_response->getBody()); } -
ςετΛมߋ͢Δ $expected = [ 'articles' => [ [ 'id' =>
1, 'user_id' => 1, 'title' => 'First Published Article', 'slug' => 'first-published-article', 'body' => 'First Published Body', 'published' => 1, 'created' => '2018-01-07T15:47:01+00:00', 'modified' => '2018-01-07T15:47:02+00:00', ], [ 'id' => 2, 'user_id' => 1, 'title' => 'Unpublished Article', 'slug' => 'unpublished-article', 'body' => 'Unpublished Article Body', 'published' => 0, 'created' => '2018-01-07T15:47:01+00:00', 'modified' => '2018-01-07T15:47:02+00:00', ], ], ]; $expected = json_encode($expected, JSON_PRETTY_PRINT); $this->assertSame($expected, (string)$this->_response->getBody()); -
มߋ͍ͨ͠ৼΔ͍Λςετʹॻ͘ $expected = [ 'articles' => [ [ 'id' =>
1, 'user_id' => 1, 'title' => 'First Published Article', 'slug' => 'first-published-article', 'body' => 'First Published Body', 'published' => 1, 'created' => '2018-01-07T15:47:01+00:00', 'modified' => '2018-01-07T15:47:02+00:00', ], ], ]; $expected = json_encode($expected, JSON_PRETTY_PRINT); $this->assertSame($expected, (string)$this->_response->getBody()); w ެ։த QVCMJTIFE ͷΈฦ٫͞ΕΔৼΔ͍ Λظͱͯ͠ઃఆ͢Δ -
ςετΛ௨࣮͢Λߦ͏ public function index() { $articles = $this->Articles ->find() ->where(['published'
=> 1]) ->all(); $this->set([ '_serialize' => ['articles'], 'articles' => $articles, ]); } -
͝ਗ਼ௌ͋Γ͕ͱ͏͍͟͝·ͨ͠ɻ 5BML4VNNBSZ w ʮςετ͕ਏ͍ʯʹର͢Δ༷ʑͳཁҼ͔Βɺ ʮςετΛॻ͘ԯ߷͞ʯɾʮςετ͕ॻ͖ͮ Β͍ίʔυʹͳΔέʔεʯʹϑΥʔΧεͨ͠ w ςετۦಈ։ൃͷϦζϜʹΑͬͯɺςετͱಈ ࡞ίʔυΛҰͭͷϦζϜͰਐΊΔ w
ઃܭͷิॿಓ۩ͱͯ͠ϢχοτςετΛ׆༻ ͢Δ͜ͱͰɺςετ͕ॻ͖ͮΒ͍ίʔυΛճ ආ͢Δ