Code Smells: O que são e como eles afetam a saúde do seu código

Transcript

5. O QUE SÃO CODE SMELLS? 5
16. 16 abstract class AnimalLegs class Dog : AnimalLegs() class Chair : AnimalLegs() abstract class Legs class Dog : Legs() class Chair : Legs() refatorando...
17. 17 fun configureGame(players: Int, game: Game?) { when { players == 0 -> { setEmptyGame() } players in 1..3 -> { if (game != null) { this.gameSize = Game.SMALL game.players.forEach { configurePlayer(it, game, Game.SMALL) } } } players in 4..10 -> { if (game != null) { this.gameSize = Game.MEDIUM game.players.forEach { configurePlayer(it, game, Game.MEDIUM) } } } else -> { if (game != null) { this.gameSize = Game.BIG game.players.forEach { configurePlayer(it, game, Game.BIG) } } } } } fun configureGame(players: Int, game: Game?) { when { players == 0 -> setEmptyGame() players in 1..3 -> configureSmallGame(game) players in 4..10 -> configureMediumGame(game) else -> configureBigGame(game) } } refatorando...
18. 18 fun savePerson(firstName: String, lastName: String, age: Int, occupation: String, document: String, address: String){ ... } fun savePerson(person: Person) { ... } refatorando...
19. 19 class Customer(private val phone: Phone, ...) { fun getPhone(): String { return "("+ phone.areaCode + ")" + phone.prefix + "-" + phone.number } } class Customer(private val phone: Phone, ...) { fun getPhone(): String = phone.formattedPhone() } refatorando...
20. 20 class User { fun getConfiguration() = userConfig.getConfiguration() } class UserConfig { fun getConfiguration() = config.getConfiguration() } class Config { fun getConfiguration() = loadConfiguration() } class User { fun getConfiguration() = loadConfiguration() } refatorando...
21. 21 class Request(private val requestConfig: RequestConfig) { fun getHeaders() = requestConfig.getHeaders() fun getTimeoutLimit() = requestConfig.getTimeoutLimit() fun getBody() = requestConfig.getBody() } class Request { fun getHeaders() = {...} fun getTimeoutLimit() = {...} fun getBody() = {...} } refatorando...
22. 22 class Message { fun notifyUser( userName: String, userDetail: UserDetail, message: String ) { val messageBody = "Hi, " + userName + "\n" + message + "("userDetail.streetName + "," + userDetail.streetNumber this.notificationService.sendSMS(userDetail.number, messageBody) } } class Message { fun notifyUser( userName: String, number: String, address: String, message: String ) { val messageBody = "Hi, " + userName + "\n" + message + address this.notificationService.sendSMS(number, messageBody) } refatorando...
24. detekt 24 https://github.com/arturbosch/detekt
25. Dica 25
28. 28 #sejaumzupper
29. 29 https://www.industriallogic.com/wp-content/uploads/2005/09/smellstorefactorings.pdf https://refactoring.guru/smells/ https://codeburst.io/write-clean-code-and-get-rid-of-code-smells-aea271f30318 https://github.com/arturbosch/detekt