みんなで育てるprecheck

Transcript

1. ΈΜͳͰҭͯΔ precheck 2017/08/22 fastlaneษڧձ@Origami
2. ࣗݾ঺հ ɾKohei Tabata(@nerd0geek1) ɾSaib Studio LLC ɾiOS/macOS app Developer ɾfastlane contributor Said Studio LLC Kohei Tabata Next! Remote quick-zip plus
3. Agenda ɾprecheckͱ͸ ɾprecheckͷ࢖͍ํ ɾprecheckͱRule ɾprecheckͷΧελϚΠζ ɾContributionνϟϯε ɾ·ͱΊ
4. precheckͱ͸ʁ ɾfastlane v2.40.0Ͱ৽͘͠fastlaneʹ௥Ճ͞Εͨrubygems ɾcommunity driven metadata checker ɾiTunes Connect্ͷmetadataʹmetadata rejectΛҾ͖ى͜͢Α͏ͳҎԼͷจݴ͕ ɹؚ·Ε͍ͯͳ͍͔֬ೝ͠ɺඞཁʹԠͯ͡ܯࠂͯ͘͠ΕΔɻ ɹɾଞࣾͷ঎ඪ ɹɾiOSͷόά΁ͷݴٴ ɹɾଞͷplatform΁ͷݴٴ(Android) ɹɾetc…
5. ࢖͍ํ ɾfastlane precheck ɾfastlane deliver run(→defaultͰprecheckΛݺͿ)
6. precheckͱRule ɾprecheckͰ͸ɺRuleͱ͍͏ΫϥεΛجఈΫϥεͱ͢Δ༷ʑͳ۩৅ΫϥεΛ࡞Γɺ ɹͦͷ۩৅ΫϥεΛmetadataʹద༻͢Δ͜ͱͰνΣοΫΛߦ͍ͬͯΔɻ ɾҎԼͷΑ͏ͳ۩৅Ϋϥε͕ར༻͞Ε͍ͯΔɻ ɹɾNegativeAppleSentimentRule ɹɾPlaceholderWordsRule ɹɾOtherPlatformsRule(ଞplatform΁ͷݴٴ) ɹɾFutureFunctionalityRule(ʮcoming soonʯͳͲͷະ࣮૷Λࣔ͢දݱؚ͕·Ε͍ͯΔ͔) ɹɾTestWordsRule(testingͳͲɺςετΞϓϦͬΆ͍จݴؚ͕·Ε͍ͯΔ͔) ɹɾCurseWordsRule ɹɾCustomTextRule ɹɾCopyrightDateRule ɹɾUnreachableURLRule
7. precheckͷΧελϚΠζ ɾଞͷfastlaneͷgemಉ༷ʹઃఆϑΝΠϧͱͯ͠PrecheckFileΛ࡞੒͢Δ͜ͱ͕Ͱ͖Δ ɾPrecheckFile಺Ͱɺ֤ϧʔϧΛͲͷఔ౓ݫ͘͠νΣοΫ͢Δ͔ΛઃఆՄೳ ɹɾskip(νΣοΫ͠ͳ͍) ɹɾwarn(νΣοΫ͠ɺϧʔϧʹҾ͔͔ͬΕ͹දࣔ͢Δ) ɹɾerror(νΣοΫ͠ɺϧʔϧʹҾ͔͔ͬΕ͹ͦ͜ͰॲཧΛऴྃͤ͞Δ)
8. Contributionνϟϯε ɾprecheck͸ɺ֤Rule͝ͱʹStringͷArrayΛ࡞੒͠ɺͦͷArrayʹؚ·Ε͍ͯΔจݴ͕ ɹmetadataʹؚ·Ε͍ͯΔ͔ɺͱ͍͏νΣοΫΛ͍ͯ͠Δ͚ͩɻ ɾͳͷͰɺmetadata reject͞ΕͨࡍʹɺRuleͷlowercased_words_to_look_forʹ ɹϦδΣΫτ࣌ʹࢦఠ͞ΕͨจݴΛ௥Ճ͠ɺPRΛૹΔ͚ͩͰ؆୯ʹfastlaneͷ ɹContributorʹͳΕΔ͔΋ʁ
9. ·ͱΊ ɾprecheck͸ίϛϡχςΟͷ஌ݟΛ׆͔ͯ͠metadata rejectΛආ͚ΔͨΊͷgem ɾΈΜͳ͕metadata reject࣌ʹprecheckʹPRૹΕ͹ू߹஌Λ׆͔ͤΔΑ͏ʹ ɾreject͞ΕͨจݴΛ֤Ruleͷlowercased_words_to_look_forʹ௥Ճ͢Δ͚ͩͳͷͰɺ ɹ؆୯ʹContributeͰ͖Δ͔΋⭐⭐⭐
10. ࢀߟ * fastlane release 2.40.0 Introducing fastlane precheck (https://github.com/fastlane/fastlane/releases/tag/2.40.0) * precheck (https://github.com/fastlane/fastlane/tree/master/precheck)