Is all new code tested? Altered code tests up to date? ▸ Is the code readable? ▸ Do you understand the code you are reviewing? ▸ Has the developer tested the code? ▸ Coding conventions? ▸ Are all functions, methods and classes documented? ▸ Are complex algorithms and code optimizations adequately commented? ▸ Error Handling ▸ Resource Leaks ▸ Thread Safeness ▸ Is the code free of unintended infinite loops? ▸ Are function parameters explicitly verified in the code? ▸ Pending/TODO ▸ assertions ▸ abnormal terminations ▸ Database Transactions ▸ Correct synchronization ▸ no deadlocks/livelocks ▸ Bug Fix Side Effects ▸ All the occurrences of the bug are fixed
be read by at least two ppl ▸ Every component should have: ▸ Owner ▸ Secondary maintainer ▸ Short and atomic PRs ▸ Know the coding conventions / styleguides ▸ Read related code (classes/method being used) ▸ Read Slow ▸ Short reviews (at most 60 minutes/200 LOC)