from checklists… But… • What I usually look for: ◦ I understand ◦ It makes sense ◦ Aesthetics (naming, style etc) ◦ SW Engineering (modularity, coherence, DRY etc) ◦ Docs ◦ Tests
• Be professional. It isn’t personal ◦ Concentrate on the code, not the personality • Understand, not criticize • Get prepared ◦ Technology ◦ Product ◦ Coding conventions ◦ Related code • Read slow • Short code reviews