Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Story of PR #4657

Story of PR #4657

Story of one pull request, dramatized as a battle between a robot dog and a six eyed daikaiju.

Leszek Rybicki

March 15, 2017
Tweet

More Decks by Leszek Rybicki

Other Decks in Programming

Transcript

  1. 14

  2. 15

  3. 17

  4. 18

  5. 22

  6. 23

  7. 24

  8. 26

  9. 27

  10. 28

  11. 29

  12. 30

  13. 31

  14. 36

  15. 40

  16. 42

  17. 45

  18. 46

  19. 47

  20. 50 Lessons Learned 1. Contributing to Open Source is a

    fun and valuable experience 2. If you see something you can fix - go for it! 3. Yes, everybody will see your ugly code 4. ...and you may even end up showing it on a meetup. 5. Don’t rush it! 6. Read before you write 7. Explain your changes and reasons as well as you can 8. Follow the rules 9. Update the documentation 10. Lint your code before pushing 11. Write tests 12. Write tests! 13. Actually run those tests locally before pushing
  21. 51 Thanks to Francois Chollet for making Keras and being

    really supportive when reviewing my messy pull requests. ...and to Isaac Greg for asking me the right question at the right time. Keep on testing, Travis, good job! 6th eye is in the back
  22. 52 Thanks to BBC for making Doctor Who. Hoping to

    see K9 again. Please don’t be too cross at me for using these images.