Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
コードレビューを通す技術 / technique to pass code review
Search
oohira
April 23, 2019
Programming
1
94
コードレビューを通す技術 / technique to pass code review
oohira
April 23, 2019
Tweet
Share
More Decks by oohira
See All by oohira
git switch & git restore
oohira
0
110
私のエンジニア人生に影響を与えた技術書 / tech books that influenced my engineer life
oohira
1
290
Progressive OSS Contribution
oohira
1
150
Why Mob Programming?
oohira
3
2.2k
朝の15分読書会ふりかえり / 15min-reading-retrospective
oohira
0
160
朝の15分読書会のススメ
oohira
0
460
Ansibleで3台のビルドサーバーを3分で構築した話 / Set up build servers in 3 min by Ansible
oohira
0
200
知っておくと便利なcurl
oohira
0
210
git-svnで始めるボッチのためのGit
oohira
0
4.6k
Other Decks in Programming
See All in Programming
Go1.25からのGOMAXPROCS
kuro_kurorrr
1
770
C++20 射影変換
faithandbrave
0
500
Go Modules: From Basics to Beyond / Go Modulesの基本とその先へ
kuro_kurorrr
0
120
業務自動化をJavaとSeleniumとAWS Lambdaで実現した方法
greenflagproject
1
120
複数アプリケーションを育てていくための共通化戦略
irof
10
4k
Cursor Meetup Tokyo ゲノミクスとCursor: 進化と制約のあいだ
koido
2
1k
Passkeys for Java Developers
ynojima
3
870
F#で自在につくる静的ブログサイト - 関数型まつり2025
pizzacat83
0
310
KotlinConf 2025 現地参加の土産話
n_takehata
0
100
事業戦略を理解してソフトウェアを設計する
masuda220
PRO
22
6.2k
Effect の双対、Coeffect
yukikurage
5
1.4k
Development of an App for Intuitive AI Learning - Blockly Summit 2025
teba_eleven
0
120
Featured
See All Featured
Improving Core Web Vitals using Speculation Rules API
sergeychernyshev
16
940
Dealing with People You Can't Stand - Big Design 2015
cassininazir
367
26k
The Illustrated Children's Guide to Kubernetes
chrisshort
48
50k
Gamification - CAS2011
davidbonilla
81
5.3k
実際に使うSQLの書き方 徹底解説 / pgcon21j-tutorial
soudai
PRO
181
53k
Balancing Empowerment & Direction
lara
1
340
CSS Pre-Processors: Stylus, Less & Sass
bermonpainter
357
30k
Testing 201, or: Great Expectations
jmmastey
42
7.5k
How STYLIGHT went responsive
nonsquared
100
5.6k
Bash Introduction
62gerente
614
210k
The MySQL Ecosystem @ GitHub 2015
samlambert
251
13k
The Art of Programming - Codeland 2020
erikaheidi
54
13k
Transcript
ίʔυϨϏϡʔΛ௨ٕ͢ज़ ϏΞόογϡ-5!PPIJSB
എܠ • ਓΑΓίʔυϨϏϡʔΛࣄͱ͢Δ͕͍࣌ؒ • ͬͱ͜͏ͯ͘͠ΕͨΒΑ͍ͷʹͱ͍͏ࢥ͍ • ϨϏϡʔΞʔͷߟ͍͑ͯΔ͜ͱΛ͑Δ͜ͱͰ ϨϏϡʔΠʔͷॿ͚ʹͳΔͷͰ 2
໔ • ϨϏϡʔΞʔͷҙݟʹݸਓ͕ࠩ͋Γ·͢ • ݱࡏʢ·ͨաڈʣҰॹʹࣄΛ͍ͯ͠Δϝϯ όʔΛ߈ΊΔͷͰ͋Γ·ͤΜ 3
ॳڃฤ
$*Λ௨͢ • ϨϏϡʔΞʔਓؒʹ͔͠Ͱ͖ͳ͍ຊ࣭తͳϨϏϡʔ ׆ಈʹྗ͍ͨ͠ • ελΠϧҧճؼςετػցͷࣄ • ʮ$*͕௨͍ͬͯ·ͤΜʯͱࢦఠ͢Δͷຊస • ͬͯ๙ΊΒΕΔ͜ͱͳ͍͕ɺΒͳ͍ͱϨϏϡʔ
Ξʔʹର͢Δ৴པஷ͕࣮ۚ֬ʹݮΔ 5
$*࣮֬ʹ௨͔ͯ͠Β ϨϏϡʔґཔΛग़ͦ͏ 6
EJGGΛখ͘͞อͭ • ϨϏϡʔΞʔؔͷͳ͍मਖ਼ʹΛ͍ͨ͘ͳ͍ • ͕ࠩখ͚͞Εૉૣ࣮֬͘ʹϨϏϡʔͰ͖Δ • ϘʔΠεΧτϧʔϧͷΓ͗͢ʹҙ ˠࠞͥ͗͢ΔͱͨΓతͳमਖ਼ʹݟ͑ͯෆ҆ʹ • λεΫ.3Ͱ͋Δඞཁͳ͍
7
·ͣࣗͰEJGGΛ֬ೝ͠Α͏ 8
தڃฤ
.3ΛͪΌΜͱॻ͘ • ϨϏϡʔΞʔίʔυͱಉ͙͡Β͍.3ΛϨϏϡʔ͢Δ • .3ʹUZQPίϐϖϛε͕ଟ͍ ˠίʔυͷม໊໊ؔಉ͡ͳͷ͔ͳʁͱෆ҆ʹ • .3ͷઆ໌֬ೝґཔ͕ࡶ ˠ݅ཏ࣮ͯ͠ɾςετ͍ͯ͠Δͷ͔ͳʁͱෆ҆ʹ •
ίʔυ͑ͪ͞ΌΜͱॻ͚ΕΑ͍ͷͰʁ ˠࣗͷ؍ଌൣғͰ.3ΛͪΌΜͱॻ͚Δ͜ͱͱՁ 10
.3ͷ͍͍Ճݮ͞ ίʔυͷ͍͍Ճݮͩ͞ͱ৺ಘ͑Α͏ 11
ࣄલʹ૬ஊ͢Δ • ϨϏϡʔΞʔϓϩδΣΫτશମͷҰ؏ੑʹؔ৺͕ڧ͍ͨ Ίɺ৽͍͠ύλʔϯͷઃܭ࣮ʹ৻ॏʹͳΔ • .3Λग़͔ͯ͠Β૬ஊ͞Εͯɺ͋Ε͜ΕΓ͠ʹ ͳ͓ͬͯޓ͍ͭΒ͔͞͠ͳ͍ • ࣗͰߟ࣮͑ͯ͢Δͷ͕ϓϩάϥϛϯάͷޣຯͩ ͕ɺํͷೝࣝ߹Θͤૣ͍΄ͲखΓΛݮΒͤΔ
• ࣮ͱϨϏϡʔશʹಠཱͨ͠ϑΣʔζͰͳ͍ 12
ૣ͔͘ΒϨϏϡʔΞʔΛר͖ࠐ͏ 13
্ڃฤ
ඍົͳ࣮Λະདྷʹୗ͢ • ͍ͭᘳͳ࣮͕Ͱ͖ΔͱݶΒͳ͍ • ϨϏϡʔΞʔࠓ͑ΔϦιʔεͱকདྷͷίʔυ࣭ͷ όϥϯεΛͱΓ͍ͨ • ͍͚ͯͳ͍࣮ʹݴ͍༁ίϝϯτΛͨ͠Γɺόάཧ γεςϜʹλεΫΛొͨ͠Γ͢Δ
ˠ ՝͕͍ͬͯΔ͜ͱઌૹΓʹͨ͠ཧ༝͕͔Δ 15
ࠓͰ͖ͳͯ͘কདྷͰ͖Δ ֻ͚Λͦ͏ 16
WTࢲͨͪ • ϨϏϡʔΞʔਓؒͳͷͰɺώʔτΞοϓ͢ΔͱϨϏϡʔ ΞʔWTϨϏϡʔΠʔʹͳΓ͕ͪ • ϨϏϡʔखஈɻϨϏϡʔʹ௨͢͜ͱ͕తͰͳ͍ • ϖΞϓϩϞϒϓϩʹΓସ͑ͨํ͕ૣ͘ऴΘΔ߹ •
్த·ͰΛ͍ͬͨΜϚʔδͯ͠͠·ͬͯΓͨ͠ํ ͕ૣ͘ऴΘΔ߹ 17
νʔϜͱͯ͠λεΫΛ ऴΘΒͤΔํ๏Λ͠߹͓͏ 18
൪֎ฤ
པΉ͔Β4UBSUEJTDVTTJPO͍ͬͯͩ͘͞ • ϨϏϡʔΞʔࢦఠΛͭͣͭ࠶֬ೝ͍͖͍ͯͨ͠ • *TTVF.3ͷίϝϯτதʹεϨουΛ࡞ΕΔ 20
·ͱΊ
ͪΐͬͱͷखؒͰ εϜʔζʹϨϏϡʔΛ௨աͤ͞Α͏ 22