Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
コードレビューを通す技術 / technique to pass code review
Search
oohira
April 23, 2019
Programming
1
78
コードレビューを通す技術 / technique to pass code review
oohira
April 23, 2019
Tweet
Share
More Decks by oohira
See All by oohira
git switch & git restore
oohira
0
89
私のエンジニア人生に影響を与えた技術書 / tech books that influenced my engineer life
oohira
1
270
Progressive OSS Contribution
oohira
1
140
Why Mob Programming?
oohira
3
2k
朝の15分読書会ふりかえり / 15min-reading-retrospective
oohira
0
140
朝の15分読書会のススメ
oohira
0
420
Ansibleで3台のビルドサーバーを3分で構築した話 / Set up build servers in 3 min by Ansible
oohira
0
160
知っておくと便利なcurl
oohira
0
180
git-svnで始めるボッチのためのGit
oohira
0
4.3k
Other Decks in Programming
See All in Programming
From Idea to IDE: Developing Plugins for Android Studio
thisaay
1
220
Swiftコードバトル必勝法
toshi0383
0
170
Ruby Parser progress report 2024
yui_knk
2
230
Perl 5 OOP機構30年史 - Perl 5's OOP Mechanism over the past 30 years
moznion
0
340
『ドメイン駆動設計をはじめよう』中核の業務領域
masuda220
PRO
5
1k
connect-go で面倒くささと戦う / 2024-08-27 #newmo_layerx_go
izumin5210
2
650
Some more adventure of Happy Eyeballs
coe401_
2
190
unique パッケージから学ぶ interning と weak reference @ Asakusa.go#3
karamaru
2
810
GraphQL あるいは React における自律的なデータ取得について
quramy
11
3k
How to Break into Reading Open Source
kaspth
2
220
Kotlin 2.0が与えるAndroid開発の進化
masayukisuda
1
410
REXML改善のその後
naitoh
0
190
Featured
See All Featured
How To Stay Up To Date on Web Technology
chriscoyier
786
250k
Cheating the UX When There Is Nothing More to Optimize - PixelPioneers
stephaniewalter
278
13k
The Straight Up "How To Draw Better" Workshop
denniskardys
230
130k
Intergalactic Javascript Robots from Outer Space
tanoku
268
26k
A Philosophy of Restraint
colly
202
16k
Being A Developer After 40
akosma
84
590k
Web Components: a chance to create the future
zenorocha
309
42k
Put a Button on it: Removing Barriers to Going Fast.
kastner
58
3.4k
The Power of CSS Pseudo Elements
geoffreycrofte
71
5.3k
Stop Working from a Prison Cell
hatefulcrawdad
267
20k
Imperfection Machines: The Place of Print at Facebook
scottboms
263
13k
Practical Tips for Bootstrapping Information Extraction Pipelines
honnibal
PRO
5
480
Transcript
ίʔυϨϏϡʔΛ௨ٕ͢ज़ ϏΞόογϡ-5!PPIJSB
എܠ • ਓΑΓίʔυϨϏϡʔΛࣄͱ͢Δ͕͍࣌ؒ • ͬͱ͜͏ͯ͘͠ΕͨΒΑ͍ͷʹͱ͍͏ࢥ͍ • ϨϏϡʔΞʔͷߟ͍͑ͯΔ͜ͱΛ͑Δ͜ͱͰ ϨϏϡʔΠʔͷॿ͚ʹͳΔͷͰ 2
໔ • ϨϏϡʔΞʔͷҙݟʹݸਓ͕ࠩ͋Γ·͢ • ݱࡏʢ·ͨաڈʣҰॹʹࣄΛ͍ͯ͠Δϝϯ όʔΛ߈ΊΔͷͰ͋Γ·ͤΜ 3
ॳڃฤ
$*Λ௨͢ • ϨϏϡʔΞʔਓؒʹ͔͠Ͱ͖ͳ͍ຊ࣭తͳϨϏϡʔ ׆ಈʹྗ͍ͨ͠ • ελΠϧҧճؼςετػցͷࣄ • ʮ$*͕௨͍ͬͯ·ͤΜʯͱࢦఠ͢Δͷຊస • ͬͯ๙ΊΒΕΔ͜ͱͳ͍͕ɺΒͳ͍ͱϨϏϡʔ
Ξʔʹର͢Δ৴པஷ͕࣮ۚ֬ʹݮΔ 5
$*࣮֬ʹ௨͔ͯ͠Β ϨϏϡʔґཔΛग़ͦ͏ 6
EJGGΛখ͘͞อͭ • ϨϏϡʔΞʔؔͷͳ͍मਖ਼ʹΛ͍ͨ͘ͳ͍ • ͕ࠩখ͚͞Εૉૣ࣮֬͘ʹϨϏϡʔͰ͖Δ • ϘʔΠεΧτϧʔϧͷΓ͗͢ʹҙ ˠࠞͥ͗͢ΔͱͨΓతͳमਖ਼ʹݟ͑ͯෆ҆ʹ • λεΫ.3Ͱ͋Δඞཁͳ͍
7
·ͣࣗͰEJGGΛ֬ೝ͠Α͏ 8
தڃฤ
.3ΛͪΌΜͱॻ͘ • ϨϏϡʔΞʔίʔυͱಉ͙͡Β͍.3ΛϨϏϡʔ͢Δ • .3ʹUZQPίϐϖϛε͕ଟ͍ ˠίʔυͷม໊໊ؔಉ͡ͳͷ͔ͳʁͱෆ҆ʹ • .3ͷઆ໌֬ೝґཔ͕ࡶ ˠ݅ཏ࣮ͯ͠ɾςετ͍ͯ͠Δͷ͔ͳʁͱෆ҆ʹ •
ίʔυ͑ͪ͞ΌΜͱॻ͚ΕΑ͍ͷͰʁ ˠࣗͷ؍ଌൣғͰ.3ΛͪΌΜͱॻ͚Δ͜ͱͱՁ 10
.3ͷ͍͍Ճݮ͞ ίʔυͷ͍͍Ճݮͩ͞ͱ৺ಘ͑Α͏ 11
ࣄલʹ૬ஊ͢Δ • ϨϏϡʔΞʔϓϩδΣΫτશମͷҰ؏ੑʹؔ৺͕ڧ͍ͨ Ίɺ৽͍͠ύλʔϯͷઃܭ࣮ʹ৻ॏʹͳΔ • .3Λग़͔ͯ͠Β૬ஊ͞Εͯɺ͋Ε͜ΕΓ͠ʹ ͳ͓ͬͯޓ͍ͭΒ͔͞͠ͳ͍ • ࣗͰߟ࣮͑ͯ͢Δͷ͕ϓϩάϥϛϯάͷޣຯͩ ͕ɺํͷೝࣝ߹Θͤૣ͍΄ͲखΓΛݮΒͤΔ
• ࣮ͱϨϏϡʔશʹಠཱͨ͠ϑΣʔζͰͳ͍ 12
ૣ͔͘ΒϨϏϡʔΞʔΛר͖ࠐ͏ 13
্ڃฤ
ඍົͳ࣮Λະདྷʹୗ͢ • ͍ͭᘳͳ࣮͕Ͱ͖ΔͱݶΒͳ͍ • ϨϏϡʔΞʔࠓ͑ΔϦιʔεͱকདྷͷίʔυ࣭ͷ όϥϯεΛͱΓ͍ͨ • ͍͚ͯͳ͍࣮ʹݴ͍༁ίϝϯτΛͨ͠Γɺόάཧ γεςϜʹλεΫΛొͨ͠Γ͢Δ
ˠ ՝͕͍ͬͯΔ͜ͱઌૹΓʹͨ͠ཧ༝͕͔Δ 15
ࠓͰ͖ͳͯ͘কདྷͰ͖Δ ֻ͚Λͦ͏ 16
WTࢲͨͪ • ϨϏϡʔΞʔਓؒͳͷͰɺώʔτΞοϓ͢ΔͱϨϏϡʔ ΞʔWTϨϏϡʔΠʔʹͳΓ͕ͪ • ϨϏϡʔखஈɻϨϏϡʔʹ௨͢͜ͱ͕తͰͳ͍ • ϖΞϓϩϞϒϓϩʹΓସ͑ͨํ͕ૣ͘ऴΘΔ߹ •
్த·ͰΛ͍ͬͨΜϚʔδͯ͠͠·ͬͯΓͨ͠ํ ͕ૣ͘ऴΘΔ߹ 17
νʔϜͱͯ͠λεΫΛ ऴΘΒͤΔํ๏Λ͠߹͓͏ 18
൪֎ฤ
པΉ͔Β4UBSUEJTDVTTJPO͍ͬͯͩ͘͞ • ϨϏϡʔΞʔࢦఠΛͭͣͭ࠶֬ೝ͍͖͍ͯͨ͠ • *TTVF.3ͷίϝϯτதʹεϨουΛ࡞ΕΔ 20
·ͱΊ
ͪΐͬͱͷखؒͰ εϜʔζʹϨϏϡʔΛ௨աͤ͞Α͏ 22