Share
Embed
Transcript
125 slides
-
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ About Me ▸ Keishin Yokomaku ▸ @KeithYokoma: GitHub /
Twitter / Qiita / Stack Overflow ▸ Merpay, Inc. / Engineer ▸ Fun: Gymnastics / Cycling / Photography / Motorsport / Camping DroidKaigi 2020 2 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ͜ͷηογϣϯͷత: Objectives ▸ ϞόΠϧΞϓϦͷ։ൃϓϩηεΛ࣋ଓతʹૉૣ͘ճ͚ͭͮ͠ΒΕΔΑ͏ʹͳΔ ▸ ΤϯδχΞϦϯάνʔϜͱͯ͠ɺΑ͍ DX Λ֫ಘ͢ΔͨΊɺ ։ൃʹணख͢Δલ͔Β࣮ࡍʹϦϦʔεͯ͠ӡ༻͍ͯ͘͠·Ͱͷؒʹɺ
ͲΜͳ͜ͱʹͯ͠ࢪࡦʹऔΓΉͱΑ͍͔ɺࢦΛࣔ͠·͢ DroidKaigi 2020 3 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ͳͥ DX ͕ॏཁ͔: Why DX matters? ▸ ϓϩμΫτʑΛଓ͚Δ ▸
৽ػೳͷՃ ▸ طଘػೳͷվम ▸ όάमਖ਼ ▸ ͳͲ DroidKaigi 2020 5 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ͳͥ DX ͕ॏཁ͔: Why DX matters? ▸ ιʔείʔυຖมԽΛ͠ଓ͚Δ ▸
৽͍͠ΫϥεɾϝιουͷՃ ▸ طଘΫϥεɾϝιουͷৼΔ͍ͷมߋ ▸ ϥΠϒϥϦͷߋ৽ ▸ ͳͲ DroidKaigi 2020 6 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ͳͥ DX ͕ॏཁ͔: Why DX matters? ▸ ظؒͷΠςϨʔγϣϯΛܧଓ͠ɺϓϩμΫτΛͤ͞Δϓϩηε͕ඞཁ ▸
1 ~ 2 िؒ͝ͱͷϦϦʔεͰԾઆݕূΛͲΜͲΜճ͍ͯ͘͠ ▸ ૉૣ͍ػೳ࣮ʢࡉ͔͘࡞Γ্͍͛ͯ͘ϓϩηεͷ܁Γฦ͠ʣ ▸ ૉૣ͍ৼΓฦΓʢࡉֶ͔͘ͼΛൃݟ͠దԠ͍ͯ͘͠ϓϩηεͷ܁Γฦ͠ʣ DroidKaigi 2020 7 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ͳͥ DX ͕ॏཁ͔: Why DX matters? ▸ ظؒͷΠςϨʔγϣϯΛܧଓ͠ɺϓϩμΫτΛͤ͞Δϓϩηε͕ඞཁ ▸
1 ~ 2 िؒ͝ͱͷϦϦʔεͰԾઆݕূΛͲΜͲΜճ͍ͯ͘͠ ▸ ૉૣ͍ػೳ࣮ʢࡉ͔͘࡞Γ্͍͛ͯ͘ϓϩηεͷ܁Γฦ͠ʣ ▸ ૉૣ͍ৼΓฦΓʢࡉֶ͔͘ͼΛൃݟ͠దԠ͍ͯ͘͠ϓϩηεͷ܁Γฦ͠ʣ ▸ Α͍ DX Λ࡞Δ͜ͱͰɺ͜ͷϓϩηεΛ͏·͘ճͤΔΑ͏ʹͳΔ ▸ DX ϓϩμΫτͷʹඞཁෆՄܽ DroidKaigi 2020 8 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Agenda ▸ ࣄલ४උ ▸ ઃܭ ▸ ։ൃϓϩηε ▸ ϦϦʔε
DroidKaigi 2020 10 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ίʔσΟϯάن: Coding standards ▸ ίʔυͷॻ͖ํ (ελΠϧ) ʹ͍ͭͯೝࣝΛἧ͑Δ ▸ εϖʔεΠϯσϯτ
vs λϒΠϯσϯτ ▸ ࠷ऴߦʹվߦΛ͍ΕΔ͔Ͳ͏͔ ▸ Ұߦͷ͞ ▸ etc… DroidKaigi 2020 13 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ίʔσΟϯάن: Coding standards ▸ ίʔσΟϯάنΛϦϙδτϦͰڞ༗͍ͨ͠ ▸ .editorconfig ▸ IDE
ʹίʔσΟϯάنʹैͬͨϑΥʔϚοτΛͤ͞Δ ▸ AndroidStudio/IntelliJ IDEA ͳΒՃͷ Plugin ͳ͠Ͱ͑Δ DroidKaigi 2020 14 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ .editorconfig ͷྫ: .editorconfig example root = true [*] "//
apply the following styles to all files indent_style = space indent_size = 2 end_of_line = lf charset = utf-8 trim_trailing_whitespace = true insert_final_newline = true [*.{java,kt,kts,xml}] "// only apply to java/kt/kts/xml files max_line_length = 140 [*.md] "// only apply to markdown files trim_trailing_whitespace = false DroidKaigi 2020 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϒϥϯνઓུ: Branch strategy ▸ ϒϥϯν͝ͱʹׂΛܾΊͯӡ༻͢ΔͨΊͷϧʔϧͮ͘Γ ▸ Git flow ▸
GitHub flow DroidKaigi 2020 16 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Git flow ▸ master ▸ ϦϦʔε͝ͱʹ develop ΛϚʔδ͠ tag
ΛଧͭͨΊͷϒϥϯν ▸ develop ▸ ීஈͷ։ൃʹ͓͍ͯɺϨϏϡʔࡁΈͷࠩΛऔΓࠐΈଓ͚Δϒϥϯν ▸ release/hotfix branches ▸ ϨϏϡʔࡁΈͷόάमਖ਼ࠩΛऔΓࠐΉϒϥϯν DroidKaigi 2020 17 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Git flow - Overview DroidKaigi 2020 18 master hotfix!/*
release!/* bugfix"/* feature"/* develop v1.1.0 v1.1.1 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Git flow - Feature development DroidKaigi 2020 19 master
hotfix!/* release!/* bugfix"/* feature"/* develop Feature A Feature B -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Git flow - Feature verification and release for v1.1.0
DroidKaigi 2020 20 master hotfix!/* release!/* bugfix"/* feature"/* develop v1.1.0 Bugfix Bugfix Bugfix -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Git flow DroidKaigi 2020 21 master hotfix!/* release!/* bugfix"/*
feature"/* develop v1.1.0 v1.1.1 Bugfix -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ GitHub flow DroidKaigi 2020 23 master v1.1.0 v1.3.0 feature"/*
Feature A Feature A v1.2.0 Bugfix v1.2.1 Feature C -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϒϥϯνઓུͷൺֱ: Comparison between Git flow and GitHub flow ▸
Git flow ▸ ϦϦʔεʹ͚ͨࠩཧͷͨΊͷϒϥϯνͷ͚ํΛ͢Δ ▸ ωΠςΟϒΞϓϦͱ૬ੑ͕͍͍ ▸ GitHub flow ▸ ΞϓϦέʔγϣϯΛࡉ͔͘σϓϩΠ͢Δ͜ͱʹϑΥʔΧε͍ͯ͠Δ ▸ සൟʹσϓϩΠ͢ΔαʔόʔΞϓϦέʔγϣϯͱ૬ੑ͕͍͍ DroidKaigi 2020 24 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϒϥϯνઓུͷ࠷దԽ: Optimize branch strategy ▸ ࣗͨͪͷϫʔΫϑϩʔʹ࠷దԽͯ͠ OK ▸ Git
flow Δ͜ͱ͕ଟͯ͘ཧ͕໘ʹͳΓ͕ͪ ▸ GitHub flow Ͱ QA ϑΣʔζͷͱ͖ɺ ฏߦͯ͠ػೳ։ൃϒϥϯνΛϚʔδͮ͠Β͘ͳΔ ➡ ྆ऀͷؒͷࢠͷΑ͏ͳઓུΛߟ͑ͯΈΔ DroidKaigi 2020 25 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Combination of Git flow and GitHub flow DroidKaigi 2020
26 master feature"/* release!/* Feature A Feature B bugfix"/* Bugfix Bugfix hotfix!/* v1.1.0 Bugfix v1.1.1 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Combination of Git flow and GitHub flow DroidKaigi 2020
27 master feature"/* release!/* Feature A Feature B bugfix"/* hotfix!/* -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Combination of Git flow and GitHub flow DroidKaigi 2020
28 master feature"/* release!/* Feature A Feature B bugfix"/* Bugfix Bugfix v1.1.0 hotfix!/* -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Combination of Git flow and GitHub flow DroidKaigi 2020
29 master feature"/* release!/* Feature A Feature B bugfix"/* Bugfix Bugfix hotfix!/* v1.1.0 Bugfix v1.1.1 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ઃܭ: Architecture ▸ ઃܭΛߟ͑Δͱ͖ͷϙΠϯτΛ͑Δ ▸ ઃܭͷత ▸ ϢχοτςετͰ͔֬ΊΔ͜ͱ͕Β ▸
ઃܭΛॿ͚ΔϞδϡʔϧߏ DroidKaigi 2020 31 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ઃܭ: Architecture ▸ ͲͷύλʔϯΛ࠾༻͢Δͷ͔ ▸ MVVM ▸ MVP ▸
MVC ▸ MVI DroidKaigi 2020 32 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ઃܭ: Architecture ▸ ͲͷύλʔϯΛ࠾༻͢Δͷ͔ ▸ MVVM ▸ MVP ▸
MVC ▸ MVI ▸ ͍ͬͺ͍͋Δ DroidKaigi 2020 33 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ઃܭ: Architecture ▸ ϞόΠϧΞϓϦͷઃܭͰϑΥʔΧε͍ͨ͜͠ͱ ▸ API௨৴ϏδωεϩδοΫͳͲΛը໘ͷ࣮͔Β͏·͍ͨ͘͠ ▸ ը໘͕ͭঢ়ଶͱͦͷભҠͷํ๏Λ͏·͘දݱ͍ͨ͠ ▸
ঢ়ଶʹԠͨ͡ UI ͷߋ৽ϩδοΫΛΓ͍ͨ͠ ▸ ͜ΕΒ͕Ϣχοτςετ͍͢͠ܗͰ࣮ݱͰ͖Δ͜ͱ ▸ ඞཁ࠷ݶͷϞοΫΛ४උ͢Δ͚ͩͰࡁ·͍ͤͨ DroidKaigi 2020 35 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ઃܭ: Architecture ▸ ͏·͘ઃܭύλʔϯΛ͍͜ͳ͢ (ྫ) ▸ UIɺϏδωεϩδοΫɺAPI ௨৴ͳͲϨΠϠʔΛ͏·͍ͨ͘͠ ➡
ϨΠϠʔυΞʔΩςΫνϟɺΫϦʔϯΞʔΩςΫνϟ ▸ UI ͕ͭঢ়ଶͱͦͷભҠΛ͏·͘දݱ͍ͨ͠ ➡ ReduxɺFluxɺ͋Δ͍ LiveData ʹΑΔঢ়ଶભҠͷ௨ ▸ UI ͷૢ࡞Λೖྗͱͯ͠ϏδωεϩδοΫΛಈ͔͠ɺͦͷ݁ՌΛ͏·͘ UI ʹө͍ͨ͠ ➡ MVVMɺDataBindingɺ͋Δ͍؆୯ͳҕৡύλʔϯ DroidKaigi 2020 36 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶͱͦͷભҠΛ͏·͘දݱ͢Δ: Implement UI state machine ▸ Έͱ࣮ͯ͠ʹམͱ͠ࠐΜͩͷ ▸
ReduxɺFlux ▸ ঢ়ଶΛද͢ΦϒδΣΫτ: State ▸ ঢ়ଶભҠͷ͖͔͚ͬΛͭ͘ΔΦϒδΣΫτ: Action ▸ ঢ়ଶભҠͷৄࡉΛ࣮͢Δ: Reducer (Redux)ɺStore (Flux) DroidKaigi 2020 37 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶͱͦͷભҠΛ͏·͘දݱ͢Δ: Implement UI state machine ▸ Redux
Flux ͷߟ͑ํΛ LiveData + ViewModel Ͱ༻ͯ͠ΈΔ ▸ ঢ়ଶΛද͢ΦϒδΣΫτ: State ▸ LiveData Ͱ State ͷมߋΛ௨ ▸ ViewModel State ͷભҠํ๏Λఆٛͨ͠ϝιουΛ࣋ͭ DroidKaigi 2020 38 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶͱͦͷભҠΛ͏·͘දݱ͢Δ: Implement UI state machine ▸ ঢ়ଶΛද͢ΦϒδΣΫτͷઃܭ ▸
ඇಉظॲཧͷॲཧதɾޭɾࣦഊͷදݱ ▸ Either Λ͏গ֦͠ுͨ͠ sealed class ʹΑΔදݱ ▸ ॳظঢ়ଶɾॲཧதɾޭɾࣦഊΛද͢ ▸ RemoteDataK / Kotlin ͷ sealed class Λ͍͜ͳ͢ by kikuchy DroidKaigi 2020 39 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶͱͦͷભҠΛ͏·͘දݱ͢Δ: Implement UI state machine ▸ ঢ়ଶΛද͢ΦϒδΣΫτͷઃܭ ▸
UI Ͱඞཁͳσʔλܕͷม ▸ API Ϩεϙϯεͷܕ͕ͦͷ··ը໘࣮ʹͯ·ΔͱݶΒͳ͍ ▸ ϨΠϠʹ߹ΘͤͨܕͷίϯόʔτΛͯ͋͛͠Δ ▸ e.g. ෳͷ API ϨεϙϯεΛΈ߹Θͤͯ UI ʹө͢Δ ➡ ෳͷ API ϨεϙϯεΛ߹ͨ͠ܕΛ࡞Δ DroidKaigi 2020 40 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶͱͦͷભҠΛ͏·͘දݱ͢Δ: Implement UI state machine ▸ ঢ়ଶΛද͢ΦϒδΣΫτͷઃܭ ▸
ྫ֎ͷऔΓѻ͍ ▸ ϓϩάϥϛϯάͷϛεʹΑΔͷ: ແཧʹ catch ͠ͳ͍ ▸ I/O ͷࣦഊ: ࣦഊͨ͠ཧ༝Λઆ໌͢ΔΦϒδΣΫτʹม ▸ see also: ந֓೦ʹదͨ͠ྫ֎Λεϩʔ͢Δ (Effective Java 3rd Edition: Item 73) DroidKaigi 2020 41 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶͱͦͷભҠΛ͏·͘දݱ͢Δ: Implement UI state machine data class SampleViewState(
"// RemoteData: sealed type describing data loading state "// Initial/Loading/Success/Failure val apiData: RemoteData<String, Exception> = Initial "// …… ) -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶͱͦͷભҠΛ͏·͘දݱ͢Δ: Implement UI state machine class SampleViewModel( private
val dataSource: SampleDataSource ) : ViewModel() { "// never allow others to mutate the state private val viewStatePublisher: MutableLiveData<SampleViewState> = MutableLiveData(SampleViewState()) val viewState: LiveData<SampleViewState> = viewStatePublisher fun loadData() { "// …… implement state changes "// …… start loading, subscribe result from data source, emit success or failure } } -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶͱͦͷભҠΛ͏·͘දݱ͢Δ: Implement UI state machine class SampleViewModel(private val
dataSource: SampleDataSource) : ViewModel() { private val viewStatePublisher: MutableLiveData<SampleViewState> = MutableLiveData(SampleViewState()) fun loadData() { viewStatePublisher.value"?.let { state "-> "// notify apiData becomes loading viewStatePublisher.value = state.copy(apiData = Loading()) } } } -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶͱͦͷભҠΛ͏·͘දݱ͢Δ: Implement UI state machine class SampleViewModel(private val
dataSource: SampleDataSource) : ViewModel() { fun loadData() { "// …… dataSource.loadApiData() .observeOn(AndroidSchedulers.mainThread()) .subscribe({ data "-> viewStatePublisher.value"?.let { state "-> "// notify apiData successfully loaded viewStatePublisher.value = state.copy(apiData = Success(data)) } }, { exception "-> viewStatePublisher.value"?.let { state "-> "// notify apiData loading failed viewStatePublisher.value = state.copy(apiData = Failure(exception)) } }) } } -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶͱͦͷભҠΛ͏·͘දݱ͢Δ: Implement UI state machine class SampleFragment :
Fragment() { private lateinit var viewModel: SampleViewModel override fun onCreate(savedInstanceState: Bundle?) { "// …… viewModel.loadData() viewModel.viewState.observe(this, Observer { state "-> when (it) { is Loading "-> "// show loading view is Success "-> "// apply data to UI is Failure "-> "// show error message } }) } } -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ςετ: Test ▸ State ͷঢ়ଶભҠΛςετ͢Δ߹ ▸ ͋Δೖྗʹର͠ɺظͨ͠௨Γͷ State ͕ग़ྗ͞ΕΔ͜ͱ
▸ State ͷมԽͷॱ൪͕कΒΕ͍ͯΔ͜ͱ ▸ Initial → Loading → Success or Failure DroidKaigi 2020 47 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶભҠͷςετ: Unit Test for UI state machine class
SampleViewModel(private val dataSource: SampleDataSource) : ViewModel() { private val viewStatePublisher: MutableLiveData<SampleViewState> = MutableLiveData(SampleViewState()) val viewState: LiveData<SampleViewState> = viewStatePublisher fun startLoading() { viewStatePublisher.value"?.let { state "-> "// notify apiData becomes loading viewStatePublisher.value = state.copy(apiData = Loading()) } dataSource.loadApiData() .observeOn(AndroidSchedulers.mainThread()) .subscribe({ data "-> viewStatePublisher.value"?.let { state "-> "// notify apiData successfully loaded viewStatePublisher.value = state.copy(apiData = Success(data)) } }, { exception "-> viewStatePublisher.value"?.let { state "-> "// notify apiData loading failed viewStatePublisher.value = state.copy(apiData = Failure(exception)) } }) } } -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶભҠͷςετ: Unit Test for UI state machine class
SampleViewModel(private val dataSource: SampleDataSource) : ViewModel() { private val viewStatePublisher: MutableLiveData<SampleViewState> = MutableLiveData(SampleViewState()) val viewState: LiveData<SampleViewState> = viewStatePublisher fun startLoading() { viewStatePublisher.value"?.let { state "-> "// notify apiData becomes loading viewStatePublisher.value = state.copy(apiData = Loading()) } dataSource.loadApiData() .observeOn(AndroidSchedulers.mainThread()) .subscribe({ data "-> viewStatePublisher.value"?.let { state "-> "// notify apiData successfully loaded viewStatePublisher.value = state.copy(apiData = Success(data)) } }, { exception "-> viewStatePublisher.value"?.let { state "-> "// notify apiData loading failed viewStatePublisher.value = state.copy(apiData = Failure(exception)) } }) } } Observed as 1st value -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶભҠͷςετ: Unit Test for UI state machine class
SampleViewModel(private val dataSource: SampleDataSource) : ViewModel() { private val viewStatePublisher: MutableLiveData<SampleViewState> = MutableLiveData(SampleViewState()) val viewState: LiveData<SampleViewState> = viewStatePublisher fun startLoading() { viewStatePublisher.value"?.let { state "-> "// notify apiData becomes loading viewStatePublisher.value = state.copy(apiData = Loading()) } dataSource.loadApiData() .observeOn(AndroidSchedulers.mainThread()) .subscribe({ data "-> viewStatePublisher.value"?.let { state "-> "// notify apiData successfully loaded viewStatePublisher.value = state.copy(apiData = Success(data)) } }, { exception "-> viewStatePublisher.value"?.let { state "-> "// notify apiData loading failed viewStatePublisher.value = state.copy(apiData = Failure(exception)) } }) } } Observed as 2nd value -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶભҠͷςετ: Unit Test for UI state machine class
SampleViewModel(private val dataSource: SampleDataSource) : ViewModel() { private val viewStatePublisher: MutableLiveData<SampleViewState> = MutableLiveData(SampleViewState()) val viewState: LiveData<SampleViewState> = viewStatePublisher fun startLoading() { viewStatePublisher.value"?.let { state "-> "// notify apiData becomes loading viewStatePublisher.value = state.copy(apiData = Loading()) } dataSource.loadApiData() .observeOn(AndroidSchedulers.mainThread()) .subscribe({ data "-> viewStatePublisher.value"?.let { state "-> "// notify apiData successfully loaded viewStatePublisher.value = state.copy(apiData = Success(data)) } }, { exception "-> viewStatePublisher.value"?.let { state "-> "// notify apiData loading failed viewStatePublisher.value = state.copy(apiData = Failure(exception)) } }) } } Observed as 3rd value if success -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶભҠͷςετ: Unit Test for UI state machine class
SampleViewModel(private val dataSource: SampleDataSource) : ViewModel() { private val viewStatePublisher: MutableLiveData<SampleViewState> = MutableLiveData(SampleViewState()) val viewState: LiveData<SampleViewState> = viewStatePublisher fun startLoading() { viewStatePublisher.value"?.let { state "-> "// notify apiData becomes loading viewStatePublisher.value = state.copy(apiData = Loading()) } dataSource.loadApiData() .observeOn(AndroidSchedulers.mainThread()) .subscribe({ data "-> viewStatePublisher.value"?.let { state "-> "// notify apiData successfully loaded viewStatePublisher.value = state.copy(apiData = Success(data)) } }, { exception "-> viewStatePublisher.value"?.let { state "-> "// notify apiData loading failed viewStatePublisher.value = state.copy(apiData = Failure(exception)) } }) } } Observed as 3rd value if error -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶભҠͷςετ: Unit Test for UI state machine class
SampleViewModelTest : Spek({ beforeEachTest { RxAndroidPlugins.setMainThreadSchedulerHandler { Scheduler.trampoline() } ArchTaskExecutor.getInstance().setDelegate(TestExecutor()) } afterEachTest { RxAndroidPlugins.reset() ArchTaskExecutor.getInstance().setDelegate(null) } }) class TestExecutor : TaskExecutor() { override fun executeOnDiskIO(runnable: Runnable) { runnable.run() } override fun isMainThread(): Boolean = true override fun postToMainThread(runnable: Runnable) { runnable.run() } } -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶભҠͷςετ: Unit Test for UI state machine class
SampleViewModelTest : Spek({ Feature("SampleViewModel#startLoading") { val dataSource: SampleDataSource by memoized(CachingMode.EACH_GROUP) { mockk<SampleDataSource>(relaxed = true) } Scenario("Load data successfully") { "// Test cases verifying state changes in successful scenario } Scenario("Load data unsuccessfully") { "// Test cases verifying state changes in failure scenario } } }) -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶભҠͷςετ: Unit Test for UI state machine class
SampleViewModelTest : Spek({ Scenario("Load data successfully") { lateinit var viewModel: SampleViewModel lateinit var observer: Observer<SampleViewState> lateinit var changedStateSlot: CapturingSlot<SampleViewState> Given("ViewModel with initial state and state observer") { changedStateSlot = slot() observer = mockk(relaxed = true) { every { onChanged(capture(changedStateSlot)) } just Runs } every { dataSource.loadApiData() } returns Observable.just("foo") viewModel = NotificationViewModel(dataSource) } } }) -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶભҠͷςετ: Unit Test for UI state machine class
SampleViewModelTest : Spek({ When("Start observing states") { viewModel.viewState.observeForever(observer) } And("Start loading") { viewModel.startLoading() } Then("State changes observed in the specified order") { verifyOrder { observer.onChanged(eq(SampleViewState(apiData = Initial))) observer.onChanged(eq(SampleViewState(apiData = Loading()))) observer.onChanged(eq(SampleViewState(apiData = Success("foo")))) } } }) -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ UI ͷঢ়ଶભҠͷςετ: Unit Test for UI state machine class
SampleViewModelTest : Spek({ When("Start observing states") { viewModel.viewState.observeForever(observer) } And("Start loading") { viewModel.startLoading() } Then("State changes observed in the specified order") { verifyOrder { observer.onChanged(eq(SampleViewState(apiData = Initial))) observer.onChanged(eq(SampleViewState(apiData = Loading()))) observer.onChanged(eq(SampleViewState(apiData = Success("foo")))) } } }) -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Ϟδϡʔϧߏͱ໋໊نଇ: Module structure and naming convention ▸ γϯάϧϞδϡʔϧ ▸
ϚϧνϞδϡʔϧ ▸ Dynamic Feature Modules DroidKaigi 2020 58 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ γϯάϧϞδϡʔϧ: Single module ▸ apk Λੜ͢ΔϞδϡʔϧʹ͕ͯ͋͢Δ ▸ Pros ▸
ߏͷ͜ͱͰ·ͳͯ͘ࡁΉ ▸ Cons ▸ ϏϧυΛ্͛ͨ͘ͳͬͨͱ͖ʹɺGradle ͷ͘͠ΈͷԸܙΛड͚ͮΒ͍ ▸ Ͳͷύοέʔδ༰қʹࢀরՄೳͳͨΊɺҙਤ͠ͳ͍ґଘؔΛ࡞Γ͍͢ DroidKaigi 2020 59 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϚϧνϞδϡʔϧ: Multiple modules ▸ ϞδϡʔϧΛෳʹ͠ɺapk Λੜ͢ΔϞδϡʔϧ͕ͯ͢Λू͢Δ ▸ Pros ▸
Ϟδϡʔϧͷ໋໊ʹΑׂͬͯΛ໌ࣔͰ͖Δ ▸ Gradle ͷΈͰϏϧυΛ্͍͛͢ ▸ Cons ▸ Ϟδϡʔϧͷํ๏ʹڞ௨ೝ͕ࣝඞཁ DroidKaigi 2020 60 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ μΠφϛοΫϑΟʔνϟʔϞδϡʔϧ: Dynamic Feature Modules ▸ Dynamic Delivery Λ͢ΔͳΒඞਢ ▸
Pros ▸ ϚϧνϞδϡʔϧ͕ڧ੍ʹͳΔͷͰɺಉ͡ϝϦοτΛಘΒΕΔ ▸ Play Store Ͱ͢ΔΞϓϦͷαΠζΛখ͘͞Ͱ͖Δ ▸ Cons ▸ Ϟδϡʔϧͷํ๏ʹڞ௨ೝ͕ࣝඞཁ DroidKaigi 2020 61 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Ϟδϡʔϧͷׂํ๏: Modularization strategy ▸ Ͳ͏͍͏୯ҐͰϞδϡʔϧΛͭ͘Δͷ͔ܾΊ͓ͯ͘ ▸ ϨΠϠʔυΞʔΩςΫνϟͷͰׂ ▸ ػೳ͝ͱʹׂ
▸ ͜ΕΒͷΈ߹Θͤ DroidKaigi 2020 62 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Ϟδϡʔϧͷ໋໊: Naming convention for module ▸ Ϟδϡʔϧׂͷ୯ҐʹԠ໋໊ͨ͡نଇΛ࡞͓ͬͯ͘ ▸ ΞϓϦέʔγϣϯຊମ:
app ▸ ֤छػೳͷ UI ࣮: feature_** ▸ Ϣʔεέʔε: usecase_** ▸ σʔλΞΫηε: repository_** ▸ ڞ௨ॲཧ: common_** DroidKaigi 2020 63 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Ϟδϡʔϧͷґଘؔ: Dependencies between modules DroidKaigi 2020 64 feature_a repository_a
usecase_a feature_b usecase_b repository_b feature_b usecase_c repository_c -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Ϟδϡʔϧͷґଘؔ: Dependencies between modules DroidKaigi 2020 65 feature_a repository_a
usecase_a feature_b usecase_b repository_b feature_b usecase_c repository_c -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Ϟδϡʔϧͷґଘؔ: Dependencies between modules DroidKaigi 2020 66 feature_a repository_a
usecase_a feature_b usecase_b repository_b feature_b usecase_c repository_c -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ։ൃϓϩηε: Development Process ▸ ʑͷ։ൃϓϩηεΛεϜʔζʹճ͠ଓ͚ΔͨΊͷऔΓΈ ▸ ຊʹਓͷྗΛඞཁͱ͢Δॴʹਓ͕ूதͯ͠औΓΊΔΑ͏ʹ͢Δ ▸ খ͞ͳࣦഊʹૉૣ͘ؾ͚ΔΈΛ࡞Δ
▸ ٕज़తͳϑΟʔυόοΫϧʔϓΛ࡞Δ ▸ ࣋ଓతʹऔΓΈΛճ͍ͯ͘͠ΈΛ࡞Δ ▸ ࣗಈԽʂ DroidKaigi 2020 68 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ࣗಈԽ: Automation ▸ ࣗಈԽ͢Δͱ͖ʹߟྀ͢Δ͜ͱ ▸ ඞཁͳ͜ͱΛɺඞཁͳ͚࣮ͩߦ͢Δ͜ͱ ▸ ϏϧυͷՌΛ୭ͰΞΫηεͰ͖Δॴʹอଘ͓ͯ͘͜͠ͱ ▸
ϓϩδΣΫτͷͱڞʹεέʔϧ͍͚ͯ͠ΔΈͰ͋Δ͜ͱ DroidKaigi 2020 69 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ࣗಈԽ: Automation ▸ CI (Continuous Integration) CD (Continuous
Delivery) ▸ Ϗϧυ ▸ ςετ ▸ ੩తղੳ ▸ ΞϓϦͷ৴ ▸ ʑͷϫʔΫϑϩʔ DroidKaigi 2020 70 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϏϧυͷࣗಈԽ: Build Automation ▸ ͕ࠩਖ਼͘͠ίϯύΠϧͰ͖Δ͜ͱΛอূ ▸ ΞϓϦέʔγϣϯͷ৴Λ͢ΔͨΊʹඞཁෆՄܽ ▸ ػೳ։ൃϒϥϯν:
debug ϏϧυͷΈੜ ▸ master develop ͳͲ: release Ϗϧυੜ DroidKaigi 2020 71 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ςετͷࣗಈԽ: Test Automation ▸ ϓϩμΫτͷͱڞʹςετͷ࣮ߦ࣌ؒ૿͍͑ͯ͘ ▸ ࣮ߦ࣌ؒΛ͘͢Δʹ… ▸ Gradle
͕͑ΔϓϩηεͱϞδϡʔϧΛ૿ͯ͠ฒྻੑΛ্͛Δ ▸ ςετ࣮ߦ༻ͷίϯςφΛෳ্ཱͪ͛ɺ࣮ߦ͢ΔςετΛࢄ͢Δ ▸ ࣌ؒʹґଘ͍ͯͯͭ͠ඞཁͷ͋ΔςετΛݮΒ͢ ▸ etc…… DroidKaigi 2020 73 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ςετͷฒྻԽ: Parallelize unit test execution DroidKaigi 2020 74 ▸
CircleCI Ͱͷྫ ▸ ͻͱͭͷεςοϓͰෳͷίϯςφΛىಈ͢ΔΈΛ͏ ▸ ෳͷίϯςφͰςετΛಉ࣌ʹ࣮ߦ͢Δ ▸ ͦΕͧΕͷίϯςφͰผͷςετΛ࣮ߦ͠ɺશମͰ͔͔Δ࣌ؒΛॖ͢Δ -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ςετͷฒྻԽ: Parallelize unit test execution DroidKaigi 2020 75 Container
0 Container 1 Container 2 Container 3 :module_a:test :module_b:test …… :module_c:test :module_d:test …… :module_e:test :module_f:test …… :module_g:test :module_h:test …… Container 0 :module_a:test :module_b:test :module_c:test :module_d:test :module_e:test :module_f:test …… ୯Ұίϯςφͷ߹ ෳίϯςφͷ߹ -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ςετͷฒྻԽ: Parallelize unit test execution DroidKaigi 2020 76 ▸
୯ҰϞδϡʔϧͷ߹ ▸ CircleCI CLI Λ֤ͬͯίϯςφ͝ͱʹϑΝΠϧΛৼΓ͚Δ circleci tests glob "**/test""/**"/*.kt" | circleci tests split ▸ ϑΝΠϧ໊ΛΫϥε໊ʹมͯ͋͛͠ΕɺGradle ͷύϥϝʔλʹͤΔ ▸ ෳϞδϡʔϧͷ߹ ▸ ֤ίϯςφ͝ͱʹϞδϡʔϧΛৼΓ͚ΔॲཧΛࣗͰॻ͘ -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ςετͷฒྻԽ: Parallelize unit test execution "// The index number
of container this execution is on. val containerIndex = System.getenv("CIRCLE_NODE_INDEX")"?.toInt() "?: 0 "// Total number of containers running in parallel. val totalContainer = System.getenv("CIRCLE_NODE_TOTAL")"?.toInt() "?: 0 "// Select modules to run unit tests on the container val modules = project.subprojects .withIndex() .filter { it.index % totalContainer "== containerIndex } .map { it.value } "// Execute tests modules.forEach { module "-> "./gradlew :${module.name}:test".runCommand() } DroidKaigi 2020 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ੩తղੳͷࣗಈԽ: Static Analysis Automation ▸ ੩తղੳΛࣗಈԽ͠ίʔυϨϏϡʔʹཱͯΔ ▸ ಈ͔͢λΠϛϯά Pull
Request ͕Ͱ͖ͨ࣌ͳͲ ▸ ੩తղੳͷ݁ՌΛϨϙʔτ͢Δ ▸ xml html ͷϨϙʔτϑΝΠϧ CI ͷՌͱଊ͑Δ ▸ Pull Request ͕͋ΕɺϨϙʔτͷ༰Λίϝϯτ͢Δ DroidKaigi 2020 78 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ৴ͷࣗಈԽ: Delivery Automation ▸ มߋΛ͍ͭͰࢼͤΔΑ͏ʹͯ͠ɺϓϩμΫτͷϑΟʔυόοΫϧʔϓΛ࡞Δ ▸ ΞϓϦέʔγϣϯͷϏϧυ͕ऴΘͬͨΒ৴ ▸ Firebase
App Distribution, DeployGate, HockeyApp, etc… DroidKaigi 2020 79 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϫʔΫϑϩʔͷࣗಈԽ: Automation ▸ e.g. QA ϑΣʔζͰͷόάमਖ਼Λ master ʹऔΓࠐΉ࡞ۀͷࣗಈԽ ▸
ϚʔδͷࠩΛখͯ͘͞͠ɺίϯϑϦΫτͷϦεΫΛԼ͛Δ ▸ e.g. release ϒϥϯνͷόάमਖ਼Λຖ master औΓࠐΉ ▸ e.g. master ϒϥϯνͷߋ৽Λຖ֤։ൃϒϥϯνऔΓࠐΉ ▸ ϒϥϯνઓུʹ߹Θ࣮ͤͯɾӡ༻͢Δ DroidKaigi 2020 81 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϫʔΫϑϩʔͷࣗಈԽ: Automation ▸ QA ϑΣʔζͰͷόάमਖ਼Λ master ʹऔΓࠐΉ࡞ۀͷࣗಈԽ DroidKaigi 2020
82 master release"/* master release"/* releaseϒϥϯνӡ༻ͷ ࠷ޙʹϚʔδ͢Δ߹ releaseϒϥϯνΛఆظతʹ ࣗಈͰϚʔδ͢Δ߹ -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϫʔΫϑϩʔͷࣗಈԽ: How to automate a workflow ▸ CLI ͰࣗಈԽͨ͠λεΫΛ࣮ߦͰ͖ΔΑ͏ʹ͢Δ
▸ Shell Script ▸ Gradle Custom Tasks ▸ etc… DroidKaigi 2020 83 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Gradle Custom Tasks ʹΑΔࣗಈԽ: Automation with Gradle Custom Tasks
▸ Gradle Custom Tasks ͷ࡞Γํ ▸ project_root/buildSrc ϞδϡʔϧʹλεΫͷ࣮Λॻ͘ ▸ project_root/build.gradle.kts ͰλεΫͷొΛ͢Δ DroidKaigi 2020 84 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Gradle Custom Tasks ʹΑΔࣗಈԽ: Automation with Gradle Custom Tasks
"// buildSrc/build.gradle.kts repositories { jcenter() } plugins { `kotlin-dsl` `java-gradle-plugin` } dependencies { implementation(gradleApi()) } DroidKaigi 2020 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Gradle Custom Tasks ʹΑΔࣗಈԽ: Automation with Gradle Custom Tasks
"// buildSrc/src/main/kotlin/com/example/MyCustomTask.kt open class MyCustomTask : DefaultTask() { @Input lateinit var parameter: String @TaskAction fun doAction() { "// … do your job! } } DroidKaigi 2020 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Gradle Custom Tasks ʹΑΔࣗಈԽ: Automation with Gradle Custom Tasks
"// buildSrc/src/main/kotlin/com/example/MyCustomTask.kt open class MyCustomTask : DefaultTask() { @Input lateinit var parameter: String @TaskAction fun doAction() { "// … do your job! } } DroidKaigi 2020 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Gradle Custom Tasks ʹΑΔࣗಈԽ: Automation with Gradle Custom Tasks
"// buildSrc/src/main/kotlin/com/example/MyCustomTask.kt open class MyCustomTask : DefaultTask() { @Input lateinit var parameter: String @TaskAction fun doAction() { "// … do your job! } } DroidKaigi 2020 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Gradle Custom Tasks ʹΑΔࣗಈԽ: Automation with Gradle Custom Tasks
"// buildSrc/src/main/kotlin/com/example/MyCustomTask.kt open class MyCustomTask : DefaultTask() { @Input lateinit var parameter: String @TaskAction fun doAction() { "// … do your job! } } DroidKaigi 2020 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ Gradle Custom Tasks ʹΑΔࣗಈԽ: Automation with Gradle Custom Tasks
"// build.gradle.kts in the project root tasks.register<MyCustomTask>("myTask") { parameter = "Hello, World" } DroidKaigi 2020 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ίʔυϨϏϡʔ: Code Review ▸ ઃܭํ໋໊ͷΘ͔Γ͢͞ɺߟྀ࿙ΕνΣοΫʹਓͷྗΛूத͍ͨ͠ ▸ ࣗಈԽͰ͖Δͱ͜ΖͲΜͲΜࣗಈԽ͢Δ ▸ ίʔσΟϯάنͷڞ༗:
.editorconfig Λ࡞͓ͬͯ͘ ▸ ίʔσΟϯάنʹै͍ͬͯΔ͔νΣοΫ: CI Ͱ ktlint ͳͲΛಈ͔͢ ▸ Α͋͘Δؒҧ͍ΛνΣοΫ: CI Ͱ android lint ͳͲΛಈ͔͢ DroidKaigi 2020 91 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ίʔυϨϏϡʔ: Code Review ▸ υϝΠϯࣝΛ࣋ͬͨਓʹϨϏϡʔΛґཔ͠ɺίʔυϨϏϡʔͷ࣭Λ্͛Δ ▸ ͩΕʹϨϏϡʔͯ͠΄͍͔͠ઃఆ͢Δ ▸ CODEOWNERS
▸ σΟϨΫτϦ͝ͱʹઃఆ ▸ σΟϨΫτϦԼͷϑΝΠϧʹࠩΛ࡞ΔͱɺࣗಈͰઃఆͨ͠ਓ͕ϨϏϡϫʔ ʹͳΔ DroidKaigi 2020 92 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ίʔυϨϏϡʔ: Code Review # KeithYokoma is the owner of
Module A /module_a/ @KeithYokoma # Anyone in team_a can review changes in Module B /module_b/ @team_a # Either KeithYokoma or someone in team_a can review /module_c/ @KeithYokoma @team_a DroidKaigi 2020 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ίʔυϨϏϡʔ: Code Review ▸ ίʔυϨϏϡʔʹૉૣ͘औΓΜͰ։ൃαΠΫϧΛͳΊΒ͔ʹճ͢ ▸ ίʔυϨϏϡʔͷϦΫΤετΛ௨͢Δ ▸ Pull
Reminders ▸ ࣗѼͯʹ௨Λ͢Δ ▸ ಛఆͷνϟϯωϧͰɺApproval ͷͳ͍ Pull Request Λ௨͢Δ DroidKaigi 2020 94 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ίʔυϨϏϡʔ: Code Review ▸ ίʔυϨϏϡʔʹૉૣ͘औΓΜͰ։ൃαΠΫϧΛͳΊΒ͔ʹճ͢ ▸ Pull Request ͷઆ໌Λ͏·͘ॻ͘
▸ Ͳ͏͍͏తͷࠩͳͷ͔Λઆ໌ͯ͠΄͍͠ ▸ ࠩΛಡΉ্Ͱͷલఏ͕ࣝ͋Εઆ໌ͯ͠΄͍͠ DroidKaigi 2020 95 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ίʔυϨϏϡʔ: Code Review ▸ νʔϜͰڞ௨ͷϑΥʔϚοτ͕͋Δͱॻ͖͘͢ͳΔ ▸ ςϯϓϨʔτͷ׆༻ ▸ GitHub:
.github/PULL_REQUEST_TEMPLATE.md ▸ GitLab: .gitlab/merge_request_templates/XXX.md DroidKaigi 2020 96 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ςϯϓϨʔτྫ: Example of pull request template "## Summary <!——
Describe the change set in short ——> "## Kind <!—— Describe what kind of change? e.g. Bugfix, New feature, Design adjustment, etc…… ——> "## Details <!—— e.g. What caused the issue? How you solved it? Any caveats? Anything out of scope? ——> "## Links <!—— Put links related to this PR if any ——> - Task Ticket: - Design Doc: - Crashlytics Issue: "## Screenshot <!—— Put screenshots indicating what has been changed with this PR if any ——> Before | After :——:|:——: <img src="" width="300" "/>|<img src="" width="300" "/> DroidKaigi 2020 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϦϦʔε: Release ▸ ҆શͳϦϦʔεΛࢧ͑ΔΈͮ͘Γ ▸ ϑΟʔνϟʔϑϥά ▸ ϦϦʔετϨΠϯ ▸
ϞχλϦϯά DroidKaigi 2020 99 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϑΟʔνϟʔϑϥά: Feature Flag ▸ ػೳͷग़͚͠Λίϯτϩʔϧͯ͠ૉૣ͍։ൃαΠΫϧΛอͭ ▸ ϑΟʔνϟʔϑϥάΛ͏໘ ▸ ஈ֊తʹػೳΛެ։͍ͨ͠ͱ͖
▸ 1ͷϦϦʔεαΠΫϧΛ͑ͯػೳ։ൃΛ͍ͨ͠ͱ͖ DroidKaigi 2020 100 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϑΟʔνϟʔϑϥάΛ͏ྫ: Example usage of Feature Flag ▸ ஈ֊తʹػೳΛެ։͍ͨ͠ͱ͖ ▸
Firebase Remote Config ɺࣗલͷΈͳͲͰઃఆΛม͑Δ ▸ ༷ʑͳଐੑ͔ΒઃఆΛੜͰ͖Δ ▸ ৽͍͠ػೳͷ։ൃ͕ऴΘΓɺঃʑʹ։์͢Δͱ͖ʹ༗ޮ DroidKaigi 2020 101 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϑΟʔνϟʔϑϥάΛ͏ྫ: Example usage of Feature Flag ▸ 1ͷϦϦʔεαΠΫϧΛ͑ͯػೳ։ൃΛ͍ͨ͠ͱ͖ ▸
Git ͷϒϥϯνΛࡉ͔͘࡞ͬͯϚʔδࠩ͠ΛੵΈ্͍͛ͯ͘ ▸ ࣮ͷͰ։ൃ్தͷػೳΛݟ͑ͳ͍ɾ͑ͳ͍Α͏ʹ࠹͙ DroidKaigi 2020 102 master Merge Feature A-1 v1.1.0 Merge Feature A-2 v1.2.0 Merge Feature A-3 v1.2.1 Finalize Feature A v1.3.0 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϑΟʔνϟʔϑϥάΛ͏ྫ: Example usage of Feature Flag ▸ ࣮ͷͷํ ▸
BuildConfig ʹϑΟʔνϟʔϑϥάΛఆٛ͢Δ ▸ UI ͷͭͳ͗͜ΈΛ࠷ޙʹ࣮ࢪ ▸ ։ൃऀ͚ͷઃఆը໘Ͱ༗ޮɾແޮΛΓସ͑Δ ▸ etc… DroidKaigi 2020 103 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϑΟʔνϟʔϑϥάΛ͏ྫ: Example usage of Feature Flag ▸ BuildConfig ʹϑΟʔνϟʔϑϥάΛఆٛ͢Δ߹
▸ e.g. طଘը໘ʹ৽͍͠ػೳΛͬͨίϯϙʔωϯτΛՃ͢Δ࣮ DroidKaigi 2020 104 master Merge Feature A-1 v1.1.0 Merge Feature A-2 v1.2.0 Merge Feature A-3 v1.2.1 Finalize Feature A v1.3.0 ৽͍͠ػೳ͚ͷ UI ίϯϙʔωϯτ࡞ ৽͍͠ػೳͷ Ϟσϧ࣮ Ϟσϧͱ UI ίϯϙʔωϯτ Λͭͳ͗͜Ή BuildConfig ͷϑϥάΛ ༗ޮԽ͢Δ -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϑΟʔνϟʔϑϥάΛ͏ྫ: Example usage of Feature Flag ▸ UI ͷͭͳ͗ࠐΈΛ࠷ޙʹΔ߹
▸ e.g. ৽͍͠ػೳͷઃఆը໘Λ࡞ΓɺઃఆҰཡʹ߲Λ࣮͢ DroidKaigi 2020 105 master Merge Feature A-1 v1.1.0 Merge Feature A-2 v1.2.0 Merge Feature A-3 v1.2.1 Finalize Feature A v1.3.0 ͋ͨΒ͍͠ઃఆը໘ͷ ϨΠΞτ࡞ ͋ͨΒ͍͠ઃఆը໘ͷ Ϟσϧ࣮ Ϟσϧͱը໘Λͭͳ͗͜Ή ઃఆҰཡʹɺ৽͍͠ઃఆը໘ ͷಋઢΛ͢ -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϑΟʔνϟʔϑϥάͷҙ: Caveats of Feature Flag ▸ ϑΟʔνϟʔϑϥάͰͨ͠ػೳͷ։ൃ͕ଞͷطଘػೳʹӨڹΛ༩͑ͳ͍ DroidKaigi 2020
106 Existing Feature New Feature Existing Logic New Logic Shared Logic Existing Feature New Feature -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϑΟʔνϟʔϑϥάͷҙ: Caveats of Feature Flag ▸ "Release toggles are
the last thing you should do" by Martin Fowler ▸ ϑϥάΛͭ͜ͱͷίετগͳ͔Βͣ͋Δ ▸ ༗ޮԽ͢ΔλΠϛϯά ▸ Θͳ͘ͳͬͨΒআ͢Δ ▸ ϑϥάΛ࣋ͭ΄͔ʹऔΓ͏Δબࢶ ▸ UI ͷͭͳ͗͜ΈΛ࠷ޙʹ͢Δ ▸ ػೳͦͷͷΛࡉ͔͘Θ͚ɺখ͘͞ϦϦʔε͢Δ DroidKaigi 2020 107 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϦϦʔετϨΠϯ: Release Train ▸ ϦϦʔεεέδϡʔϧΛݻఆͯ͠ܧଓతʹ҆શͳϦϦʔεΛ͢Δ ▸ ϦϦʔετϨΠϯӡ༻ͷେݪଇ ▸ ܾ·ͬͨεέδϡʔϧ͔Βٯࢉͯ͠։ൃΛ͍ͯ͘͠
▸ ؒʹ߹Θͳ͍ͷ࣍ͷϦϦʔεΛͭ ▸ نͷେ͖ͳ։ൃͳΒͰͷ՝ղܾํ๏ ▸ ͨ͘͞ΜͷϓϩδΣΫτؒͷௐ͝ͱΛ͔Γ͍ͨ͘͢͠ DroidKaigi 2020 108 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ࢹମ੍: Metrics monitoring ▸ ૉૣ͘ҟৗʹؾ͖ͮɺૉૣ͘ରࡦΛଧͭ ▸ ҟৗͷछྨ ▸ ΞϓϦͷΫϥογϡ
▸ ྫ֎έʔεͷසൃ ▸ ϦάϨογϣϯͷൃੜ ▸ ύϑΥʔϚϯεͷྼԽ DroidKaigi 2020 109 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ࢹମ੍: Metrics monitoring ▸ ΈͰղܾ: Crashlytics ▸ ΞϥʔτΛ Slack
ʹߘ͢Δ ▸ ৽نͷΫϥογϡΛݕͨ͠Β Issue Tracker ʹνέοτΛ࡞Δ ▸ etc… DroidKaigi 2020 111 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ࢹମ੍: Metrics monitoring ▸ ΈͰղܾ: Crashlytics ▸ ΞϥʔτΛ Slack
ʹߘ͢Δ ▸ ৽نͷΫϥογϡΛݕͨ͠Β Issue Tracker ʹνέοτΛ࡞Δ ▸ etc… DroidKaigi 2020 112 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ࢹମ੍: Metrics monitoring ▸ ͷཧղΛॿ͚Δϩάͷऔಘ ▸ ͲΜͳঢ়گԼͰ͓͖͔ͨ ▸ Ͳ͏͍͏ܦ࿏Ͱ͓͖͔ͨ
▸ σόΠε͝ͱͷ͋Δ͔ ▸ ΞϓϦόʔδϣϯ͝ͱͷ͋Δ͔ ▸ etc… DroidKaigi 2020 113 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϩΪϯάͷઃܭ: Log collection architecture ▸ e.g. Timber + Crashlytics
▸ ϩάΛు͖ͩ͢ϝιουΛ Timber ʹू ▸ Timber.d("debug log") ▸ Timber.i("info log") ▸ Timber.e(exception, "error log") ▸ ϩάΛు͘ϝιουݺͼग़͠ΛϑοΫͯ͠ Crashlytics Ͱूܭ DroidKaigi 2020 114 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϩΪϯάͷઃܭ: Log collection architecture class CrashlyticsTree : Timber.Tree() {
override fun log(priority: Int, tag: String?, message: String, throwable: Throwable?) { when (priority) { Log.INFO "-> Crashlytics.log(priority, tag, message) Log.WARN "-> Crashlytics.log(priority, tag, message) Log.ERROR "-> { Crashlytics.log(priority, tag, message) throwable"?.let { Crashlytics.logException(it) } } } } } DroidKaigi 2020 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ϩΪϯάͷઃܭ: Log collection architecture class CrashlyticsTree : Timber.Tree() {
override fun log(priority: Int, tag: String?, message: String, throwable: Throwable?) { when (priority) { Log.INFO "-> Crashlytics.log(priority, tag, message) Log.WARN "-> Crashlytics.log(priority, tag, message) Log.ERROR "-> { Crashlytics.log(priority, tag, message) throwable"?.let { Crashlytics.logException(it) } } } } } DroidKaigi 2020 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ΧελϜΩʔͷՃ: Adding custom keys ▸ Crashlytics ͷϨϙʔτʹՃใΛ༩͢Δ͘͠Έ ▸ ΞϓϦͷ࣋ͭઃఆ
▸ e.g. XXX ͷػೳ͕༗ޮ͔Ͳ͏͔ ▸ Ϣʔβͷঢ়ଶ ▸ e.g. YYY ͷνϡʔτϦΞϧऴΘ͔ͬͨͲ͏͔ DroidKaigi 2020 117 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ΧελϜΩʔͷՃ: Adding custom keys class SettingsFragment : PreferenceFragmentCompat() {
override fun onCreatePreferences( savedState: Bundle?, rootKey: String? ) { setPreferencesFromResource(R.xml.pref, rootKey) val notificationPreference = findPreference<SwitchPreference>("enable_notification") notificationPreference"?.setOnPreferenceChangeListener { _, newValue "-> "// Put a custom key for preference value Crashlytics.setBool("enable_notification", newValue) true } } } DroidKaigi 2020 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ΧελϜΩʔͷՃ: Adding custom keys class SettingsFragment : PreferenceFragmentCompat() {
override fun onCreatePreferences( savedState: Bundle?, rootKey: String? ) { setPreferencesFromResource(R.xml.pref, rootKey) val notificationPreference = findPreference<SwitchPreference>("enable_notification") notificationPreference"?.setOnPreferenceChangeListener { _, newValue "-> "// Put a custom key for preference value Crashlytics.setBool("enable_notification", newValue) true } } } DroidKaigi 2020 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ·ͱΊ: Wrap up ▸ DX Λܧଓతʹվળ͍ͯ͘͜͠ͱͰ… ▸ ૉૣ͍ػೳ࣮͕͘͢͠ͳΔ ▸
ૉૣ͍ৼΓฦΓ͕͘͢͠ͳΔ ▸ ͦͷ݁ՌɺνʔϜϓϩμΫτ͙Μ͙Μ͍ͯ͘͠ ▸ ܧଓྗͳΓ DroidKaigi 2020 122 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ·ͱΊ: Wrap up ▸ ࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑ΔྖҬ ▸ ࣄલ४උ ▸ ઃܭ
▸ ։ൃϓϩηε ▸ ϦϦʔε DroidKaigi 2020 123 -
࣋ଓతͳΞϓϦ։ൃͷͨΊͷDXΛࢧ͑Δٕज़ ͍͞͝ʹ: Wrap up ▸ ͏Γ࢝Ί͍ͯΔϓϩδΣΫτͰ DX Λվળ͢Δʹ… ▸ ݱঢ়ੳΛͯ͠νʔϜͷઢΛ߹ΘͤΔ
▸ KPT ͰఆੑతʹνʔϜͷߟ͑Λ·ͱΊͯΈΔ ▸ ςετΧόϨοδܯࠂͷਪҠͳͲΛͬͯఆྔతʹ࣭ΛଌͬͯΈΔ ▸ ՝ײΛἧ͑ΔͱɺԿ͔ΒऔΓΉͱΑ͍͔͔Γ͘͢ͳΔ DroidKaigi 2020 124