Therapeutic Refactoring

Enter deadline center stage, exit best practices, quietly, rear stage left.

The results are rarely pretty.

Refactoring can pry panic’s fingers away from your poor, overburdened adrenal glands and restore your sanity. Not that it went missing, of course. Never that!

This talk will cover the two reasons why refactoring works as well as (or better than) whiskey, sky diving, and massages as therapy, explore a handful of effective strategies to ensure that the rubber meets the road, and contains gory before shots and slick after shots of ruby code that has served therapeutic purpose.

Transcript

1. Therapeutic Refactoring Katrina Owen @kytrinyx github.com/kytrinyx/therapeutic-refactoring
3. Illustration from Am Adult by Allie Brosh http://hyperboleandahalf.blogspot.com/2010/03/am-adult.html
4. Photo: Johanna Owen 2011
5. Illustration from U B Hatin’ by Allie Brosh http://hyperboleandahalf.blogspot.com/2010/03/u-b-hatin.html
6. I❤ refactoring
7. Illustration from There’s a Lesson in Here Somewhere, I Think by Allie Brosh http://hyperboleandahalf.blogspot.com/2010/01/theres-lesson-in-here-somewhere-i- think.html
8. Illustration from There’s a Lesson in Here Somewhere, I Think by Allie Brosh http://hyperboleandahalf.blogspot.com/2010/01/theres-lesson-in-here-somewhere-i- think.html
9. refactoring is not rehacktoring
10. Inspired by true events A Story
11. Illustration from The Scariest Story by Allie Brosh http://hyperboleandahalf.blogspot.com/2011/02/scariest-story.html
12. module XYZService def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
13. Illustration from The Scariest Story by Allie Brosh http://hyperboleandahalf.blogspot.com/2011/02/scariest-story.html
14. Illustration from The Scariest Story by Allie Brosh http://hyperboleandahalf.blogspot.com/2011/02/scariest-story.html
15. Illustration from The Scariest Story by Allie Brosh http://hyperboleandahalf.blogspot.com/2011/02/scariest-story.html
16. module XYZService def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
17. module XYZService def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
18. module XYZService def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
19. module XYZService def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
20. module XYZService def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
21. module XYZService def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
22. module XYZService def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
24. (the first middle) Tests
25. describe XYZService do end
26. describe XYZService do it "works" do end end
27. describe XYZService do subject { XYZService.xyz_filename(stub) } it "works" do end end
28. describe XYZService do subject { XYZService.xyz_filename(stub) } it "works" do end end
29. describe XYZService do subject { XYZService.xyz_filename(stub) } it "works" do end end
30. describe XYZService do subject { XYZService.xyz_filename(stub) } it "works" do subject.should eq("something") end end
31. subject.should eq "something"
32. subject.should eq "whatever"
33. subject.should eq "freddy"
34. subject.should eq "something"
35. Failures: 1) XYZService works Failure/Error: subject.should eq("something") Stub received unexpected message :publish_on with (no args) # ./xyz_service.rb:6:in `xyz_filename'
36. Failures: 1) XYZService works Failure/Error: subject.should eq("something") Stub received unexpected message :publish_on with (no args) # ./xyz_service.rb:6:in `xyz_filename'
37. Stub received unexpected message :publish_on with (no args)
38. Failures: 1) XYZService works Failure/Error: subject.should eq("something") Stub received unexpected message :publish_on with (no args) # ./xyz_service.rb:6:in `xyz_filename'
39. # ./xyz_service.rb:6
40. module XYZService def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
41. target.publish_on. strftime("%d")
42. target.publish_on. strftime("%d")
43. target.publish_on. strftime("%d")
44. describe XYZService do subject { XYZService.xyz_filename(stub) } it "works" do end end
45. describe XYZService do subject { XYZService.xyz_filename(target) } it "works" do end end
46. describe XYZService do let(:target) do stub(:target) end subject { XYZService.xyz_filename(target) } it "works" do subject.should eq("something") end end
47. describe XYZService do let(:target) do messages = { } stub(:target, messages) end subject { XYZService.xyz_filename(target) } it "works" do subject.should eq("something") end end
48. describe XYZService do let(:target) do messages = { :publish_on => ? } stub(:target, messages) end subject { XYZService.xyz_filename(target) } it "works" do subject.should eq("something") end end
49. describe XYZService do let(:target) do messages = { :publish_on => Date.new(2012, 3, 14) } stub(:target, messages) end subject { XYZService.xyz_filename(target) } it "works" do subject.should eq("something") end end
50. Stub received unexpected message :xyz_category_prefix with (no args)
51. ... :xyz_category_prefix => ?, ...
52. ... :xyz_category_prefix => 'abc', ...
53. Stub received unexpected message :kind with (no args)
54. ... :kind => ? ...
55. ... :kind => 'unicorn' ...
56. Stub received unexpected message :personal? with (no args)
57. ... :personal? => ? ...
58. ... :personal? => false ...
59. Stub received unexpected message :id with (no args)
60. ... :id => ? ...
61. ... :id => 1337 ...
62. Stub received unexpected message :title with (no args)
63. ... :title => ? ...
64. ... :title => 'magic & superglue' ...
65. Failures: 1) XYZService works Failure/Error: subject.should eq("something") expected: "something" got: "14abcunicorn_1337_3f4894ca_magicsuper.jpg" (compared using ==) # ./xyz_file_spec.rb:18:in `block (2 levels) in <top (required)>
66. Failures: 1) XYZService works Failure/Error: subject.should eq("something") expected: "something" got: "14abcunicorn_42_3f4894ca_magicsuper.jpg" (compared using ==) # ./xyz_file_spec.rb:18:in `block (2 levels) in <top (required)> #WIN
67. let(:target) do messages = { :publish_on => Date.new(2012, 3, 14), :xyz_category_prefix => 'abc', :kind => 'unicorn', :personal? => false, :id => 1337, :title => 'magic & superglue' } stub(:target, messages) end
68. Failures: 1) XYZService works Failure/Error: subject.should eq("something") expected: "something" got: "14abcunicorn_1337_3f4894ca_magicsuper.jpg" (compared using ==) # ./xyz_file_spec.rb:18:in `block (2 levels) in <top (required)>
69. Failures: 1) XYZService works Failure/Error: subject.should eq("something") expected: "something" got: "14abcunicorn_1337_3f4894ca_magicsuper.jpg" (compared using ==) # ./xyz_file_spec.rb:18:in `block (2 levels) in <top (required)>
70. 14abcunicorn_1337_3f4894ca_magicsuper.jpg
71. 14abcunicorn _1337_3f4894ca_ magicsuper.jpg
72. subject.should eq "14abcunicorn_1337_3f4894ca_magicsuper.jpg"
73. expected "14abcunicorn_1337_3f4894ca_magicsuper.jpg" got "14abcunicorn_1337_59a2b50d_magicsuper.jpg"
74. expected "14abcunicorn_1337_ 3f4894ca_magicsuper.jpg" got "14abcunicorn_1337_ 59a2b50d_magicsuper.jpg"
75. subject.should eq "14abcunicorn_1337_ 3f4894ca_magicsuper.jpg "
76. subject.should match /14abcunicorn_1337_ [0-9a-f]{8}_magicsuper.jpg /
77. . Finished in 0.00073 seconds 1 example, 0 failures
78. . Finished in 0.00073 seconds 1 example, 0 failures #WIN
79. def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end
80. def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end
81. Illustration from The Scariest Story by Allie Brosh http://hyperboleandahalf.blogspot.com/2011/02/scariest-story.html
82. def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end
83. target.publish_on. strftime("%d")
84. :publish_on => Date.new(2012, 3, 14)
85. :publish_on => Date.new(2012, 2, 7)
86. def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end
87. target.kind.gsub("_", "")
88. :kind => 'unicorn'
89. :kind => 'magic_unicorn'
90. def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end
91. target.title. gsub(/[^\[a-z\]]/i, ''). downcase
92. :title => 'magic & superglue'
93. :title => 'I <3 Sparkles!!1!'
94. Illustration from Bycicle by Allie Brosh http://hyperboleandahalf.blogspot.no/2010/07/bicycle.html
95. target.title. gsub(/[^\[a-z\]]/i, ''). downcase
96. target.title. gsub(/[^\[a-z\]]/i, ''). downcase
97. it "works" { ... } it "leaves square brackets???"
98. it "leaves square brackets???" do target.stub(:title => 'i[sparkle]s') end
99. expected "07abcmagicunicorn_1337_f3b6d325_ i[sparkle].jpg" to match /07abcmagicunicorn_1337_[0-9a-z]{8}_ isparkles.jpg/
100. it "works"{ ... } it "leaves square brackets"{ ... }
101. def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end
102. "_%03d" % (target.age || 0) if target.personal?
103. "_%03d" % (target.age || 0) if target.personal?
104. it "works" { ... } it "leaves square brackets"{ ... } it "personalizes"
105. it "personalizes" do target.stub(:personal? => true) end
106. Stub received unexpected message :age with (no args)
107. it "personalizes" do target.stub(:personal? => true) target.stub(:age? => 42) end
108. "_%03d" % (target.age || 0) if target.personal?
109. "_%03d" % (target.age || 0) if target.personal?
110. it "works"{ ... } it "leaves square brackets"{ ... } it "personalizes"{ ... } it "handles nil age"
111. it "handles nil age" do target.stub(:personal? => true) target.stub(:age? => nil) end
112. def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end
113. length > 9 ? 9 : length
114. :title => 'I <3 Sparkles!!1!'
115. :title => 'I <3 SPARKLY Sparkles!!1!'
116. it "works" { ... } it "leaves square brackets" { ... } it "personalizes" { ... } it "handles nil age" { ... } it "handles short titles"
117. it "handles short titles" do target.stub(:title => ‘O HAI’) end
118. ..... Finished in 0.00386 seconds 5 examples, 0 failures
119. ..... Finished in 0.00386 seconds 5 examples, 0 failures #WIN
120. Illustration from This is Why I’ll Never be an Adult by Allie Brosh http://hyperboleandahalf.blogspot.com/2010/06/this-is-why-ill-never-be-adult.html
121. Text
122. (the second middle) Refactoring
123. replace method with method object Refactoring
124. class XYZFile end
125. class XYZFile def initialize(target) end end
126. class XYZFile attr_reader :target def initialize(target) @target = target end end
127. class XYZFile attr_reader :target def initialize(target) @target = target end def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end
128. class XYZFile ... def self.xyz_filename(target) ... end end
129. class XYZFile ... def xyz_filename(target) ... end end
130. class XYZFile ... def name(target) ... end end
131. class XYZFile ... def name ... end end
132. module XYZService def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
133. module XYZService def self.xyz_filename(target) end end
134. require_relative './xyz_file' module XYZService def self.xyz_filename(target) end end
135. require_relative './xyz_file' module XYZService def self.xyz_filename(target) XYZFile.new end end
136. require_relative './xyz_file' module XYZService def self.xyz_filename(target) XYZFile.new end end (target) (target)
137. require_relative './xyz_file' module XYZService def self.xyz_filename(target) XYZFile.new end end (target) (target).name
138. ..... Finished in 0.00398 seconds 5 examples, 0 failures
139. ..... Finished in 0.00398 seconds 5 examples, 0 failures #WIN
140. class XYZFile ... def name # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
141. class XYZFile ... def name # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
142. class XYZFile ... def name filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
143. class XYZFile ... def name filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
144. class XYZFile ... def name ... truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" ... end end
145. class XYZFile ... def name ... truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" ... end end
146. class XYZFile ... def name ... truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" ... end def truncated_title end end
147. class XYZFile ... def name ... truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" ... end def truncated_title truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" end end
148. class XYZFile ... def name... def truncated_title truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" end end
149. class XYZFile ... def name... def truncated_title truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" end end
150. class XYZFile ... def name... def truncated_title truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" end end
151. class XYZFile ... def name... def truncated_title truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length truncated_title[0..(truncate_to)] end end
152. class XYZFile ... def name... def truncated_title truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length truncated_title[0..(truncate_to)] end end
153. class XYZFile ... def name ... truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" ... end def truncated_title... end
154. class XYZFile ... def name ... truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title}" ... end def truncated_title... end
155. class XYZFile ... def name ... truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title}" ... end def truncated_title... end
156. class XYZFile ... def name ... filename << "_#{truncated_title}" ... end def truncated_title... end
157. class XYZFile ... def name filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def truncated_title... end
158. class XYZFile ... def truncated_title truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length truncated_title[0..(truncate_to)] end end
159. class XYZFile ... def truncated_title truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length truncated_title[0..(truncate_to)] end end
160. target.title. gsub(/[^\[a-z\]]/i, ''). downcase
161. target.title. gsub(/[^\[a-z\]]/i, ''). downcase
162. target.title. gsub(/[^\[a-z\]]/i, ''). downcase
163. target.title.downcase gsub(/[^\[a-z\]]/, '')
164. truncated_title[0..(truncate_to)]
165. truncated_title[0..(truncate_to)]
166. truncated_title[0..truncate_to]
167. truncate_to = length > 9 ? 9 : length truncated_title[0..truncate_to]
168. truncate_to = length > 9 ? 9 : length truncated_title[0..9]
169. length = truncated_title.length truncate_to = length > 9 ? 9 : length truncated_title[0..9]
170. length = truncated_title.length truncate_to = length > 9 ? 9 : length truncated_title[0..9]
171. class XYZFile ... def truncated_title truncated_title = target.title.downcase.gsub(/[^\[a-z\]]/, '') truncated_title[0..truncate_to] end end
172. class XYZFile ... def truncated_title truncated_title = target.title.downcase.gsub(/[^\[a-z\]]/, '') truncated_title[0..truncate_to] end end
173. class XYZFile ... def truncated_title target.title.downcase. gsub(/[^\[a-z\]]/, '')[0..9] end end
174. class XYZFile ... def name filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def truncated_title... end
175. class XYZFile ... def name filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def truncated_title... end
176. class XYZFile ... def name ... filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" ... end def truncated_title... end
177. class XYZFile ... def name ... filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" ... end def noise end def truncated_title... end
178. class XYZFile ... def name ... filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" ... end def noise Digest::SHA1.hexdigest(rand(10000).to_s)[0,8] end def truncated_title... end
179. class XYZFile ... def name ... filename << "_#{noise}" ... end def noise Digest::SHA1.hexdigest(rand(10000).to_s)[0,8] end def truncated_title... end
180. class XYZFile ... def name filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def noise... def truncated_title... end
181. class XYZFile ... def name filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def noise... def truncated_title... end
182. class XYZFile ... def name filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_#{age}" if target.personal? filename << "_#{target.id.to_s}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def age "%03d" % (target.age || 0) end def noise... def truncated_title... end
183. class XYZFile ... def name filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_#{age}" if target.personal? filename << "_#{target.id.to_s}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def age... def noise... def truncated_title... end
184. class XYZFile ... def name filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_#{age}" if target.personal? filename << "_#{target.id.to_s}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def age... def noise... def truncated_title... end
185. class XYZFile ... def name filename = "#{publication_day}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_#{age}" if target.personal? filename << "_#{target.id.to_s}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def publication_day target.publish_on.strftime("%d") end def age... def noise... def truncated_title... end
186. class XYZFile ... def name filename = "#{publication_day}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_#{age}" if target.personal? filename << "_#{target.id.to_s}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def publication_day... def age... def noise... def truncated_title... end
187. class XYZFile ... def name filename = "#{publication_day}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_#{age}" if target.personal? filename << "_#{target.id.to_s}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def publication_day... def age... def noise... def truncated_title... end
188. class XYZFile ... def name filename = "#{publication_day}" filename << "#{category}" filename << "#{target.kind.gsub("_", "")}" filename << "_#{age}" if target.personal? filename << "_#{target.id.to_s}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def category target.xyz_category_prefix end def publication_day... def age... def noise... def truncated_title...
189. class XYZFile ... def name filename = "#{publication_day}" filename << "#{category}" filename << "#{target.kind.gsub("_", "")}" filename << "_#{age}" if target.personal? filename << "_#{target.id.to_s}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def publication_day... def category... def age... def noise... def truncated_title... end
190. class XYZFile ... def name filename = "#{publication_day}" filename << "#{category}" filename << "#{kind}" filename << "_#{age}" if target.personal? filename << "_#{target.id.to_s}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def kind target.kind.gsub("_", "") end def publication_day... def category... def age... def noise...
191. class XYZFile ... def name filename = "#{publication_day}" filename << "#{category}" filename << "#{kind}" filename << "_#{age}" if target.personal? filename << "_#{target.id.to_s}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def publication_day... def category... def kind... def age... def noise... def truncated_title... end
192. class XYZFile ... def name filename = "#{publication_day}" filename << "#{category}" filename << "#{kind}" filename << "_#{age}" if target.personal? filename << "_#{target.id.to_s}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" return filename end def publication_day... def category... def kind... def age... def noise... def truncated_title... end
193. filename = "#{publication_day}"
194. filename = "#{publication_day}"
195. filename = publication_day
196. filename << "#{category}"
197. filename << category
198. filename << "#{kind}"
199. filename << kind
200. filename << "_#{target.id.to_s}"
201. filename << "_#{target.id}"
202. class XYZFile ... def name filename = publication_day filename << category filename << kind filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" filename end ... end
203. class XYZFile ... def name filename = publication_day filename << category filename << kind filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" filename end ... end
204. class XYZFile ... def name filename = publication_day filename << category filename << kind filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" filename end ... end
205. class XYZFile ... def name filename = "" filename << publication_day filename << category filename << kind filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" filename end ... end
206. class XYZFile ... def name filename = "" filename << publication_day filename << category filename << kind filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" filename end ... end
207. class XYZFile ... def name filename = "" filename << publication_day filename << category filename << kind filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" filename end ... end
208. class XYZFile ... def name filename = "" filename << publication_day filename << category filename << kind filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" filename << ".jpg" filename end ... end
209. class XYZFile ... def name filename = "" filename << publication_day filename << category filename << kind filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" "#{filename}.jpg" end ... end
210. class XYZFile ... def name filename = "" filename << publication_day filename << category filename << kind filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" "#{filename}.jpg" end ... end
211. class XYZFile ... def name filename = "" filename << publication_day filename << category filename << kind filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" "#{filename}.jpg" end ... end
212. class XYZFile ... def name filename = "" filename << publication_day filename << category filename << kind filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" "#{filename}.jpg" end ... end
213. class XYZFile ... def name ... filename << publication_day filename << category filename << kind ... end ... end
214. class XYZFile ... def name ... filename << publication_day filename << category filename << kind ... end def prefix [publication_day, category, kind].join end ... end
215. class XYZFile ... def name ... filename << prefix ... end def prefix [publication_day, category, kind].join end ... end
216. class XYZFile ... def name filename = "" filename << prefix filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" "#{filename}.jpg" end ... end
217. class XYZFile ... def name filename = "" filename << prefix filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" "#{filename}.jpg" end ... end
218. class XYZFile ... def name filename = [] filename << prefix filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" "#{filename}.jpg" end ... end
219. class XYZFile ... def name filename = [] filename << prefix filename << "_#{age}" if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" "#{filename}.jpg" end ... end
220. class XYZFile ... def name filename = "" filename << prefix filename << age if target.personal? filename << "_#{target.id}" filename << "_#{noise}" filename << "_#{truncated_title}" "#{filename}.jpg" end ... end
221. class XYZFile ... def name filename = [] filename << prefix filename << age if target.personal? filename << target.id filename << "_#{noise}" filename << "_#{truncated_title}" "#{filename}.jpg" end ... end
222. class XYZFile ... def name filename = [] filename << prefix filename << age if target.personal? filename << target.id filename << noise filename << "_#{truncated_title}" "#{filename}.jpg" end ... end
223. class XYZFile ... def name filename = [] filename << prefix filename << age if target.personal? filename << target.id filename << noise filename << truncated_title "#{filename}.jpg" end ... end
224. class XYZFile ... def name filename = [] filename << prefix filename << age if target.personal? filename << target.id filename << noise filename << truncated_title "#{filename.join("_")}.jpg" end ... end
225. class XYZFile ... def name filename = [] filename << prefix filename << age if target.personal? filename << target.id filename << noise filename << truncated_title "#{filename.join("_")}.jpg" end def prefix... def publication_day... def category... def kind... def age... def noise... def truncated_title... ... end
226. Illustration from About by Allie Brosh http://hyperboleandahalf.blogspot.com/p/about.html
227. module XYZService def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
228. class XYZFile ... def name filename = [] filename << prefix filename << age if target.personal? filename << target.id filename << noise filename << truncated_title "#{filename.join("_")}.jpg" end def prefix... def publication_day... def category... def kind... def age... def noise... def truncated_title... ... end
229. class XYZFile ... def prefix [publication_day, category, kind].join end def publication_day target.publish_on.strftime("%d") end def category target.xyz_category_prefix end def kind target.kind.gsub("_", "") end def age "%03d" % (target.age || 0) end def noise Digest::SHA1.hexdigest(rand(10000).to_s)[0,8] end def truncated_title target.title.downcase.gsub(/[^\[a-z\]]/, '')[0..9] end end
230. module XYZService def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
231. class XYZFile ... def name filename = [] filename << prefix filename << age if target.personal? filename << target.id filename << noise filename << truncated_title "#{filename.join("_")}.jpg" end def prefix... def publication_day... def category... def kind... def age... def noise... def truncated_title... ... end
232. module XYZService def self.xyz_filename(target) # File format: # [day of month zero-padded][three-letter prefix] \ # _[kind]_[age_if_kind_personal]_[target.id] \ # _[8 random chars]_[10 first chars of title].jpg filename = "#{target.publish_on.strftime("%d")}" filename << "#{target.xyz_category_prefix}" filename << "#{target.kind.gsub("_", "")}" filename << "_%03d" % (target.age || 0) if target.personal? filename << "_#{target.id.to_s}" filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}" truncated_title = target.title.gsub(/[^\[a-z\]]/i, '').downcase length = truncated_title.length truncate_to = length > 9 ? 9 : length filename << "_#{truncated_title[0..(truncate_to)]}" filename << ".jpg" return filename end end
233. class XYZFile ... def name filename = [] filename << prefix filename << age if target.personal? filename << target.id filename << noise filename << truncated_title "#{filename.join("_")}.jpg" end def prefix... def publication_day... def category... def kind... def age... def noise... def truncated_title... ... end
234. Text
235. (the ending) Codejunk
236. Illustration from Chartjunk by Viveka Weiley http://chartjunk.karmanaut.com/?p=8
237. Illustration from Chartjunk by Viveka Weiley http://chartjunk.karmanaut.com/test-pattern-retuned/
238. (in no particular order) Top 10
239. Lousy Comments #10
240. module Codejunk # States the obvious def state_the_obvious "whatever" end end
241. module Codejunk # Takes modulus 100 def say_it_again(number) number % 100 end end
242. module Codejunk # Subtracts def incorrect_comment 1 + 1 end end
243. module Codejunk # add def fuzzy_comment 1 + 1 end end
244. module Codejunk # ad too numbers def bad_comment 1 + 2 end end
245. Trailing Whitespace #9
246. module Codejunk def a_method 'Use your words' end end ................ ... ................. ...... .. .. . ..
247. Commented-Out Code #8
248. module Codejunk def tweaked_logic(wday) # ((7 - wday) % 7) * 1.day (7 - wday) % 7 end end
249. module Codejunk def tweaked_logic(wday) if false ((7 - wday) % 7) * 1.day end (7 - wday) % 7 end end
250. Needless Parentheses #7
251. module Codejunk def spurious_parentheses() junk() end end
252. module Codejunk def more_spurious_parentheses (0..(one_method_call)).to_a end def one_method_call (10 - rand(10)) end end
253. Powerless Code #6
254. module Codejunk def spurious_arguments [1, 2, 3].join('') end end
255. module Codejunk def spurious_arguments [1, 2, 3].join end end
256. class ObjectWrapper attr_accessor :object def initialize(object) @object = object end end
257. module Codejunk def extract(response) if (200..299).include?(response.code.to_i) response.body if response end end end
258. module Codejunk def extract(response) if (200..299).include?(response.code.to_i) response.body if response end end end
259. module Codejunk def extract(response) if (200..299).include?(response.code.to_i) response.body if response end end end
260. Unnecessary Requires #5
261. require 'active_support/all' # Nothing uses active support module Codejunk ... end
262. The booleanest boolean #4
263. module Codejunk def truth(code) code == 13 ? true : false end end
264. module Codejunk def lie! !true end end
265. Too Much Hard Work #3
266. module Codejunk def spurious_string_interpolation "#{thing}" end def thing "a string" end end
267. module Codejunk def spurious_stringification "I am #{age.to_s} years old" end def age rand(25) + 15 end end
268. module Codejunk def spurious_transformations [1, 2, 3].map(&:to_s).join end end
269. module Codejunk def spurious_complexity s = rand(2) == 0 ? "abcde" : "abc" cutoff = s.length > 4 ? 4 : s.length s[0..cutoff] end end
270. module Codejunk def spurious_hard_work s = "I <3 Magic!" s.gsub(/[^a-z]/i, '').downcase end end
271. Duplicated Tests #2
272. module Codejunk def add(n1, n2) n1 + n2 end end describe Codejunk do subject { stub.extend(Codejunk) } it "adds" do subject.add(1, 1).should eq(2) end it "adds twin primes" do subject.add(29, 31).should eq(60) end it "adds big numbers" do subject.add(9238498, 2039238).should eq(11277736) end it "adds negative numbers" do subject.add(100, -390).should eq(-290) end end
273. describe Codejunk do subject { stub.extend(Codejunk) } it "gets rid of spaces" do subject.sanitize(" o m g ").should eq('omg') end it "gets rid of funky characters" do subject.sanitize("omg^%#=}{?_").should eq('omg') end it "gets rid of numbers" do subject.sanitize("omg123").should eq('omg') end it "downcases everything" do subject.sanitize("OMG").should eq('omg') end end
274. Combine All The Codejunk #1
275. module Codejunk def junk # Subtracts s = rand(2) == 0 ? "abcde" : "abc" cutoff = s.length > 4 ? 4 : s.length s = s[0..cutoff] s << "#{spurious_string_interpolation()}" s << "I am #{age.to_s} years old, and " s << "I <3 Magic!".gsub(/[^a-z]/i, '').downcase s << "#{(0..(one_method_call)).map(&:to_s).join('')}" return s end end
276. Text
277. github.com/kytrinyx /therapeutic-refactoring
278. Refactoring by Martin Fowler et al. http://www.goodreads.com/book/show/44936.Refactoring Refactoring, Ruby Edition by Jay Fields et al. http://www.goodreads.com/book/show/11560939-refactoring
279. Refactoring in Ruby by William Wake & Kevin Rutherford http://www.goodreads.com/book/show/7214925-refactoring-in-ruby
280. Working Effectively With Legacy Code by Michael Feathers http://www.goodreads.com/book/show/44919.Working_Effectively_with_Legacy_Code
281. Practical Object-Oriented Design in Ruby by Sandi Metz http://www.goodreads.com/book/show/13507787-practical-object-oriented-design-in-ruby
282. (the moral) Therapy
284. I❤ refactoring
285. Working Memory Science! * Beilock & DeCaro, Department of Psychology, University of Chicago http://www.ncbi.nlm.nih.gov/pubmed/17983308
286. Problem-Solving Strategies Science!
287. Worry & Panic Science!
288. makes you smarter! Refactoring
289. Exobrain
290. counteracts panic Exobrain
291. makes you happier! Refactoring
292. Fast Tests
293. are awesome Fast Tests
294. Happiness
295. leads to good design Happiness
296. Illustration from God of Cake by Allie Brosh http://hyperboleandahalf.blogspot.no/2010/10/god-of-cake.html
297. exobrain Illustration from God of Cake by Allie Brosh http://hyperboleandahalf.blogspot.no/2010/10/god-of-cake.html
298. Illustration from God of Cake by Allie Brosh http://hyperboleandahalf.blogspot.no/2010/10/god-of-cake.html prevents panic
299. Illustration from God of Cake by Allie Brosh http://hyperboleandahalf.blogspot.no/2010/10/god-of-cake.html happiness
300. Illustration from God of Cake by Allie Brosh http://hyperboleandahalf.blogspot.no/2010/10/god-of-cake.html decoupled code
301. Katrina Owen @kytrinyx kytrinyx@gmail.com github.com/kytrinyx/therapeutic-refactoring https://joind.in/7904 KTHXBYE