Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
How to get your pull requests merged
Search
Yasuo Honda
May 30, 2019
Technology
9
810
How to get your pull requests merged
Yasuo Honda
May 30, 2019
Tweet
Share
More Decks by Yasuo Honda
See All by Yasuo Honda
Contributing to Rails? Start with the Gems You Already Use
yahonda
2
160
PostgreSQL 18 cancel request key長の変更とRailsへの関連
yahonda
0
180
extensionとschema
yahonda
1
260
NOT VALIDな検査制約 / check constraint that is not valid
yahonda
1
200
今、始める、第一歩。 / Your first step
yahonda
3
1.3k
RailsのPull requestsのレビューの時に私が考えていること
yahonda
11
7k
pg_stat_statementsで inの数が違うSQLをまとめて ほしい
yahonda
0
250
遅延可能な一意性制約
yahonda
0
1k
あなたとRails
yahonda
4
1k
Other Decks in Technology
See All in Technology
僕たちが「開発しやすさ」を求め 模索し続けたアーキテクチャ #アーキテクチャ勉強会_findy
bengo4com
0
2.6k
Oracle Base Database Service:サービス概要のご紹介
oracle4engineer
PRO
1
20k
Telemetry APIから学ぶGoogle Cloud ObservabilityとOpenTelemetryの現在 / getting-started-telemetry-api-with-google-cloud
k6s4i53rx
0
160
オブザーバビリティ文化を組織に浸透させるには / install observability culture
mackerelio
0
320
なごミュ@SPAJAM2025 第二回予選
1901drama
0
110
2025新卒研修・Webアプリケーションセキュリティ #弁護士ドットコム
bengo4com
3
9.4k
【新卒研修資料】数理最適化 / Mathematical Optimization
brainpadpr
29
14k
React Server ComponentsでAPI不要の開発体験
polidog
PRO
0
340
Google Agentspaceを実際に導入した効果と今後の展望
mixi_engineers
PRO
3
800
AIに頼りすぎない新人育成術
cuebic9bic
3
330
AI時代の大規模データ活用とセキュリティ戦略
ken5scal
1
260
信頼できる開発プラットフォームをどう作るか?-Governance as Codeと継続的監視/フィードバックが導くPlatform Engineeringの進め方
yuriemori
1
190
Featured
See All Featured
Building Flexible Design Systems
yeseniaperezcruz
328
39k
[RailsConf 2023 Opening Keynote] The Magic of Rails
eileencodes
30
9.6k
How to Ace a Technical Interview
jacobian
279
23k
Imperfection Machines: The Place of Print at Facebook
scottboms
268
13k
Mobile First: as difficult as doing things right
swwweet
223
9.9k
How To Stay Up To Date on Web Technology
chriscoyier
790
250k
Designing for humans not robots
tammielis
253
25k
Thoughts on Productivity
jonyablonski
69
4.8k
Designing Dashboards & Data Visualisations in Web Apps
destraynor
231
53k
Let's Do A Bunch of Simple Stuff to Make Websites Faster
chriscoyier
507
140k
Large-scale JavaScript Application Architecture
addyosmani
512
110k
Making Projects Easy
brettharned
117
6.3k
Transcript
How to get your pull requests merged ۜ࠲Rails#9 2019/05/30 @yahonda
ࣗݾհͱ2ͭͷࢹ • Rails contributor • Maintainer of Active Record Oracle
enhanced adapter • Pull requestΛૹΔཱͱड͚औΔཱ
͢͜ͱɺ͞ͳ͍͜ͱ • ͢͜ͱ • RailsϑϨʔϜϫʔΫͷ։ൃମ੍ • Railsʹpull requestΛૹΔͱ͖ʹ͢Δ͜ͱɺ͠ͳ͍͜ͱ • ͞ͳ͍͜ͱ
• ίʔυ • https://railsguides.jp/contributing_to_ruby_on_rails.html
͋ͳͨͳͥRailsʹpull requestΛ͓͘Δͷ͔
͋ͳͨͷ՝Λղܾ͢ΔͨΊ
ͦͷͨΊʹඞཁͳ͜ͱ
ͦͷpull request͕Railsʹऔ Γࠐ·ΕΔ͖ཧ༝Λίϛο λʔʹೲಘͯ͠Β͏͜ͱ
RailsϑϨʔϜϫʔΫ։ൃମ੍ • ϦϦʔεεέδϡʔϧ • ίϛϡχςΟ • Pull requestΛϚʔδͰ͖Δͷ୭͔ • ݴޠ
• ࣌ࠩ
͋ͳͨͷRailsΞϓϦέʔγϣ ϯ։ൃମ੍ͱಉ͡ͱ͜Ζ͋ Δ͠ɺҧ͏ͱ͜Ζ͋Δ
ϦϦʔεεέδϡʔϧ • RailsͷϦϦʔεαΠΫϧ • Major, Minor: ୯ҐɺTeeny: ݄୯Ґ • Ծʹࠓɺpull
requestϚʔδ͞Εͯೖͬͨ৽ػೳ͕Ϧ Ϧʔε͞ΕΔͷRails 6.1(͓ͦΒ͘2020Ҏ߱) • ͋ͳͨͷRailsΞϓϦέʔγϣϯͷϦϦʔεαΠΫϧ ɺ͓ͦΒͦ͘ΕΑΓ͍ͣ
ίϛϡχςΟ • DHH / Rails core / Rails committer •
Rails contributors • ಉ͡ձࣾ/৫ͰຖҰॹʹ͍ΔΘ͚Ͱͳ͍ • ίϛϡχςΟϝϯόʔ͕RailsʹٻΊΔͷͦΕͧΕҟ ͳΔ • ͋ͳ͕ͨRailsʹٻΊΔͷΛΘ͔ͬͯΒ͏ඞཁ͕͋Δ
Pull requestΛϚʔδ͢Δͷ • ࠷େ18ਓͷRailsίϛολʔ • ΞΫςΟϒͳίϛολʔͬͱগͳ͍ • 700Ҏ্ͷopen pull requests
• 39 pull requests / ίϛολʔ • ͋ͳͨͷRailsΞϓϦέʔγϣϯͷϨϏϡʔମ੍ͱൺͯΈ ·͠ΐ͏
ݴޠ • Ruby • ίʔυ • ӳޠ • ίϛοτϝοηʔδ •
Pull requestͰͷΓͱΓ
࣌ࠩ • Rails ίϛολʔੈքதʹ͍Δ • ͋ͳͨͷ৸͍ͯΔؒʹpull request͕ϨϏϡʔ ͞ΕΔ͔͠Εͳ͍
Railsʹpull requestΛૹΔ ࣌ɺͦͯ͠ૹͬͨޙʹͳʹΛ ͢Δ͔ɺ͠ͳ͍͔
Pull requestΦʔϓϯ͢Δ࣌ʹ • Pull requestΛϚʔδ͢Δཧ༝Λઆ໌͍ͯ͠Δ͔ • ͋ͳͨͷ՝͔ͩΒཧ༝આ໌Ͱ͖Δͣ • Ͱ͖Δ͜ͱΛΔɺͰ͖Δ͜ͱΔ •
ʮ͍ͭͷ͔ૹΔʯͬͯ͜ͳ͍͔͠Εͳ͍ • ʮ͜͏ͩͬͨΒ͍͍ͷʹʯͱ͍͏ίϝϯτΛॻ͘ͳ Βɺগ͠Ͱͦͷʮ͜͏ʯΛίʔυʹ͢Δ
Pull requestΛΦʔϓϯͨ͠ޙ • ͋ͤΒͳ͍ͰԠΛͭ • Ϛʔδͯ͠Β͏ͨΊʹඞཁͳใΛॻ͖ ͍ͬͯΕɺޙ͢Δ͜ͱͳ͍ͣ
ϨϏϡʔ࣭͕དྷͨΒ • Pull requestͰίʔυ͔ӳޠͰճ͢Δ • ڵຯΛ࣋ͨΕ͍ͯΔؒʹճ͢Δ • ϨϏϡʔ࣭Λແࢹ͠ͳ͍
ෳਓ͔Βίϝϯτ͕དྷͨΒ • ίϛολʔʹೲಘͯ͠Β͏͜ͱʹྗ͢Δ • Ϛʔδ͢Δݖݶͷͳ͍ਓΛઆಘͯ͠ํ͕ ͳ͍ɺͱ͍͏ݱ࣮͋Δ • ͘ͳΕͳΔ΄Ͳऩर͕͚ͭʹ͍͘
ϨϏϡʔ͕Θ͔Βͳ͔ͬͨΒ • Θ͔͍ͬͯΔ෦ΛαϚϦʔͯ͠ฦࣄ͢Δ • Βͳ͔ͬͨ͜ͱʹରͯ͠Sorryͱ͍Θͳ͍ • Βͳ͔ͬͨ͜ͱΛڭ͑ͯ͘Εͨ͜ͱʹײँ Λ͠ɺͦΕΛ;·͑ͨίʔυมߋΛ͢Δ
ϨϏϡʔʹࢍͰ͖ͳ͔ͬͨΒ • ࢍͰ͖ͳ͍ཧ༝Λॻ͘ • ʮϨϏϡʔ͋Γ͕ͱ͏ɺͰࢲ͜Ε͕ ΈʯͰΑ͍ • ୯७ʹແࢹ͠ͳ͍
୭͔ΒԿͷԠͳ͔ͬͨΒ • ΈΜͳ͕͏Ձ͕͋Δͷͩͱpull request ୯ಠͰઆ໌͍ͯ͠Δ͔ɺ͏͍ͪͲಡΜͰΈ ·͠ΐ͏ • ͋ͳͨͷϢʔεέʔεઆ໌͞Ε͍ͯ·͔͢ • ڵຯΛҾ͘pull
requestͰ͋ΕɺԿ͔͠Βͷ Ԡ͕͋Δͣ
Pull requestͷϝϯςφϯε • ίϯϑϦΫτΛղফ͓ͯ͘͠ • CIgreenʹ͓ͯ͘͠
Pull request͕ෆཁʹͳͬͨΒ • Ϋϩʔζ͢Δ • ʮࢲ͏ཁΒͳ͍͚Ͳɺଞͷ୭͔͕ඞཁ͔ ͠Εͳ͍ʯͱ͍͏ͷߟ͑ͳͯ͘Α͍
Pull requestΛΦʔϓϯͨ͠ޙ ʹΒͳ͍͜ͱ • ping͠ͳ͍ / any updates? ͱ͔͍Θͳ͍ •
ʮϚʔδ͖͢ཧ༝ʯΛҰͭઆ໌͍ͯ͠ͳ ͍͔Β
Ϛʔδ͞ΕͣΫϩʔζ͞ΕͨΒ • Ϋϩʔζ͞Εͨissuepull requestʹίϝϯτ ͠ͳ͍ • ʮࣺͯࢺʯ͔͔ͳ͍
Ϋϩʔζ͞Εͨpull requestΛ ࠶νϟϨϯδͨ͘͠ͳͬͨΒ • ͍ͬͨΜΫϩʔζ͞Εͨpull requestͱಉ͡ࡐ Λ෮׆ͤ͞ΔͷࠔͰ͋Δ • ͕࣌ؒܦͭͷΛͭ •
ൣғΛখ͘͢͞ΔɺΞϓϩʔνΛม͑Δ • அ͕มΘΔ͔͠Εͳ͍ɺલఏ͕มΘΔ͔ ͠Εͳ͍ɺϝϯςφʔ͕ସΘΔ͔͠Εͳ͍
Pull request͕Ϛʔδ͞ΕͨΒ • https://contributors.rubyonrails.org • https://y-yagi.hatenablog.com • ࣍ͷRails͕ϦϦʔε͞ΕΔͷΛͪ·͠ΐ͏ • ͋ͳͨͷcommitͷੵΈॏͶͰɺ͋ͳͨRails
ίϛϡχςΟʹΒΕ͍ͯ͘Α͏ʹͳΓ·͢
OSSύονձͲ͏ͧ ࣍ճ6݄6