Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
コードの作者がいるうちに聞こう
Search
KAWASHIMA Yoshiyuki
June 03, 2024
Programming
2
440
コードの作者がいるうちに聞こう
KAWASHIMA Yoshiyuki
June 03, 2024
Tweet
Share
More Decks by KAWASHIMA Yoshiyuki
See All by KAWASHIMA Yoshiyuki
SwiftUI Drag & Drop で困った話
ykws
0
9
GitHub PR Milestone Check を使ってみた
ykws
0
10
Kotlin 2.0.20 から標準ライブラリで UUID が使えるようになりました
ykws
1
190
アラートを効果的に扱おう
ykws
1
310
visionOS に備える
ykws
0
190
モバイルアプリの操作方法を疑ってみる
ykws
0
1.5k
Other Decks in Programming
See All in Programming
Realtime API 入門
riofujimon
0
150
ヤプリ新卒SREの オンボーディング
masaki12
0
130
Kaigi on Rails 2024 〜運営の裏側〜
krpk1900
1
240
Enabling DevOps and Team Topologies Through Architecture: Architecting for Fast Flow
cer
PRO
0
340
Amazon Qを使ってIaCを触ろう!
maruto
0
410
CSC509 Lecture 13
javiergs
PRO
0
110
AWS Lambdaから始まった Serverlessの「熱」とキャリアパス / It started with AWS Lambda Serverless “fever” and career path
seike460
PRO
1
260
Remix on Hono on Cloudflare Workers
yusukebe
1
300
.NET のための通信フレームワーク MagicOnion 入門 / Introduction to MagicOnion
mayuki
1
1.7k
TypeScript Graph でコードレビューの心理的障壁を乗り越える
ysk8hori
2
1.1k
Streams APIとTCPフロー制御 / Web Streams API and TCP flow control
tasshi
2
350
카카오페이는 어떻게 수천만 결제를 처리할까? 우아한 결제 분산락 노하우
kakao
PRO
0
110
Featured
See All Featured
Let's Do A Bunch of Simple Stuff to Make Websites Faster
chriscoyier
506
140k
Intergalactic Javascript Robots from Outer Space
tanoku
269
27k
Building Your Own Lightsaber
phodgson
103
6.1k
The Illustrated Children's Guide to Kubernetes
chrisshort
48
48k
Building a Scalable Design System with Sketch
lauravandoore
459
33k
How To Stay Up To Date on Web Technology
chriscoyier
788
250k
Optimising Largest Contentful Paint
csswizardry
33
2.9k
Art, The Web, and Tiny UX
lynnandtonic
297
20k
Scaling GitHub
holman
458
140k
StorybookのUI Testing Handbookを読んだ
zakiyama
27
5.3k
Principles of Awesome APIs and How to Build Them.
keavy
126
17k
Making Projects Easy
brettharned
115
5.9k
Transcript
YUMEMI.grow ϓϧϦΫΤετͱίʔυϨϏϡʔͰ։ൃΛՃͤ͞ΔLTձ 2024.6.3 ίʔυͷ࡞ऀ͕͍Δ͏ͪʹฉ͜͏ KAWASHIMA Yoshiyuki
͍͑ͨ͜ͱ • ίʔυͷ࡞ऀ͕͍ͳ͘ͳͬͯӬ͘อक͢ΔͨΊͷίʔυϨϏϡʔ • ίʔυϨϏϡʔΛ࠷༏ઌʹ͢ΔͷӬ͘อक͢Δ্Ͱ࠷খͷίετ
ใݯ GoogleͷιϑτΣΞΤϯδχΞϦϯά ࣋ଓՄೳͳϓϩάϥϛϯάΛࢧ͑Δٕज़ɺจ Խɺϓϩηε 202111݄ൃߦ https://www.oreilly.co.jp/books/9784873119656/
ใݯ GoogleͷιϑτΣΞΤϯδχΞϦϯά͔ΒֶͿίʔυϨϏϡʔ https://zenn.dev/yumemi_inc/articles/google-code-review
None
લఏ ίʔυϨϏϡʔ 11͘Β͍લ͔Β GitHub ্Ͱ OSS PR Ͱ νʔϜ։ൃͷϓϩηεͱͯ͠ಋೖͨ͠ͷ 6͘Β͍લ͔Β
ͦΕ·ͰҰਓ։ൃ͕ओྲྀ 3͘Β͍લ͔ΒνʔϜ։ൃͰͷίʔυϨϏϡʔϓϩηεʹՃ͑ͯɺ࠾ ༻ҭͷίʔυϨϏϡʔ
None
ίʔυͷ࡞ऀ͕͍ͳ͘ͳΔʁ
Ҿ͖ܧ͗ ࠷ॳ͔Β͍ͳ͍…
Ͳ͏͍͏ҙਤͰͦͷίʔυ͕ॻ͔Εͨͷ͔୭Θ ͔Βͳ͍
Өڹൣғ͕Θ͔Βͳ͍ͷͰͦͷ··ʹ͓ͯ͜͠͏
ӨڹൣғΛௐࠪͯ͠ίʔυΛཧղͯ͠मਖ਼͢Δͱͳ Δͱͪΐͬͱͷमਖ਼ͷ͕ͣɺଟ͘ͷ࣌ؒΛཁ͢Δ
PR Λ࡞ͯ͠1िؒޙʹϨϏϡʔ
ίʔυΛॻ͍ͨຊਓͰࢥ͍ग़͢ ͷʹ͕͔͔࣌ؒΔ
ίʔυͷ࡞ऀ͕PRΛ࡞ͨ͠ࠓฉ ͍ͯ͠·͏ͷ͕Ұ൪ίετ͕খ͍͞
ίʔυͷ࡞ऀ͕ࠓͷલʹ͍ͯίʔυ ʹ͍ͭͯฉ͚Δͷͱͯوॏͳ࣌ؒ
Ͳ͏ͬͯϨϏϡʔ͢Δ
GoogleͷιϑτΣΞΤϯδχΞϦϯά͔ΒӨڹΛ ड͚ͨݴ༿ͷհ
ใݯ GoogleͷιϑτΣΞΤϯδχΞϦϯά https://www.oreilly.co.jp/books/9784873119656/ ୈ9ষίʔυϨϏϡʔ͔Β͜͜Ͱհ͢Δͷ͝ ͘Ұ෦ͳͷͰؾʹͳͬͨਓͥͻॻ੶Λखʹ औͬͯΈ͍ͯͩ͘͞
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.204 ௨ৗίʔυϨϏϡʔ͕ɺ࡞ऀҎ֎ͷऀ͕ ίʔυมߋΛݕূ͢ΔॳΊͯͷػձͰ͋Δ
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.204 ͜͏ͨ͠؍ʹΑͬͯϨϏϡϫʔʹɺ࠷༏ ΕͨΤϯδχΞͰ͢ΒͰ͖ͳ͍͜ͱ͕Ͱ͖Δ Α͏ʹͳΔ
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.204 ͦΕɺίʔυ࡞ऀͷ؍͔Βੜ͡ΔόΠΞε ʹӨڹ͞Εͳ͍ϑΟʔυόοΫΛఏڙ͢Δ͜ͱ ͩ
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.204 ίʔυϨϏϡʔɺ͋Δมߋ͕ΑΓ͍ରʹ ͱͬͯཧղՄೳ͔Ͳ͏͔ࢼ͢࠷ॳͷࢼ࿅Ͱ͋ Δ͜ͱ͕ଟ͍
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.204 ίʔυॻ͔ΕΔΑΓಡ·ΕΔճ͕ଟ͘ͳΔ ͨΊɺ͜ͷ؍ੜࢮΛ͚Δ΄ͲʹॏཁͰ͋ ΓɺཧղͱҙຯͷѲ͕ܾఆతʹॏཁͰ͋Δ
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.203 ίʔυϨϏϡʔɺίʔυͷਖ਼͠͞ʹ͍ͭͯͷສೳͷղܾ ࡦͰ།ҰͷνΣοΫํ๏Ͱͳ͘ɺιϑτΣΞΛΊ ͙ΔͦͷΑ͏ͳʹର߅͢ΔଟޚͷҰཁૉͰ͋Δ
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.203 ݁Ռͱͯ͠ɺίʔυϨϏϡʔ͕ՌΛ্͛ ΔͨΊʹʮᘳʯͰ͋Δඞཁͳ͍
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.203 ࣮ҙ֎ͳ͜ͱʹɺίʔυͷਖ਼͠͞ͷνΣοΫɺίʔ υϨϏϡʔͷϓϩηε͔ΒGoolge͕ಘΔԸܙͷटҐͰ ͳ͍
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.203-204 ͕࣌ؒܦͪίʔυϕʔεࣗମ͕εέʔϧͨ͠ ߹ίʔυͷมߋ͕ཧղՄೳͰҙຯΛ͢ͱ อূ͢Δ͜ͱͷํ͕ɺҙ͕ٛେ͖͍
۩ମతʹͲ͏͢Εʁ
࣭͢Δ
ಛʹ৽͘͠νʔϜʹࢀըͨ͠ϝϯόʔόΠ Ξε͕ͳ͍ͷͰίʔυϨϏϡʔͷޮՌ͕ߴ͍
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.209 ͦͷΞϓϩʔν͕ؒҧ͍ͬͯΔͱܾΊ͔͔ͯΔ લʹɺԿނͦͷΑ͏ͳΞϓϩʔν͕࠾ΒΕͨ ͔ʹ͍࣭ͭͯͨ͠ํ͕Α͍
Ͳ͏࣭͢Δ
ίʔυͷ࡞ऀ͕͍ͳ͘ͳͬͯࣗ ͕อकͰ͖Δ͔
ࠓ͍ΔϝϯόʔʢࣗΛؚΊͯʣ ͍ͳ͘ͳͬͯอकͰ͖Δ͔
ͦ͏͍ͬͯࢦఠ͕ଟ͘ͳΔ
લఏͱͯ͠ɺGoogleʹϦʔμ ϏϦςΟϨϏϡʔ͕͋Δ
ಡΈ͢͞ͷͨΊͷపఈͨ͠৽ਓ ݚमͷΠϝʔδ
ใݯ GoogleͷιϑτΣΞΤϯδχΞϦϯά https://www.oreilly.co.jp/books/9784873119656/ ϦʔμϏϦςΟʹ͍ͭͯୈ3ষࣝڞ༗Ͱৄ͠ ͘ॻ͔Ε͍ͯ·͢
ࢲͨͪGoogleͰͳ͍
ϖΞϓϩάϥϛϯά
ΨΠυϥΠϯ࡞
·ͱΊ ίʔυͷ࡞ऀ͍ͳ͘ͳΓ·͢ ཧతʹ࣌ؒతʹ ίʔυΛ࡞ͨ͠ޙʹ͔ͦ͠ͷίʔυͷ࡞ऀ͍·ͤΜ ͦͷίʔυΛӬ͘อक͍ͯͨ͘͠Ίʹɺͦͷ࡞ऀ͕͍Δ͏ͪʹͲ͏ ͍͏ҙਤͰͦͷมߋΛͨ͠ͷ͔֬ೝͯ͠ཧղ͓ͯ͘͜͠ͱ͕େࣄ Θ͔Γʹ͍͘ίʔυͰ͋Εɺमਖ਼ίϝϯτɺυΩϡϝϯτͳͲͷ ՃචΛ͓ئ͍͢Δ
·ͱΊ ཧղͱҙຯͷѲ͕ॏཁͰ͋Δ ਖ਼͠͞ʹ͍ͭͯʮᘳʯͰ͋Δ͜ͱΛٻΊͳ͍ ಈ͍͍ͯΔ͔ΒOKΑΓҙຯ͕Θ͔͔ͬͨΒOKͱ͢Δ ࢦఠΑΓ࣭Λ৺͕͚Δ ࢦఠ͕૿͑ͯ͠·͏ͷɺνʔϜͷঢ়ଶͷԜತΛ͍ࣔͯ͠Δ ϖΞϓϩάϥϛϯάΨΠυϥΠϯΛ࡞ͯࣝ͠ͷڞ༗Λߦ͏