Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
コードの作者がいるうちに聞こう
Search
KAWASHIMA Yoshiyuki
June 03, 2024
Programming
2
420
コードの作者がいるうちに聞こう
KAWASHIMA Yoshiyuki
June 03, 2024
Tweet
Share
More Decks by KAWASHIMA Yoshiyuki
See All by KAWASHIMA Yoshiyuki
Kotlin 2.0.20 から標準ライブラリで UUID が使えるようになりました
ykws
1
160
アラートを効果的に扱おう
ykws
1
290
visionOS に備える
ykws
0
180
モバイルアプリの操作方法を疑ってみる
ykws
0
1.4k
Other Decks in Programming
See All in Programming
ACES Meet におけるリリース作業改善の取り組み
fukucheee
0
150
4年間変わらなかった YOUTRUSTのアーキテクチャ
daiki1003
2
670
Програмиране с Rust, ФМИ, 2024
nikolads
0
120
Golang と Erlang
taiyow
7
1.7k
Folding Cheat Sheet #8
philipschwarz
PRO
0
120
実践サーバーレスパフォーマンスチューニング ~その実力に迫る~ / Practical Serverless Performance Tuning ~A Close Look at its Power~
seike460
PRO
2
230
sqlcを利用してsqlに型付けを
kamiyam
0
250
Successful with Signals: 3 Rules for Your Architecture
manfredsteyer
PRO
0
130
色んなオートローダーを覗き見る #phpcon_okinawa
o0h
PRO
5
430
NEWTにおけるiOS18対応の進め方
ryu1sazae
0
330
CSC305 Lecture 09
javiergs
PRO
0
110
(Deep|Web) Link support with expo-router
mrtry
0
190
Featured
See All Featured
Git: the NoSQL Database
bkeepers
PRO
425
64k
Music & Morning Musume
bryan
46
6.1k
Performance Is Good for Brains [We Love Speed 2024]
tammyeverts
3
330
GraphQLの誤解/rethinking-graphql
sonatard
65
9.9k
JavaScript: Past, Present, and Future - NDC Porto 2020
reverentgeek
46
4.9k
How to Think Like a Performance Engineer
csswizardry
18
1k
Let's Do A Bunch of Simple Stuff to Make Websites Faster
chriscoyier
504
140k
Faster Mobile Websites
deanohume
304
30k
I Don’t Have Time: Getting Over the Fear to Launch Your Podcast
jcasabona
27
1.9k
ReactJS: Keep Simple. Everything can be a component!
pedronauck
664
120k
Writing Fast Ruby
sferik
626
60k
Docker and Python
trallard
40
3k
Transcript
YUMEMI.grow ϓϧϦΫΤετͱίʔυϨϏϡʔͰ։ൃΛՃͤ͞ΔLTձ 2024.6.3 ίʔυͷ࡞ऀ͕͍Δ͏ͪʹฉ͜͏ KAWASHIMA Yoshiyuki
͍͑ͨ͜ͱ • ίʔυͷ࡞ऀ͕͍ͳ͘ͳͬͯӬ͘อक͢ΔͨΊͷίʔυϨϏϡʔ • ίʔυϨϏϡʔΛ࠷༏ઌʹ͢ΔͷӬ͘อक͢Δ্Ͱ࠷খͷίετ
ใݯ GoogleͷιϑτΣΞΤϯδχΞϦϯά ࣋ଓՄೳͳϓϩάϥϛϯάΛࢧ͑Δٕज़ɺจ Խɺϓϩηε 202111݄ൃߦ https://www.oreilly.co.jp/books/9784873119656/
ใݯ GoogleͷιϑτΣΞΤϯδχΞϦϯά͔ΒֶͿίʔυϨϏϡʔ https://zenn.dev/yumemi_inc/articles/google-code-review
None
લఏ ίʔυϨϏϡʔ 11͘Β͍લ͔Β GitHub ্Ͱ OSS PR Ͱ νʔϜ։ൃͷϓϩηεͱͯ͠ಋೖͨ͠ͷ 6͘Β͍લ͔Β
ͦΕ·ͰҰਓ։ൃ͕ओྲྀ 3͘Β͍લ͔ΒνʔϜ։ൃͰͷίʔυϨϏϡʔϓϩηεʹՃ͑ͯɺ࠾ ༻ҭͷίʔυϨϏϡʔ
None
ίʔυͷ࡞ऀ͕͍ͳ͘ͳΔʁ
Ҿ͖ܧ͗ ࠷ॳ͔Β͍ͳ͍…
Ͳ͏͍͏ҙਤͰͦͷίʔυ͕ॻ͔Εͨͷ͔୭Θ ͔Βͳ͍
Өڹൣғ͕Θ͔Βͳ͍ͷͰͦͷ··ʹ͓ͯ͜͠͏
ӨڹൣғΛௐࠪͯ͠ίʔυΛཧղͯ͠मਖ਼͢Δͱͳ Δͱͪΐͬͱͷमਖ਼ͷ͕ͣɺଟ͘ͷ࣌ؒΛཁ͢Δ
PR Λ࡞ͯ͠1िؒޙʹϨϏϡʔ
ίʔυΛॻ͍ͨຊਓͰࢥ͍ग़͢ ͷʹ͕͔͔࣌ؒΔ
ίʔυͷ࡞ऀ͕PRΛ࡞ͨ͠ࠓฉ ͍ͯ͠·͏ͷ͕Ұ൪ίετ͕খ͍͞
ίʔυͷ࡞ऀ͕ࠓͷલʹ͍ͯίʔυ ʹ͍ͭͯฉ͚Δͷͱͯوॏͳ࣌ؒ
Ͳ͏ͬͯϨϏϡʔ͢Δ
GoogleͷιϑτΣΞΤϯδχΞϦϯά͔ΒӨڹΛ ड͚ͨݴ༿ͷհ
ใݯ GoogleͷιϑτΣΞΤϯδχΞϦϯά https://www.oreilly.co.jp/books/9784873119656/ ୈ9ষίʔυϨϏϡʔ͔Β͜͜Ͱհ͢Δͷ͝ ͘Ұ෦ͳͷͰؾʹͳͬͨਓͥͻॻ੶Λखʹ औͬͯΈ͍ͯͩ͘͞
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.204 ௨ৗίʔυϨϏϡʔ͕ɺ࡞ऀҎ֎ͷऀ͕ ίʔυมߋΛݕূ͢ΔॳΊͯͷػձͰ͋Δ
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.204 ͜͏ͨ͠؍ʹΑͬͯϨϏϡϫʔʹɺ࠷༏ ΕͨΤϯδχΞͰ͢ΒͰ͖ͳ͍͜ͱ͕Ͱ͖Δ Α͏ʹͳΔ
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.204 ͦΕɺίʔυ࡞ऀͷ؍͔Βੜ͡ΔόΠΞε ʹӨڹ͞Εͳ͍ϑΟʔυόοΫΛఏڙ͢Δ͜ͱ ͩ
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.204 ίʔυϨϏϡʔɺ͋Δมߋ͕ΑΓ͍ରʹ ͱͬͯཧղՄೳ͔Ͳ͏͔ࢼ͢࠷ॳͷࢼ࿅Ͱ͋ Δ͜ͱ͕ଟ͍
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.204 ίʔυॻ͔ΕΔΑΓಡ·ΕΔճ͕ଟ͘ͳΔ ͨΊɺ͜ͷ؍ੜࢮΛ͚Δ΄ͲʹॏཁͰ͋ ΓɺཧղͱҙຯͷѲ͕ܾఆతʹॏཁͰ͋Δ
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.203 ίʔυϨϏϡʔɺίʔυͷਖ਼͠͞ʹ͍ͭͯͷສೳͷղܾ ࡦͰ།ҰͷνΣοΫํ๏Ͱͳ͘ɺιϑτΣΞΛΊ ͙ΔͦͷΑ͏ͳʹର߅͢ΔଟޚͷҰཁૉͰ͋Δ
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.203 ݁Ռͱͯ͠ɺίʔυϨϏϡʔ͕ՌΛ্͛ ΔͨΊʹʮᘳʯͰ͋Δඞཁͳ͍
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.203 ࣮ҙ֎ͳ͜ͱʹɺίʔυͷਖ਼͠͞ͷνΣοΫɺίʔ υϨϏϡʔͷϓϩηε͔ΒGoolge͕ಘΔԸܙͷटҐͰ ͳ͍
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.203-204 ͕࣌ؒܦͪίʔυϕʔεࣗମ͕εέʔϧͨ͠ ߹ίʔυͷมߋ͕ཧղՄೳͰҙຯΛ͢ͱ อূ͢Δ͜ͱͷํ͕ɺҙ͕ٛେ͖͍
۩ମతʹͲ͏͢Εʁ
࣭͢Δ
ಛʹ৽͘͠νʔϜʹࢀըͨ͠ϝϯόʔόΠ Ξε͕ͳ͍ͷͰίʔυϨϏϡʔͷޮՌ͕ߴ͍
GoogleͷιϑτΣΞΤϯδχΞϦϯά 9ষίʔυϨϏϡʔ p.209 ͦͷΞϓϩʔν͕ؒҧ͍ͬͯΔͱܾΊ͔͔ͯΔ લʹɺԿނͦͷΑ͏ͳΞϓϩʔν͕࠾ΒΕͨ ͔ʹ͍࣭ͭͯͨ͠ํ͕Α͍
Ͳ͏࣭͢Δ
ίʔυͷ࡞ऀ͕͍ͳ͘ͳͬͯࣗ ͕อकͰ͖Δ͔
ࠓ͍ΔϝϯόʔʢࣗΛؚΊͯʣ ͍ͳ͘ͳͬͯอकͰ͖Δ͔
ͦ͏͍ͬͯࢦఠ͕ଟ͘ͳΔ
લఏͱͯ͠ɺGoogleʹϦʔμ ϏϦςΟϨϏϡʔ͕͋Δ
ಡΈ͢͞ͷͨΊͷపఈͨ͠৽ਓ ݚमͷΠϝʔδ
ใݯ GoogleͷιϑτΣΞΤϯδχΞϦϯά https://www.oreilly.co.jp/books/9784873119656/ ϦʔμϏϦςΟʹ͍ͭͯୈ3ষࣝڞ༗Ͱৄ͠ ͘ॻ͔Ε͍ͯ·͢
ࢲͨͪGoogleͰͳ͍
ϖΞϓϩάϥϛϯά
ΨΠυϥΠϯ࡞
·ͱΊ ίʔυͷ࡞ऀ͍ͳ͘ͳΓ·͢ ཧతʹ࣌ؒతʹ ίʔυΛ࡞ͨ͠ޙʹ͔ͦ͠ͷίʔυͷ࡞ऀ͍·ͤΜ ͦͷίʔυΛӬ͘อक͍ͯͨ͘͠Ίʹɺͦͷ࡞ऀ͕͍Δ͏ͪʹͲ͏ ͍͏ҙਤͰͦͷมߋΛͨ͠ͷ͔֬ೝͯ͠ཧղ͓ͯ͘͜͠ͱ͕େࣄ Θ͔Γʹ͍͘ίʔυͰ͋Εɺमਖ਼ίϝϯτɺυΩϡϝϯτͳͲͷ ՃචΛ͓ئ͍͢Δ
·ͱΊ ཧղͱҙຯͷѲ͕ॏཁͰ͋Δ ਖ਼͠͞ʹ͍ͭͯʮᘳʯͰ͋Δ͜ͱΛٻΊͳ͍ ಈ͍͍ͯΔ͔ΒOKΑΓҙຯ͕Θ͔͔ͬͨΒOKͱ͢Δ ࢦఠΑΓ࣭Λ৺͕͚Δ ࢦఠ͕૿͑ͯ͠·͏ͷɺνʔϜͷঢ়ଶͷԜತΛ͍ࣔͯ͠Δ ϖΞϓϩάϥϛϯάΨΠυϥΠϯΛ࡞ͯࣝ͠ͷڞ༗Λߦ͏