Handle Slim Safety

Yudai Takada Osaka RubyKaigi 03 2023.09.09 (Sat) Handle Slim Safety

ɾName: Yudai Takada ɾGitHub: @ydah ɾX: @ydah_ ɾMember of RuboCop
RSpec team ɾSoftware Engineer at ANDPAD, Inc. self.inspect

Handle Slim Safety

What is Slim?

4MJN͸3BJMTҎ߱ʹରԠͨ͠ߴ଎ ܰྔͳςϯϓϨʔτΤϯδϯͰ͢ɻओ ཁͳ3VCZͷ࣮૷શͯͰ͔ͬ͠Γςετ͞Ε͍ͯ·͢ɻࢲͨͪ͸ܧଓతΠϯ ςάϨʔγϣϯΛ࠾༻͍ͯ͠·͢ɻ HJUIVCBDUJPOT 4MJNͷ֩ͱͳΔߏจ͸ͭͷߟ͑ʹΑͬͯಋ͔Ε͍ͯ·͢͜ͷಈ࡞Λߦ͏ ͨΊʹ࠷௿ݶඞཁͳ΋ͷ͸Կ͔ɻଟ͘ͷਓʑͷ4MJN΁ͷߩݙʹΑͬͯ ൴Β ͕࢖͏)BNM΍+BEFͷӨڹΛड͚ߏจͷ௥Ճ͕ߦΘΕ͍ͯ·͢ɻ4MJNͷ
։ൃνʔϜ͸ඒ͸ݟΔਓͷ໨ͷதʹ͋Δ͜ͱΛ෼͍ͬͯΔͷͰɺ͜͏͍ͬͨ ௥ՃʹΦʔϓϯͰ͢ɻ 4MJN͸ߏจղੳίϯύΠϧʹ5FNQMFΛ࢖͍5JMUʹ૊Έࠐ·Ε·͢ɻ͜Ε ʹΑΓ4JOBUSB΍ϓϨʔϯͳ3BDLͱ΋Ұॹʹ࢖͑·͢ɻ

doctype html html head title My Slim Template body ruby:
message = "Slim!" h1 Welcome to #{ message} p This is a simple example. ͜͏͍͏΍ͭ

҆શʹ͔͋ͭ͏

doctype html html head title My Slim Template body ruby:
message = "Slim!" h1 Welcome to #{ message} p This is a simple example. ࠓ೔ͷλʔήοτ ˡ͜͜

͜Ε͸Կʁ Embedded engines: Tiltͷ͓͔͛ͰɺSlim ͸ଞͷςϯ ϓϨʔτΤϯδϯͷຒΊࠐΈʹݟࣄʹ ରԠ͍ͯ͠·͢ɻ Ruby,JavaScript,css,sass…etc

҆શʹ͔͋ͭ͏

ຒΊࠐΈ಺ͷίϝϯτ doctype html html head title My Slim Template body
h1 Welcome to Slim! javascript: // comment alert("Hello, World!");

ίϯύΠϧޙ <!DOCTYPE html> <html> <head> <title>My Slim Template </ title>
< / head> : </ html> <script> / / mecha kimitsu joho alert("Hello, World!"); </ script> ݟΒΕͨ͘ͳ͍ίϝϯτ΋ ݟΒΕͯ͠·͏

ࢼߦࡨޡ %BOHFS΍4FNHSFQͰܯࠂ͢Δʁ ⭕ϧʔϧΛ௥Ճ͢Δ͚ͩͰྑ͍ ❌ίϝϯτॻ͚ͩ͘Ͱܯࠂ͸ͭΒͦ͏ ❌ܯࠂΛݟམͱ͞ΕΔͱҙຯ͕ͳ͍

ͭͬͨ͘ ZEBITMJNFNCFEEFENJOJGZ

slim-embedded-minify module Slim class Embedded < Filter class TagEngine <
Engine prepend Minify::Tag end class JavaScriptEngine < TagEngine prepend Minify::Javascript end ennd

slim-embedded-minify module Slim class Embedded < Filter module Minify module
Javascript include Tag def on_slim_embedded(engine, body, attrs) mini fi ed_body = minify(body) super(engine, mini fi ed_body, attrs) end ennnnd

slim-embedded-minify ⭕ίϝϯτ͕ࣗ༝ʹॻ͚Δ ⭕௥Ճ࡟আ΋͔ΜͨΜ ⭕ίϯύΠϧ݁ՌΛൺֱͯ͠ίϝϯτ ͷΈ͕ফ͍͑ͯΔ͔ʹΑͬͯ֬ೝՄ

Its safe now

੩తղੳʹ͍ͭͯ

3VCP$PQͰ͸ղੳෆՄ 4MJN͸3VCZͰ͸ͳ͍ͷͰɺ 4ZOUBY&SSPSʹͳΔ ͦΕ͸ͦ͏ spec/f i xtures/dummy.slim:1 : 5 :
F : Lint/ Syntax: unexpected token tCOLON (Using Ruby 2.7 parser; conf i gure using TargetRubyVersion parameter, under AllCops) ruby: ^

ຒΊࠐΈҎ֎ͷTMJ̼ ੩తղੳπʔϧ͋Γ·͢ •r7kamura/slimcop •r7kamura/rubocop - slim ͕ɺຒΊࠐΜͰ͍ΔRubyίʔυͷ੩త ղੳ͸ग़དྷͳ͍

ຒΊࠐΈͷTMJ̼ ੩తղੳπʔϧ͋Γ·͢ •sds/slim - lint ͕ɺautocorrect͸ग़དྷͳ͍

͍ͭͬͨͯ͘Δ ZEBITMJNFNCFEDPQ ❌

slimembedcop html ruby: if File.exists?("foo.txt") message = "Yay!" else message
= "Nooo!" end h1 #{ message} ੾Γग़ͯ͠3VCP$PQʹ౉ͯ͠ ղੳͯ͠΋Β͏

slimembedcop ❯ slimembedcop dummy.slim Inspecting 1 f i le W
Offenses: dummy.slim:3 : 8 : W : [Correctable] Lint/ DeprecatedClassMethods: File.exists? is deprecated in favor of File.exist ?. if File.exists?("foo.txt") ^^^^^^^^^^^^

⭕3VCP$PQͷطଘͷDPQ͕࢖͑Δ ⭕ࣗಈमਖ਼ʹରԠ͍ͯ͠Δ ⭕DPQ͕࡞ΕΔʹTMJNFNCFEDPQͷ DPQ΋࡞ΕΔ slimembedcop

We got static analysis

ීஈԿؾͳ͘࢖͍ͬͯΔ΋ͷʹ΋վળ ͷ༨஍͸ҙ֎ͱ຾͍ͬͯΔͷͰɺͲΜ ͲΜվળͯ͠ɺͲΜͲΜ޾ͤʹͳͬͯ ͍͖·͠ΐ͏ʂʂ ·ͱΊ

Handle Slim Safety

Handle Slim Safety

ydah

More Decks by ydah

Other Decks in Technology

Featured

Transcript

Yudai Takada Osaka RubyKaigi 03 2023.09.09 (Sat) Handle Slim Safety

ɾName: Yudai Takada ɾGitHub: @ydah ɾX: @ydah_ ɾMember of RuboCop