Share
Embed
Transcript
131 slides
-
ϝϧΧϦSREͷ୲ൣғ 2 ࠓͷτϐοΫ 01 SREsΛߟ͑Δ 02 Toilͷଊ͑ํ (ݾΛΔ) 03 ઓུతSRE৫
04 SREۀͰऔΓೖΕͨํ͕ྑ͍จԽ 05 GitΛͬͨ։ൃͱCodeReview࠶ߟ 06 ·ͱΊ 07 -
history 4 history % 1 Work as a system engineer
and PMO assistant 2 Infra engineer at DC enterprise 3 Infra engineer at Game development 4 SRE at Mercari, Inc. -
ϝϧΧϦSREͷ୲ൣғ 11 • Monolithic architectureͷߏஙӡ༻อक(Devops)ɺ৴པੑͷ্ • ରRegion = JP /
US / UK • ͘͞ΒΠϯλʔωοτ, AWS, GCP • Microservices ʹ͍ͭͯɺޙ͍ͷ։࢝ͪɺΩϟονΞοϓظؒ • ࠓޙɺ֤υϝΠϯνʔϜʹଐ༧ఆɻৄࡉޙ΄Ͳɻ • Data platform։ൃɺDevOps of Data (ETL) • Security ରԠ • Middleware, Tool։ൃ -
ϝϧΧϦSREͷ୲ൣғ 12 • Middleware, Tool։ൃ • Productͷػೳ։ൃ • e.g. cache
control, DBIपΓͷߋ৽, maintenance mode࡞, etc • BI systemӡ༻ • ։ൃऀ͔ΒͷReviewґཔͷରԠͳͲ • Πϯϑϥઃܭ • Search Ops • ML Ops • On-Call • etc -
ϝϧΧϦSREͷ୲ൣғ 14 DevOps of Data: BIͷͨΊͷETL(Extract, Transform and Load)ର Ԡࣄྫɻ
TBӽ͑ͷMySQL ڊେςʔϒϧΛ 1Ͱ BigQueryLOAD͢Δ PascalʙPuree + ngx_lua + Fluentd + BigQueryͰͭ͘ΔϝϧΧϦͷϩάੳج൫ʙ -
SREsΛߟ͑Δ 18 SREsͷϙδγϣϯ ϕʔεʹDevͱOpsͷ αΠϩԽΛࢦ͢ DevOpsͷֶ αΠϩԽͱɺ ֎෦ͱͷ࿈ܞΛ࣋ͨͣʹ ࣗݾத৺తͰݽཱ͍ͯ͠Δ ঢ়ଶ
class SRE implements DevOps -
19 SREsΛߟ͑Δ " αΠϩԽʹ͍ͭͯิ " DevOps " Dev + OpsͰ։ൃͱӡ༻ͷαΠϩԽΛࢦ͠·͢
" ޙʹઆ໌͢ΔMicroservicesͰɺαʔϏε͝ͱʹαΠϩԽΛࢦ͠· ͢ https://speakerdeck.com/mercari/mtc2018-microservices-platform-at-mercari -
SREsΛߟ͑Δ 27 SRE͕͍ͳ͍ɻ ࠾༻Ͱ͖Δ·Ͱɺ։ൃऀ͕݉͢Δࣄ͋ΔͰ͠ΐ͏ɻ e.g.ʮ৴པੑͷཧ͕͠ΜͲ͘ͳ͖ͬͯͨʯ, ʮMicroservicesͬͯΔ͚Ͳো ରԠͩΒ͚Ͱ͠ΜͲ͘ͳ͖ͬͯͨʯ, ʮSLO͕ܾΊΒΕͳ͍ʯ, ʮ૬ஊ૬ख͕͍ ͳ͍ʯ,
ʮΓํ͕ਖ਼͍͠ํʹ͔͍ͬͯΔ͔ෆ҆ͩʯ, etc ͱ͍ͬͨ͜ͱൃੜ͢Δͱࢥ͍·͢ɻ -
35 ఢΛΓݾΛΕඦઓة͏͔Βͣ " ݾΛΔ " ࣗΛΓؒΛΔʹ? " ετϨϯάεϑΝΠϯμʔͱ͍͏ͷ͕ྑ͍Β͍͠! " ͬͯΈͯྑ͔ͬͨ
" ؾ͕͔ͳ͔ͬͨࣗͷڧΈΛΕΔ " ؒͷڧΈɺΑΓྑ͍͠ํΛΕΔ -
Toil limit 38 ToilͱSREຊग़ͯ͘Δ֓೦ ToilͷՄೳੑ͕ߴ͍࡞ۀͱ • ख࡞ۀͰ͋Δ͜ͱ • ܁Γฦ͞ΕΔ͜ͱ
• ࣗಈԽͰ͖Δ͜ͱ • ઓज़తͰ͋Δ͜ͱ • ظతͳՁΛ࣋ͨͳ͍͜ͱ • αʔϏεͷʹରͯ͠O(n)Ͱ͋Δ͜ͱ -
Toil limit 41 • “ΤϥʔόδΣοτͱಉ༷ʹɺ੍ݶΛݫक͢Δ” • Toil limitɺSREs͕ظ͞ΕΔৼΔ͍ʹ͍ͭͯ߹ҙʹୡ ͢ΔͷΛॿ͚ɺϔϧϓ͕ඞཁͳͱ͖ʹ໌֬ͳγάφϧΛఏڙ ͠ɺՃՁͷͳ͍܁Γฦ͠࡞ۀ͕ຮԆΔ͜ͱΛආ͚·͢ɻ
• ैདྷͷITӡ༻จԽͰɺνʔϜ͕͜ͷΑ͏ͳอޢΛड ͚Δ͜ͱΊͬͨʹ͋Γ·ͤΜɻ” http://shop.oreilly.com/product/0636920063964.do Seeking SRE: -
47 Toilͷัଊ " ͔͠͠ɺଞͷλεΫཧπʔϧɺΧϯόϯπʔϧͳͲΛͬͯ ͍ͯɺ྆ํ͏ͷ͕େมͩͱ͍͏߹ " ͨͱ͑JIRATrelloͩͬͨΒlabel ͰܭଌͰ͖Δ༷ʹ͢ Εྑ͍ "
JIRAͩͱඪ४Ͱ౷ܭπʔϧ͕Έࠐ·Ε͍ͯΔͷͰɺͦΕ ͰToilΛܭଌͰ͖Δ༷ʹ͢Δ -
48 Toilͷัଊ " ͠Toilͷัଊ͕͍͠߹ " εϓϦϯτ͕Մೳͳঢ়گͳΒɺٯʹϕϩγςΟΛܭଌ͢Ε ྑ͍ “͔͠͠ɺToil࣌ؒͰ͋ΔɺׂΓࠐΈͰ͋Δɺ͕ଟ͍ɺ·ͨToilͱEngineering ͷ۠ผ࣮͍͠ͱ͍ͬͨΑ͏ʹܭଌ͕͘͠ͳΔΑ͏ͳੑ࣭Λͭɻ ͕ͨͬ͠
ͯɺToilΛܭଌ͢ΔͷͰͳ͘ɺϕϩγςΟΛܭଌ͢Δ͜ͱʹͨ͠ɻ” 2019SREߟ / Ώ͏͏͖ϒϩά/ -
ઓུతSRE৫ 55 ظ (Growth Phase / Hyper Growth Phase) Ref.
https://bfore.hongotechgarage.com/entry/evolution_of_a_product -
ઓུతSRE৫ 56 ظ (Growth Phase) ϓϩμΫτ͕ޭͨ͠ͱݴ͑ΔظɺඪͷઃఆϏδωεϞ σϧɺࣄۀܭըʹΑͬͯҟͳΓ·͢ɻ ͱʹ͔͘ஈ֊ (Hyper Growth
Phase) ʹೖΔલʹɺͦͷ ۂઢఆணۂઢΛ៉ྷʹඳ͚ΔΑ͏ʹ৴པੑΛߴΊΔࣄ͕ඞཁ Ͱ͢ɻ -
ઓུతSRE৫ 58 ظ (Growth Phase) ͦ͜ͰɺStickiness(೪ண) / Install DAUɺWAUɺ MAUɺ(e.g.
ࠂऩೖϞσϧͰແ͍߹GMVؚΊ Δ)ͳͲͷKPIΛݟͯɺҰఆΛ͑ͨΒॱௐʹͯ͠ ͍Δͱஅ͢ΔϏδωεతઓུ؍Λզʑҙࣝ͢Δɻ -
ઓུతSRE৫ 60 ظ (Growth Phase) ྫ͑ɺ SRE͕ ”DevOps of Data”
(e.g. ETL, pipelining)Λߦ͍BigQueryʹૹΔɻ ͦΕΛBIνʔϜ͕ɺLookerSlackΛͬͯKPIΛݟΕΔঢ়ଶʹ͓ͯ͠ ͘ɻͳͲ https://looker.com/blog/must-have-kpis-for-your-marketing-dashboards -
ઓུతSRE৫ 61 ظ (Growth Phase) • ϓϩμΫτ/ࣄۀ͕໎͍ͯ͠Δ͜ͱΛೝࣝͨ͠Β • ৗʹશ͕ͯޭ͢ΔΘ͚Ͱͳ͍ͷͨΓલ •
ੵۃతʹμϯαΠδϯά (࣮ࢪલʹࠓޙͷࢪࡦཁ֬ೝ) -
ઓུతSRE৫ 64 ظ(Growth Phase): ूத͖͢ͷ •ΦϯϘʔσΟϯά४උ •Documentඋ (Wiki, README, Srcͷίϝϯτ,
DesignDoc) •Booster(ΦϦΤϯςʔγϣϯ, Kickstartܥπʔϧ, etc) •࠾༻׆ಈ •ొஃɺϒϩάɺetc -
ઓུతSRE৫: Documentඋ 67 Ducumentʹ͍ͭͯɺҎԼͰ͖͍ͯ·͔͢? • ʮඞཁͳใ͓ͦΒ͘͜͜ʹ͋Δʯͱօ͕ৗʹࢥ͑Δڥ͕ ඞཁ • ͨͱ͑νʔϜશһ͕ఱ࠽తʹಡΉͷ͕ૣͯ͘ʮSourceΛಡ ΊʯͰย͚Δͷඇޮͩ͠ةݥ
• จ຺ཧղͰ͖ͣʹޡղͱ͍͏ϦεΫ͋ΔͨΊɺϏδωε తʹνʔϜϫʔΫతʹϚΠφε -
ઓུతSRE৫: Documentඋ 69 Ducumentʹ͍ͭͯɺҎԼͰ͖͍ͯ·͔͢? • ใͷҰݩཧͱཧ • ඞཁͳใ͕ҰՕॴ͘Β͍ʹू·͍ͬͯ·͔͢ʁ • ԿՕॴ୳͢ͷඇޮͰϛε͕૿͑·͢
• e.g.ʮ˓˓ͲͷαʔϏεΛ͑ྑ͍͔ʯϋοΩϦΘ͔Δ • ཧ͞Ε͍ͯ·͔͢? • e.g.ʮΧςΰϥΠζ͞ΕͨπϦʔߏʯͰɺͲͷใ͕Ͳ͜ʹॻ͔Εͯ ͍Δ͔ϋοΩϦ͍ͯ͠Δɺݕࡧਫ਼ྑ͍ -
ઓུతSRE৫: Documentඋ 70 Ducumentʹ͍ͭͯɺҎԼͰ͖͍ͯ·͔͢? • ಋઢΛৗʹҙࣝ! • e.g. READMEλεΫཧνέοτʹWikiDesignDoc ͷಋઢ(URL
Link) ͕ுΒΕ͍ͯͯɺޙ͔ΒḷΓ͍͢ • Ұݩཧ͕పఈͰ͖͍ͯΕෆཁͱͳΔ͕ɺͦ͏Ͱͳ͍ ͜ͱଟ͍ͷͰɺͦͷରԠࡦͱͯ͠ྑ͍ํ๏ -
ઓུతSRE৫: Documentඋ 71 Ducumentʹ͍ͭͯɺҎԼͰ͖͍ͯ·͔͢? • ूཧ • ΨΠυϥΠϯͷ࡞ (͜Εಋઢ) •
awesomeԿͪΌΒͷ༷ͳrepositoryΛ࡞͢Δͷྑ͍ Γํͩͱࢥ͍·͢ɻ • Ref: Awesome Lists -
ઓུతSRE৫: Documentඋ 73 ϢϏΩλεݴޠ • “υϝΠϯΤΩεύʔτɺυϝΠϯʹ͍ͭͯͷཧղΛ͑ Δʹ͍ʹ͔ͬͨ͘ΓෆదͩͬͨΓ͢Δ༻ޠߏʹ ҟٞΛএ͑Δ͖Ͱ͋Γɺ։ൃऀɺઃܭΛ͢Δ͜ͱ ʹͳΔ͍͋·͍͞ෆ߹ʹΛޫΒͤΔ͖Ͱ͋Δɻ” •
Ҿ༻ݩ: Eric Evans. ΤϦοΫɾΤϰΝϯεͷυϝΠϯۦ ಈઃܭ (DDD) -
ઓུతSRE৫: Documentඋ 74 ໋໊نଇ໋໊ن࡞Γɺߏઃܭૣ͍͏ͪʹɻ • ࠞཚΛট͘ྫ • Web V1 ͱ
web2͕࣮ಉ͡ҙຯͰɺWeb V2ͦ ΕΒͱผɻ͔͠pcwebͱ͍͏ͷ͋Δ͕ɺͦͷ ҧ͍ෆ໌ɻͦΕͧΕͷಠࣗ༻ޠͷҙຯterms ແ͍ͷͰΘ͔Βͳ͍ঢ়ଶʹؕͬͨɻ -
ઓུతSRE৫: Documentඋ 75 ໋໊نଇ໋໊ن࡞Γɺߏઃܭૣ͍͏ͪʹɻ • ࠞཚΛট͘ྫ • prefixsuffixͷ͚ํ͕ΊͪΌͪ͘ΌͰɺຖճਖ਼نදݱΛۦͯ͠ݕ ࡧ͢ΔӋʹͳ͍ͬͯΔ (ਖ਼نදݱ͕͑ΔڥͳΒ·ͩྑ͍͕...)
• ͜͏͍ͬͨ͜ͱɺෳͷνʔϜͰ࿈ܞ͢Δ͔Βඇৗʹൃੜ͍͢͠ • ଟ͘ͷձࣾ͜͏͍ͬͨΛى͜͢ϦεΫ͕͋Δ • ͔ͩΒͦ͜ҙͯ͠పఈ͢Δ͜ͱ͕େࣄ -
ઓུతSRE৫: Documentඋ 76 • Ducumentʹ͍ͭͯɺҎԼͰ͖͍ͯ·͔͢? • ໌֬Խ • RFCΛࢀߟʹ͢Δ •
MUST (͠ͳ͚ΕͳΒͳ͍), SHOULD (͢Δ͖), MUST NOT, SHOULD NOT ΛϋοΩϦͤ͞Δ • https://www.ietf.org/rfc/rfc2119.txt -
ઓུతSRE৫: Documentඋ 77 • จ຺ͷ༻ҙ • ԿނͦΕ͕ඞཁ͔ɺ୭͕Ͳ͏ͬͯ࡞Δͷ͔/࡞ͬͨͷ͔ཧղͰ͖Δͷ • DesignDocΛࢀߟʹ͢Δ •
http://ukai.jp/Slides/2007/0907-itpro/ HackersSoftwareEngineering.pdf • Src codeͷίϝϯτɺ README • ඞཁ࠷ݶͷઆ໌खॱಋઢ -
ઓུతSRE৫ 81 ظ(Growth Phase)ͷޙظ • Microservices (ུ: MS)Խ • ݱ࣌Ͱɺ࠷ॳMonolithic
Architecture Λ࠾༻ ͍ͯͯ͠ɺ͞ΒͳΔظ(ظ)͕࣮֬ʹདྷ ΔࣄΛೝࣝͰ͖͔ͯΒҠߦ͢ΔProductଟ͋͘Δ Ͱ͠ΐ͏ -
ઓུతSRE৫ 82 ظ(Growth Phase)ͷޙظ • Microservices (ུ: MS)Խ • ϓϩμΫτͷޭͰɺ৫ɾ֦େ͢Δ
• ৫ͷεέʔϧΞοϓʹରԠͰ͖ΔΑ͏ʹ -
ઓུతSRE৫ 83 ظ(Growth Phase)ͷޙظͰɺ༏ઌతʹऔΓΉ͜ͱ • ߏཧπʔϧͷϦϑΝΫλϦϯάͷ։࢝ • ֤πʔϧͷ൚༻ੑՃͷ։࢝ • Toil໓׆ಈͷ։࢝
• ඇਪɾഇࢭ ͷపఈ ͜͜·ͰʹDocumentͷ༻ҙ͕ࡁΜͰ͍ͯɺΦϯϘʔσΟϯά͕εϜʔζ ʹߦ͍͑ͯͨΒɺൺֱతૣΊʹ͜ΕΒ։࢝͢Δ͜ͱ͕Ͱ͖ΔͣͰ͢ɻ -
ઓུతSRE৫ 87 ◦ “ϞϊϦεΛϚΠΫϩαʔϏεʹׂ͢Δͱ͖ʹɺϚΠΫϩ αʔϏεΛ։ൃɺ࣮ߦ͢ΔͨΊͷ҆ఆͨ͠ϓϥοτϑΥʔϜ Λఏڙ͢ΔΠϯϑϥετϥΫνϟ෦ͷॏཁੑ͕ɺۃʹ্ ͕Γ·͢ɻ “ ▪ ϝϧΧϦͰಉ͘͡ɺϚΠΫϩαʔϏεͷΠϯϑϥΛఏڙ
͢ΔઐͷνʔϜΛઃཱ͠ɺͦΕΛ֤ϚΠΫϩαʔϏενʔ ϜʹఏڙͰ͖Δ৫ߏͱͳ͍ͬͯ·͢ɻ -
ઓུతSRE৫ 89 • ϝϧΧϦͷྫ • SRE team • طଘͷMonolithic architecture
ͱͦͷMicroservicesͷҠߦޙͷӡ༻Λι ϑτΣΞͷٕज़Λۦͯ͠ӡ༻͢Δ • Microservices Platform team • ઌߦͯ͠Microservicesج൫Λ࡞Δઐ෦ୂ • Microservices Architecture team • MS Platform ઌߦͯ͠Microservicesج൫Λ࡞Δઐ෦ୂ • Microservices Developers • Service ΛMicroservices ʹҠߦ͢Δ։ൃऀ -
ઓུతSRE৫ 90 • ϚΠΫϩαʔϏεΞʔΩςΫνϟΛऔΓೖΕΔ͜ͱʹΑͬͯɺ ൃੜ͢ΔτϨʔυΦϑΛཧղ͢Δ ◦ “ٯίϯΣΠͷ๏ଇ͕ಇ͘͜ͱʹΑΔνʔϜͷݽཱԽͱ νʔϜؒͷίϛϡχέʔγϣϯෆ” ◦
“ٕज़తͳεϓϩʔϧ(ෆنଇͳ) ʹΑΔେͳίετ” ◦ “γεςϜোൃੜύλʔϯͷ૿Ճ” ◦ “ٕज़ͱΠϯϑϥͷϦιʔεୣ͍߹͍” -
ઓུతSRE৫ 94 ظ(Hyper Growth Phase) • MicroservicesԽʹΑΔϕϩγςΟͷ্ͰɺΧΠ θϯͱൃలΛՃͤ͞Δ • Container
Orchestration, Service meshʹΑΓɺ ৴པੑΛ্ͤ͞Δ -
ઓུతSRE৫ 97 • ۀ͔࣌ΒϚΠΫϩαʔϏε? ◦ ձࣾʹΑͬͯɺ͜ͷΞϓϩʔν্͕ख͘ߦ͘߹͋Δͱ ߟ͑ΒΕ·͢ ▪ ΠϯϑϥͱਓతϦιʔε͕༻ҙͰ͖Δ
▪ ձࣾͷࢿۚʹ༨༟͕͋Δ ͔͠͠ɺͦΕҎ֎ʹॏཁͳ͜ͱ…ɻ ͦΕ࣍ͷϖʔδʹ -
ઓུతSRE৫ 98 • ࠷ॳ͔ΒϚΠΫϩαʔϏε? / খ͞ͳاۀ (e.g. ελʔτΞο ϓ)ͷ߹ ▪
“৽͍͠ձࣾͷ৽͍͠ΞϓϦέʔγϣϯʹɺϚΠΫϩαʔ ϏεʹదʹͰ͖Δ΄Ͳɺػೳ͕ͦͦଟ͋͘Γ· ͤΜɻ” ▪ Ҿ༻ݩ: ϓϩμΫγϣϯϨσΟϚΠΫϩαʔϏε -
105 ·ͱΊΔͱ • ϚʔέςΟϯάɺϒϥϯσΟϯά • εέʔϥϏϦςΟͷඞཁ • ࠾༻ɺٕज़্ࢥߟͳͲΤϯδχΞࢹ ͳͲͷࢿ؍ͱ •
ϓϩμΫτͷޭঢ়گ • ༧ࢉ • ରԠՄೳͳΤϯδχΞ ͳͲͷࢿຊͷόϥϯε͕औΕ͍ͯΔͳΒɺ͍ͭ։࢝ͯ͠ྑ͍ͱࢥ͍·͢! -
106 ΞʔΩςΫνϟʔϫϯύλʔϯͰͳ͍ • Monolithic architecture => Microservices architecture ͷྲྀΕ͕ओ ྲྀ
• ͚ͩͲͦΕ͚ͩͰͳ͍ • બࢶଞʹ͋Δ -
ͦͷଞͷΞʔΩςΫνϟʔ 107 ิͰ͕͢ɺService-Oriented Architecture (SOA/αʔϏεࢦΞʔΩςΫ νϟʔ) ͱݺΕΔͷଘࡏ͠·͢ɻ https://www.nginx.com/resources/library/microservices-vs-soa/? utm_campaign=microservices&utm_medium=ebook&utm_source =infoq&utm_content=RVC
https://dzone.com/articles/microservices-vs-soa-whats-the-difference -
108 [ิ] Service-oriented architecture(SOA)? • ʮͰ͖ΔݶΓڞ༗ʯʮϏδωεػೳͷ࠶ར༻ʯΛॏཁͱ͍ͯ͠ Δ • 4छྨͷαʔϏεʹ͔ΕΔ •
ϏδωεɺΤϯλʔϓϥΠζɺΞϓϦέʔγϣϯɺΠϯϑϥ • ڞ௨ͷ౷࣏ͱج४ > ࣗ༝ • ैདྷͷRDBMSΛΑ͘͏ • ݱࡏɺDevOps / CDීٴ࢝͠Ίɻ·ͩओྲྀͳͷଘࡏ ͍ͯ͠ͳ͍ -
109 [ิ] Service-oriented architecture(SOA)? • SOAͷαʔϏεཻ • αʔϏείϯϙʔωϯτͷαΠζɺখنͷΞϓϦέʔγϣϯαʔ Ϗε͔ΒඇৗʹେنͳΤϯλʔϓϥΠζαʔϏε·ͰɺରԠ͕ग़ དྷ·͢ɻ
• ࣮ࡍʹɺେنͳαϒγεςϜʹ૬͢Δେ͖͞ͷαʔϏ είϯϙʔωϯτΛSOAͰ࣋ͭͷ͕Ұൠతɻ • αʔϏείϯϙʔωϯτͷڞ༗͕ॏཁͳ֓೦ͷ̍ͭ • ϦϞʔτΞΫηεϓϩτίϧͱͯ͠ϝοηʔδϯάʢAMQPɺ MSMQʣ͓ΑͼSOAPʹґଘ -
SREۀͰऔΓೖΕͨํ͕ྑ͍จԽ 111 • ΞδϟΠϧ։ൃ • εΫϥϜͰͷεϓϦϯτͷӡ༻͍͔͠ʁ • ݟੵʹ͔͚Δ·ͱ·ͬͨظ͕ؒऔΕͳ͍ • ଟํ໘͔Βͷେྔಥൃ࡞ۀ
• ͔͠͠ɺεΫϥϜࣗମͷࣝඞਢ • ϢϏΩλεݴޠతʹͦͷଞͰ • SREʹΧϯόϯ༗ޮ -
SREۀͰऔΓೖΕͨํ͕ྑ͍จԽ 112 • ΞδϟΠϧ։ൃ • ࠷ۙLego scrumͱ͍͏τϨʔχϯάʹࢀՃͯ͠Έ·ͨ͠ • ֶָͨ͘͠ͷͰͱͯΦεεϝ!! •
λοΫϚϯϞσϧͰ͍͏ػೳظʹૣ͍͚ͬͯͦ͘͏! • λοΫϚϯϞσϧͱ https://www.lego4scrum.com/ -
SREۀͰऔΓೖΕͨํ͕ྑ͍จԽ 113 " Մಡੑͷҙࣝ / ϦʔμϒϧίʔσΟϯά " e.g. આ໌ม "
ม໊ʹҙຯΛ࣋ͨͤΔ " ม໊ΛݟΕɺͦΕ͕ԿΛ͍ͯ͠Δ͔ཧղͰ͖Δ " ίϝϯτͷॻ͖ํ " Մಡੑͷྑ͍ؔͷॻ͖ํ " ಡΈ͘͢؆ܿʹॻ͚Δ༷ʹ͢ΔςΫχοΫ " อकੑߋ৽Λ্͛ɺকདྷͷࣗͷෛ୲Լ͛Δ " ͱͯॏཁͳ͜ͱ͕٧·͍ͬͯΔ " ڞ௨ೝࣝΛ࣋ͨͳ͍ಠུࣗޠͷ༻ېࢭ -
119 Pull Request(P-R)ͷཻͲͷ͘Β͍͕ྑ͍? • Release early, Release often ʢૣΊͷϦϦʔεɺ͠͠ߋ৽͢Δ) ͷCycle
Ͱճ ͍͚ͯ͠Δ͘Β͍͕ΦεεϝͰ͢ɻ • ͜ΕΞδϟΠϧ։ൃͷߟ͑/ਐΊํ -
122 P-Rग़དྷΔ͚ͩখ͘͞ऴΘΒͤΔͱ͜Ε͚ͩಘ " Review͞Ε͘͢ͳΔ " Reviewerͷෛ୲͕ݮΒͤΔ " Merged Cycle͕ૣ·Δ "
ਝͳ෮چରԠ͕ग़དྷΔ༷ʹͳΔ " Conflictݮগ͢Δ " Deploy / ReleaseͷӨڹΛখ͘͞Ͱ͖Δ ◦ ݁Ռɺ৴པੑΛ্Ͱ͖ΔՄೳੑ -
126 P-Rখ͘͢͞ΔࣄΛਪ͍ͯ͠ΔهࣄͷҰྫ " https://www.madetech.com/blog/deployment-by-pull-requests " Feedback is easier to gather
if the pull request is small, so some effort should be spent to make more concise pull requests. " Reducing conflicts " The pull requests are kept open just for a small amount of time, to get enough reviews and merged as quickly as possible. In order to support this workflow, the pull requests are kept as small as possible on purpose so they can be reviewed easily and merged quicker. Multiple pull requests can be opened if the work to be carried is too large to fit into a single one. " https://www.thedroidsonroids.com/blog/splitting-pull-request " There should only be one issue resolved with each pull request, and only one pull request required to resolve an issue. " https://d83tozu1c8tt6.cloudfront.net/media/resources/SDL_GitHub_BestPractices.pdf " https://blog.nathanaelcherrier.com/en/advice-great-code-review/ " A developer who wants to receive useful review comments or wants these colleagues to quickly review his pull request, should follow this tiny single rule: one feature = one pull request. " Reviewers are also developers who have tasks to do. Reviewing a pull request takes time. As a reviewer, when I see a big pull request which contains a lot of features I don't want to review it right now but later because I know I am going to spend a lot of time on this pull request. -
[ิ] P-RReviewͰΑ͘ར༻͢ΔҰൠతͳུޠ 127 • WIP • ࡞ۀ్தͷ߹ʹ͏ • e.g. [WIP]
Add an Ansible role for *** • RFC • ҙݟΛٻΊΔ • e.g. RFC labelɺ[RFC] Add exponential backoff with retry in example-controller • IMO • ReviewίϝϯτͰݸਓతҙݟͱ͍͏ͷΛڧௐ • .e.g. ʮ[IMO] ΠΠω :+1: ! ͋ͱɺࢲ͜ΕΛ͚Ճ͑Δͱྑͦ͞͏ͱࢥ͏Μ͚ͩ ͲɺͲ͏ࢥ͍·͔͢?ʯ -
·ͱΊ 129 • Ϗδωε·Ͱࢹ֯Λ͛ͯઓུతʹ! • SREϏδωεશମΛݟΔඞཁ͕͋ΔΤϯδχΞͱཧղ͢Δ • ঢ়گʹ߹Θͤͨ৬ͱΛߟ͢Δඞཁ͕͋Δ • ϓϩμΫτ/Ϗδωεͷ/ޭ͕Ұ൪
• ࠓͷ࣌Documentେࣄ! • MicroservicesಋೖܭըΛ͔ͬ͠Γͱ! • ྑ͍ͱࢥͬͨจԽऔΓೖΕͯΈΔ • ࣌ɺϚΠΫϩʓʓʓ / Microdevelopments !! -
࠷ޙʹ 130 ࠓͷΛฉ͍ͯ/ಡΜͰ ਂ͍ཧղͱڞײ + ڧ͍ڵຯ + => Ұॹʹಇ͖͍ͨ
ͱࢥͬͯ͘Εͨ͋ͳͨ!! SRE EMΛܹืूதͰ͢! TwitterͰktykogm·ͰDM͍ͩ͘͞ or ࠙ձͰ͓͠·͠ΐ͏ɻ ҿΈͰ༠͍ͬͯͩ͘͞ʂʂ