Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Droidcon Berlin: Testing in Practice

Droidcon Berlin: Testing in Practice

Testing isn't always everybody's favourite task, but that doesn't need to be the case! Writing tests can be an enjoyable way to practice your coding techniques!

But with conflicting opinions on writing test code that is declarative, explicit, terse, concise, and isolated, it can be tough to know how to satisfy all of these whilst still retaining your will to live.

I'll be covering a few techniques, and mechanisms, for writing idiomatic Kotlin code that leaves you with a beautiful test case that not only fulfils all this but gives you accurate code documentation for your project.

Ash Davies

July 03, 2024
Tweet

More Decks by Ash Davies

Other Decks in Programming

Transcript

  1. Testing in Practice Keeping Your Tests Concise and Declarative Droidcon

    Berlin - July '24 ! Ash Davies - SumUp Android / Kotlin GDE Berlin Cat Person ashdavies.dev 1
  2. "Hey, I hope you had a relaxing weekend..." — QA

    Enginner (8:47 Monday morning) ashdavies.dev 4
  3. Testing — Monkey — End-to-End — Acceptance — Instrumentation —

    Integration — Regression — Unit ashdavies.dev 6
  4. Writing Unit Tests Pros Cons They'll improve the quality of

    my code I don't want to It'll take like 10 mins max Literally everyone says that I should ashdavies.dev 9
  5. class ThermosiphonTest { @Mock var heater: Heater @Mock var logger:

    Logger @InjectMocks lateinit var sut: Thermosiphon @SetUp fun setup() { MockAnnotations.init(this) } @Test fun `should heat water`() { thermosiphon.pump() assertTrue(heater.isHot()) } } ashdavies.dev 25
  6. class ThermosiphonTest { @Mock var heater: Heater @Mock var logger:

    Logger @InjectMocks lateinit var sut: Thermosiphon @SetUp fun setup() { MockAnnotations.init(this) whenever(heater.heat(any())).thenReturn(/* ... */ whenever(logger.log(any())).thenAnswer { /* ... */ } @Test fun `should heat water`() { thermosiphon.pump() val argumentCaptor = argumentCaptor() verify(heater).heat(argumentCapture.capture()) assertTrue(argumentCaptor.values[0]) } } ashdavies.dev 28
  7. Factory Functions interface Pump { fun pump() } class Thermosiphon(

    private val heater: Heater, ) : Pump ashdavies.dev 30
  8. Factory Functions interface Pump { fun pump() } fun Pump(heater:

    Heater): Pump { return Thermosiphon(heater) } private class Thermosiphon( private val heater: Heater, ) ashdavies.dev 31
  9. Factory Functions public actual fun <T> lazy(mode: LazyThreadSafetyMode, initializer: ()

    -> T): Lazy<T> = when (mode) { LazyThreadSafetyMode.SYNCHRONIZED -> SynchronizedLazyImpl(initializer) LazyThreadSafetyMode.PUBLICATION -> SafePublicationLazyImpl(initializer) LazyThreadSafetyMode.NONE -> UnsafeLazyImpl(initializer) } ashdavies.dev 33
  10. Functional Interfaces fun interface Pump { fun pump() } fun

    Pump(heater: Heater): Pump { return Thermosiphon(heater) } private class Thermosiphon( private val heater: Heater, ) ashdavies.dev 35
  11. Functional Interfaces fun interface Pump { fun pump() } fun

    Pump(heater: Heater) = Pump { /* ... */ } ashdavies.dev 36
  12. Functional Interfaces fun interface Pump { fun pump(): Boolean }

    - val pump = mock<Pump> { - whenever(heat()).thenReturn(true) - } + val pump = Pump { true } ashdavies.dev 37
  13. class ThermosiphonTest { @Test fun `should heat water`() { var

    isHot = false val heater = Heater { isHot = true } val thermosiphon = Thermosiphon(heater) thermosiphon.pump() assertTrue(isHot) } } ashdavies.dev 38
  14. class ThermosiphonTest { @Test fun `should heat water`() { var

    isHot = false val heater = Heater { isHot = true } val thermosiphon = Thermosiphon(heater) thermosiphon.pump() assertTrue(isHot) } @Test fun `should cool down after heating`() { /** ... */ } } ashdavies.dev 39
  15. class ThermosiphonTest { @Test fun `should heat water`() { var

    isHot = false val heater = Heater { isHot = true } val thermosiphon = Thermosiphon(heater) thermosiphon.pump() assertTrue(isHot) } @Test fun `should cool down after heating`() { /** ... */ } @Test fun `should not catch fire when flying`() { /** ... */ } } ashdavies.dev 40
  16. class ThermosiphonTest { @Test fun `should heat water`() { var

    isHot = false val heater = Heater { isHot = true } val thermosiphon = Thermosiphon(heater) thermosiphon.pump() assertTrue(isHot) } @Test fun `should cool down after heating`() { /** ... */ } @Test fun `should not catch fire when flying`() { /** ... */ } @Test fun `should not become sentient`() { /** ... */ } } ashdavies.dev 41
  17. class ThermosiphonTest { val heater = Heater { isHot =

    true } val thermosiphon = Thermosiphon(heater) var isSentient = false var hasExploded = false var isHot = false @Test fun `should heat water`() { /* ... */ } @Test fun `should cool down after heating`() { /** ... */ } @Test fun `should not catch fire when flying`() { /** ... */ } @Test fun `should not become sentient`() { /** ... */ } } ashdavies.dev 42
  18. class ThermosiphonTest { val heater = Heater { isHot =

    true } val thermosiphon = Thermosiphon( overflow = SmallOverflowTank(), heater = heater, ) var isSentient = false var hasExploded = false var isHot = false @Test fun `should heat water`() { /* ... */ } @Test fun `should cool down after heating`() { /** ... */ } @Test fun `should not catch fire when flying`() { /** ... */ } @Test fun `should not become sentient`() { /** ... */ } } ashdavies.dev 43
  19. class ThermosiphonTest { val heater = Heater { isHot =

    true } val thermosiphon = Thermosiphon( overflow = SmallOverflowTank(), aiEngine = GeminiEngine(), heater = heater, ) var isSentient = false var hasExploded = false var isHot = false @Test fun `should heat water`() { /* ... */ } @Test fun `should cool down after heating`() { /** ... */ } @Test fun `should not catch fire when flying`() { /** ... */ } @Test fun `should not become sentient`() { /** ... */ } } ashdavies.dev 44
  20. class ThermosiphonTest { val heater = Heater { isHot =

    true } val thermosiphon = Thermosiphon( overflow = SmallOverflowTank(), aiEngine = GeminiEngine(), heater = heater, launchCodes = emptyList(), ) var isSentient = false var hasExploded = false var isHot = false @Test fun `should heat water`() { /* ... */ } @Test fun `should cool down after heating`() { /** ... */ } @Test fun `should not catch fire when flying`() { /** ... */ } @Test fun `should not become sentient`() { /** ... */ } } ashdavies.dev 45
  21. class ThermosiphonTest { @Test fun `should heat water`() { var

    isHot = false val thermosiphon = thermosiphon( onHeat = { isHot = true }, ) thermosiphon.pump() assertTrue(isHot) } } fun thermosiphon( onHeat: () -> Unit ) = Thermosiphon( overflow = SmallOverflowTank(), aiEngine = GeminiEngine(), heater = Heater(onHeat), launchCodes = emptyList(), ) ashdavies.dev 46
  22. DRY Don't Repeat Yourself — Remove duplication — High code

    reusability — Isolating change ashdavies.dev 47
  23. DAMP Descriptive AND Meaningful Phrases — Some duplication permitted —

    Declarative syntax — Meaningful naming ashdavies.dev 48
  24. Documentation /** * Make sure not to change this thing

    back to the previous implementation, * because it breaks on that one specific device in production, * when opening the user profile in France using a German locale. **/ fun doMyThing() { /* ... */ } ashdavies.dev 51
  25. Documentation /** * Make sure not to change this thing

    back to the previous implementation, * because it breaks on that one specific device in production, * when opening the user profile in France using a German locale. * * Update: We changed this to be a remote resolution, this shouldn't happen? * We haven't seen it happen in production anymore, but just leave this * comment here, incase it occurs again... **/ fun doMyThingRefactoredV63() { /* ... */ } ashdavies.dev 52
  26. Documentation /** * Make sure not to change this thing

    back to the previous implementation, * because it breaks on that one specific device in production, * when opening the user profile in France using a German locale. * * Update: We changed this to be a remote resolution, this shouldn't happen? * We haven't seen it happen in production anymore, but just leave this * comment here, incase it occurs again... * * Update: It's happening again, but for Italian uses in Australia, * I really hope our Italian QA enginner doesn't go on vacation to Melbourne again... **/ fun doMyThingRefactoredToBeMoreSafeIHopeV91() { if (user.locale == Locale.ITALY) { /* Hacky hack McHackFace */ } } ashdavies.dev 53
  27. Documentation: Tests fun `should store in user specific locale when

    device is in another country() ashdavies.dev 55
  28. Documentation: Tests fun `should store in user specific locale when

    device is in another country() { val intendedTarget = ... val expectedLocale = ... val actualLocale = doMyThing() assertEquals(expectedLocale, actualLocal) } ashdavies.dev 56
  29. class ThermosiphonTest { @Test fun `should heat water`() { var

    isHot = false val thermosiphon = thermosiphon( onHeat = { isHot = true }, ) thermosiphon.pump() assertTrue(isHot) } } fun thermosiphon( onHeat: () -> Unit ) = Thermosiphon( overflow = SmallOverflowTank(), aiEngine = GeminiEngine(), heater = Heater(onHeat), launchCodes = emptyList(), ) ashdavies.dev 59
  30. Test Doubles Mocks fun Context(checkSelfPermission: (String) -> Int): Context =

    mock { whenever(it.checkSelfPermission(any())).thenAnswer { invocation -> checkSelfPermission(invocation.arguments[0] as String) } } val context = Context { PackageManager.PERMISSION_GRANTED } ashdavies.dev 61
  31. Refactoring Interface Segregation class MenuProvider( private val navStateStore: NavStateStore =

    NavStateStore(), ) { fun get() = combine(navStateStore.isEnabled, /* ... */) { /* ... */ } } class NavStateStore { val isEnabled: Flow<Boolean> = /* ... */ fun setIsEnabled(value: Boolean) { /* ... */ } fun getLastSet(): Long { /* ... */ } } ashdavies.dev 63
  32. Refactoring Interface Segregation class MenuProvider( private val navStateStore: NavStateStore =

    NavStateStore(), ) { fun get() = combine(navStateStore.isEnabled, /* ... */) { /* ... */ } } class NavStateStore { val isEnabled: Flow<Boolean> = /* ... */ fun setIsEnabled(value: Boolean) { /* ... */ } fun getLastSet(): Long { /* ... */ } } ashdavies.dev 64
  33. Refactoring Interface Segregation interface NavStateStore { val isEnabled: Flow<Boolean> }

    class InMemoryNavStateStore : NavStateStore { override val isEnabled: Flow<Boolean> = /* ... */ fun setIsEnabled(value: Boolean) { /* ... */ } fun getLastSet(): Long { /* ... */ } } ashdavies.dev 65
  34. Refactoring Interface Segregation interface NavStateStore { val isEnabled: Flow<Boolean> }

    class PreferencesNavStateStore : NavStateStore { override val isEnabled: Flow<Boolean> = /* ... */ fun setIsEnabled(value: Boolean) { /* ... */ } fun getLastSet(): Long { /* ... */ } } ashdavies.dev 66
  35. Refactoring Interface Segregation ✨ interface NavStateStore { val isEnabled: Flow<Boolean>

    } class SentientNavStateStore : NavStateStore { override val isEnabled: Flow<Boolean> = /* ... */ fun setIsEnabled(value: Boolean) { /* ... */ } fun getLastSet(): Long { /* ... */ } } ashdavies.dev 67
  36. Refactoring Interface Segregation interface NavStateStore { val isEnabled: Flow<Boolean> }

    class NavStateStoreImpl : NavStateStore { override val isEnabled: Flow<Boolean> = /* ... */ fun setIsEnabled(value: Boolean) { /* ... */ } fun getLastSet(): Long { /* ... */ } } ashdavies.dev 68
  37. Refactoring Objects class MenuProvider( private val menuDefaults: MenuStateDefaults = MenuStateDefaults,

    ) { /* ... */ } object MenuStateDefaults { val iconWidth = 24 } ashdavies.dev 69
  38. Refactoring Objects class MenuProvider( private val menuProperties: MenuStateProperties = MenuStateProperties.Default,

    ) { /* ... */ } interface MenuStateProperties { val iconWidth: Int companion object Default : MenuStateProperties { override val iconWidth = 24 } } ashdavies.dev 70
  39. Refactoring Objects ! class MenuProvider( private val menuProperties: MenuStateProperties =

    MenuStateProperties(), ) { /* ... */ } interface MenuStateProperties { val iconWidth: Int companion object { operator fun invoke(): MenuStateProperties { /* ... */ } } } ashdavies.dev 71
  40. Refactoring Factory Function private object MenuStateDefaults { val iconWidth =

    24 } class MenuProvider( private val menuProperties: MenuStateProperties = MenuStateProperties(), ) { /* ... */ } fun interface MenuStateProperties { val iconWidth: Int } fun MenuStateProperties( iconWidth: Int = MenuStateDefaults.iconWidth, ) = object : MenuStateProperties { override val iconWidth = iconWidth } ashdavies.dev 72
  41. Testing Assertions data class WaterState( val temperature: Int, ) fun

    interface Heater { fun heat(water: WaterState): WaterState } @Test fun `should produce water for English Breakfast Tea`() { val heater = Heater { it.copy(temperature = 95) } val thermosiphon = Thermosiphon(heater) val initial = WaterState(21) val state = thermosiphon.pump(initial) assertTrue(state.temperature >= 95) } ashdavies.dev 73
  42. Testing Assertions data class WaterState( val temperature: Int, + val

    filtered: Boolean, ) fun interface Heater { fun heat(water: WaterState): WaterState } @Test fun `should produce water for English Breakfast Tea`() { val heater = Heater { it.copy(temperature = 95) } val thermosiphon = Thermosiphon(heater) val initial = WaterState(21, false) val state = thermosiphon.pump(initial) assertTrue(state.temperature >= 95) } ashdavies.dev 74
  43. Testing Assertions data class WaterState( val filtered: Boolean, val temperature:

    Int, ) fun interface Heater { fun heat(water: WaterState): WaterState } @Test fun `should produce water for English Breakfast Tea`() { val heater = Heater { it.copy(temperature = 95) } val thermosiphon = Thermosiphon(heater) val initial = WaterState(21, true) val expected = WaterState( filtered = true, temperature = 95, ) assertEquals(expected, thermosiphon.pump(initial)) } ashdavies.dev 75
  44. Testing Assertions data class WaterState( val filtered: Boolean, val temperature:

    Int, ) fun interface Heater { fun heat(water: WaterState): WaterState } @Test fun `should produce water for English Breakfast Tea`() { val heater = Heater { it.copy(temperature = 95) } val thermosiphon = Thermosiphon(heater) val initial = WaterState(21, true) val expected = WaterState( filtered = true, temperature = 95, ) assertEquals(expected, thermosiphon.pump(initial)) } ashdavies.dev 76
  45. Conclusion General — Prefer functional interfaces wherever possible — Utilise

    factory functions to isolate behaviour — Segregate behaviour into smaller interfaces ashdavies.dev 77
  46. Conclusion Testing — Avoid using mocks unless absolutely necessary —

    Restrict test behaviour to function body — Keep individual tests idempotent — It's OK to repeat yourself ashdavies.dev 78
  47. Out-Takes: TDD private fun isEven(number: Int): Boolean { // Added

    to pass unit test if (number == 11) { return false } // Added to pass unit test if (number == 11) { return false } // Fix for Ticket 12846 if (number == 11407) { return false } // Fix for Ticket 14336 if (number == 9) { return false } return true } ashdavies.dev 81