うごいてるコードレビュー

͏͍ͯ͝Δ ίʔυϨϏϡʔ JUPDIBO IUUQJOTJEFQJYJWOFUFOUSZ ͏͝Πϥ5FDI5BMLT

͏͝Πϥഒ

ൃදऀʹ͍ͭͯ w ͍ͱ͓ w !J w IUUQJUPDIBOKQ w ϐΫγϒΞϧόΠτ೥໨ʹಥೖ w
ॳΊͯձࣾͰ-5͠·͢

ൃදऀʹ͍ͭͯ w "OESPJEΞϓϦ։ൃऀ w ൃදऀͷதͰ࠷΋͏͝Πϥʹؔͯ͠  ஌ݟ͕ͳ͍Ͱ͢

͏͝Πϥʹ͍ͭͯͪΐͬͱߟ͑ͯΈͨ | ΒΜͩΉ͚Μ͖Ύ͏͡ΐ! http://rndomhack.com/2014/07/04/%E3%81%86%E3%81%94%E3%82%A4%E3%83%A9%E3%81%AB %E3%81%A4%E3%81%84%E3%81%A6%E3%81%A1%E3%82%87%E3%81%A3%E3%81%A8%E8%80%83 %E3%81%88%E3%81%A6%E3%81%BF%E3%81%9F/ l࣮ࡍͷ࿩͸͏͝Πϥ 5FDI5BMLTͳΜ͔ʹ ߦ͚͹͍͍͔΋͠Ε· ͤΜɻz

࣮ࡍͷ࿩Λ͠·͢

͏͝Πϥͱ͸ w ͏͘͝Πϥετͷུ w දهͷΏΕ

͏͝Πϥͱ͸ w ͏͝ΠϥPS͏͘͝Πϥετ  PS6HPJSBPS"OJNBUFE*MMVTUSBUJPO w ͏͝Πϥ͕ਖ਼໊ࣜশ͔Ͳ͏͔Θ͔Βͳ͘ ͳ͖ͬͯͨ w ͜ͷ৔ʹ͓͍ͯ͸͏͝ΠϥͰਐߦ͠·͢

ίʔυϨϏϡʔ  ʹ͍ͭͯ

"OESPJEΞϓϦ w ଞϓϩδΣΫτͰ͸(JU-BC͕࢖ΘΕͯ ͍Δ͕ɺΞϓϦͱ͍͔ͭ͘ͷϓϩδΣ ΫτͰ͸(JU)VC͕࢖ΘΕ͍ͯΔ w ݱࡏ"OESPJEΞϓϦͷίʔυΛॻ͍ͯ ͍Δͷ͸ࣾһ໊ ΞϧόΠτ໊

ϨϏϡʔͷྲྀΕ

1VMM3FRVFTU ཱ͕ͭ

ϨϏϡʔͯ͠ʂ ཉٻߴ·Δ

ϨϏϡʔΛ͢Δ

Αͦ͞͏

IUUQTUXJUUFSDPNUPUPUPTIJTUBUVTFT

-(5. -00,4(00%50.& IUUQXXXMHUNJOJ;6;

ಈ͖ॏཁ

ίʔυϨϏϡʔʹ ಈ͖Λ

͏͍ͯ͝Δ ίʔυϨϏϡʔ

DPNNFOUT

BEEJUJPOT EFMFUJPOT

େྔͷมߋ ഭΓ͘Δίʔυ

్தͰϨϏϡΞ͕ มΘͬͨΓͨ͠

มߋଟ͗ͯ͢ ݟΕͳ͍

ͦ͜ΛͳΜͱ͔

ػೳ໘ͷϨϏϡʔ͸ લͷϨϏϡΞ͕طʹ ͍͍ͩͨ΍͍ͬͯͨ

ओʹ࡞๏ͳͲͷ Α͘ͳ͍ίʔυ ΛϨϏϡʔͨ͠

ίʔυͷ࿩

ਓͷϨϏϡΞ !@@DIPDPNFMPO !J

ྫ֎Λ QSJOU4UBDL5SBDF͠ͳ͍ ✘ Bad ! 1 try { 2 //
something code 3 } catch (SomethingException e) { 4 e.printStackTrace(); 5 }

ྫ֎Λ QSJOU4UBDL5SBDF͠ͳ͍ ✔ Good ! 1 try { 2 //
something code... 3 } catch (SomethingException e) { 4 // custom log utils 5 LogUtils.e("PixivAndroidApp", "SomethingException", e); 6 }

*%&͕ੜ੒͢Δ ίϝϯτΛফ͢ ✘ Bad ! 1 package jp.pxv.android; 2 3
/** 4 * Created by Chobi on 2014/05/26. 5 */ 6 7 public class CreatedByComment { IUUQTUBDLPWFSqPXDPNRVFTUJPOT

*%&͕ੜ੒͢Δ ίϝϯτΛফ͢ ✔ Good ! 1 package jp.pxv.android; 2 3
public class CreatedByComment { IUUQTUBDLPWFSqPXDPNRVFTUJPOT

ఆ਺͸TUBUJDpOBMͰ 1 public class Constants { 2 // ✘ Bad
3 private final String BAD_FOO = "foo"; 4 private final String BAD_BAR = "bar"; 5 6 // ✔ Good 7 private static final String GOOD_FOO = "foo"; 8 private static final String GOOD_BAR = "bar"; 9 }

ม਺໊ ✘ Bad 1 @Override 2 public void onProgressChanged(float progressRate)
{ 3 final float _progressRate = progressRate; 4 uiThreadHandler.post(new Runnable() { 5 @Override 6 public void run() { 7 if (_progressRate == 1) { 8 progressBar.setVisibility(View.GONE); 9 } 10 } 11 }); 12 }

ม਺໊ ✔ Good 1 @Override 2 public void onProgressChanged(final float
progressRate) { 3 uiThreadHandler.post(new Runnable() { 4 @Override 5 public void run() { 6 if (progressRate == 1) { 7 progressBar.setVisibility(View.GONE); 8 } 9 } 10 }); 11 }

ଞʹ͸ w ্ྲྀϒϥϯνͰ͢Ͱʹมߋ͞Ε͍ͯΔ ΋ͷ͕1VMM3FRVFTUͷϒϥϯνͰ΋ಉ ͡มߋͷผͷDPNNJUΛ͍ͯ͠Δ w ˠఆظతʹ্ྲྀϒϥϯνΛ  git merge --no-ffͰऔΓࠐΊ͹
Α͍

·ͱΊ w มߋ͕ଟ͗͢ΔͱϨϏϡʔ͠ʹ͍͘ w ϨϏϡʔΛසൟʹߦ͏ͳͲ͢Δඞཁ͕͋Δ ˠ1VMM3FRVFTUͷ୯ҐΛࡉ͔͘͢Δ w ͏͔͝ͳ͍ίʔυΑΓ͸͏͘͝ίʔυͷ΄ ͏͕͍͍ w
ίʔυ͸அવ͖Ε͍ͳ΄͏͕͍͍

͝ਗ਼ௌ͋Γ͕ͱ͏ ͍͟͝·ͨ͠

うごいてるコードレビュー

うごいてるコードレビュー

More Decks by Kazunori Jo

Other Decks in Programming

Featured

Transcript