Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Confident refactors

Avatar for Mehdi Lahmam B. Mehdi Lahmam B.
June 19, 2017
Technology
1
130

Confident refactors

Avatar for Mehdi Lahmam B.

Mehdi Lahmam B.

June 19, 2017
Tweet

More Decks by Mehdi Lahmam B.

See All by Mehdi Lahmam B.
Beyond code: Becoming a Product Engineer
Avatar for Mehdi Lahmam B. mehlah
0
34
Possible to measure developer productivity?
Avatar for Mehdi Lahmam B. mehlah
0
43
PG FDW FTW
Avatar for Mehdi Lahmam B. mehlah
0
170
Product culture
Avatar for Mehdi Lahmam B. mehlah
0
72
OpenAPI and AsyncAPI specifications as contracts
Avatar for Mehdi Lahmam B. mehlah
0
660
Technical Debt
Avatar for Mehdi Lahmam B. mehlah
1
290
Data informed growth
Avatar for Mehdi Lahmam B. mehlah
0
230
Serverless Ruby and AWS Lambda
Avatar for Mehdi Lahmam B. mehlah
0
170
Middleware all the things
Avatar for Mehdi Lahmam B. mehlah
2
860

Other Decks in Technology

See All in Technology
レガシーで硬直したテーブル設計から変更容易で柔軟なテーブル設計にする
Avatar for Red Frasco red_frasco
4
490
LINEスキマニ/LINEバイトにおけるバックエンド開発
Avatar for LINEヤフーTech (LY Corporation Tech) lycorptech_jp
PRO
0
340
アジャイル社内普及ご近所さんマップを作ろう / Let's create an agile neighborhood map
Avatar for Satoshi Harada psj59129
1
140
Kubernetesと共にふりかえる! エンタープライズシステムのインフラ設計・テストの進め方大全
Avatar for 高棹大樹 daitak
0
420
Dev Containers と Skaffold で実現する クラウドネイティブ開発環境 ローカルのみという制約に挑む / Cloud-Native Development with Dev Containers and Skaffold: Tackling the Local-Only Constraint
Avatar for 株式会社ビットキー / Bitkey Inc. bitkey
PRO
0
120
不確実性に備える ABEMA の信頼性設計とオブザーバビリティ基盤
Avatar for Katsutoshi Nagaoka nagapad
3
5k
やり方は一つだけじゃない、正解だけを目指さず寄り道やその先まで自分流に楽しむ趣味プログラミングの探求 2025-11-15 YAPC::Fukuoka
Avatar for すぎゃーん sugyan
3
920
Service Monitoring Platformについて
Avatar for LINEヤフーTech (LY Corporation Tech) lycorptech_jp
PRO
0
320
Post-AIコーディング時代のエンジニア生存戦略
Avatar for shinoyu shinoyu
0
300
個人から巡るAI疲れと組織としてできること - AI疲れをふっとばせ。エンジニアのAI疲れ治療法 ショートセッション -
Avatar for kichion kikuchikakeru
4
1.8k
明日から真似してOk！NOT A HOTELで実践している入社手続きの自動化
Avatar for kajinari nkajihara
1
870
【M3】攻めのセキュリティの実践！プロアクティブなセキュリティ対策の実践事例
Avatar for mizu axelmizu
0
180

Featured

See All Featured
Exploring the Power of Turbo Streams & Action Cable | RailsConf2023
Avatar for Kevin Liebholz kevinliebholz
36
6.1k
RailsConf & Balkan Ruby 2019: The Past, Present, and Future of Rails at GitHub
Avatar for Eileen M. Uchitelle eileencodes
140
34k
Building Adaptive Systems
Avatar for Chris Keathley keathley
44
2.8k
Large-scale JavaScript Application Architecture
Avatar for Addy Osmani addyosmani
514
110k
The Illustrated Children's Guide to Kubernetes
Avatar for Chris Short chrisshort
51
51k
The Psychology of Web Performance [Beyond Tellerrand 2023]
Avatar for Tammy Everts tammyeverts
49
3.2k
[Rails World 2023 - Day 1 Closing Keynote] - The Magic of Rails
Avatar for Eileen M. Uchitelle eileencodes
37
2.6k
JavaScript: Past, Present, and Future - NDC Porto 2020
Avatar for David Neal reverentgeek
52
5.7k
For a Future-Friendly Web
Avatar for Brad Frost brad_frost
180
10k
Music & Morning Musume
Avatar for Bryan Veloso bryan
46
7k
We Have a Design System, Now What?
Avatar for Morgane Peng morganepeng
54
7.9k
The Cost Of JavaScript in 2023
Avatar for Addy Osmani addyosmani
55
9.3k

Transcript

  1. Confident Refactors

  2. Mehdi Lahmam @mehlah

  3. 25kV Rails app, started in Feb 2009 Never rewritten 23k+

    commits from 52 contributors

  4. Ruby is a massively successful language!

  5. Early success Making it easy to make new things

  6. Later success Making it easy to maintain old things

  7. Today, let’s refactor some legacy code

  8. Today, let’s refactor some legacy code

  9. Refactor - verb To change the design of code without

    changing its observable behavior.

  10. Refactor - verb To change in advance of a new

    feature or bug fix, making the job easier.

  11. Today, let’s refactor some legacy code

  12. Legacy - noun Old code.

  13. Legacy - noun Code without tests.

  14. Legacy - noun Code that we don’t like.

  15. Legacy - noun Code we don’t understand well enough
 to

    change confidently.

  16. Today, let’s refactor some legacy code

  17. Refactoring is hard

  18. Refactoring legacy code is very hard

  19. Easy to accidentally break functionality

  20. Legacy refactors feels unsafe

  21. Legacy refactors are hard to sell

  22. Business priority Cost / risks

  23. Business priority Cost / risks New features

  24. Business priority Cost / risks New features Bugs fixes

  25. Business priority Cost / risks New features Bugs fixes Testing

  26. Business priority Cost / risks New features Bug fixes Testing

    Refactoring

  27. Business priority Cost / risks New features Bug fixes Testing

    Refactoring no selling needed easy to sell can often sell very hard to sell

  28. Selling refactoring is hard ⏲ ⛔

  29. Business priority Cost / risks Refactoring

  30. Too much pressure ⏳ ⚒

  31. Refactors are scary

  32. What techniques we have? PDD - Pray Driven Development Fowler’s

    refactoring book Characterization testing A/B testing, experiments

  33. Refactors as surgeries

  34. Refactors as surgeries Requires careful planning Follow a clear process

    Multiple observations Flexible tools Things can get bloody

  35. 1. Plan 2. Cut 3. Record 4. Validate 5. Refactor

    6. Verify 7. Compare 8. Fallback 9. Delete Clear process
  36. None
  37. None
  38. None

  39. Cut

  40. Record

  41. Validate ✅

  42. Refactor <Insert magic here />

  43. Verify

  44. Compare ⚖

  45. Fallback

  46. Delete ✂

  47. We dit it

  48. We dit it Time to celebrate hard