「コード品質向上のテクニック」連載継続の秘訣

ʮίʔυ඼࣭޲্ͷςΫχοΫʯ ࣥචܧଓͷൿ݃ .VOFUPTIJ*TIJLBXB

-*/&Ϡϑʔͷιϑτ΢ΣΞΤϯδχΞ ৽ଔ࠾༻ɾ৽ଔڭҭͷվળ -*/&$MJFOU "OESPJEJ04 ͷ։ൃ ଞ։ൃ෦ॺͷٕज़αϙʔτ ϒϩά࿈ࡌίʔυ඼࣭޲্ͷςΫχοΫ
ॻ੶ಡΈ΍͍͢ίʔυͷΨΠυϥΠϯ ΤϯδχΞνʔϜͷੜ࢈ੑͷߴΊํ .VOFUPTIJ*TIJLBXB

-*/&Ϡϑʔ5FDI#MPH্ͷ࿈ࡌهࣄ ίʔυ඼࣭ʹؔ͢Δ5JQT ೥݄͔Β΄΅ຖि࿈ࡌ ݱࡏྦྷܭճ ίʔυ඼࣭޲্ͷςΫχοΫ IUUQTUFDICMPHMZDPSQDPKQKBDPEFSFWJFXTFSJFT

ܧଓ͢Δൿ݃͸େ͖ͭ͘ ڞ༗ͷʮ৔ʯΛఆظతͳΠϕϯτͱͯ͠ઃ͚Δ ڱ͍ൣғ؆୯ͳܗ͔ࣜΒஈ֊తʹڞ༗͢Δ ͜ͷηογϣϯΛߦͰ

ϒϩάهࣄࣥචͷྲྀΕ ࣥචܧଓͷൿ݃ Ξ΢τϓοτΛ૿΍͢ํ๏ 5PQJDT

-*/&$MJFOU෦ॺ಺Ͱڞ༗͢ΔϨϙʔτ͕ىݪ 3FWJFX$PNNJUUFFͷ׆ಈͱͯ͠ϨϙʔτΛڞ༗ ଞͷ։ൃ෦ॺʹ΋ϨϙʔτΛڞ༗ ϨϙʔτΛϒϩάهࣄͱͯ͠ฤूɾެ։ ϒϩάهࣄࣥචͷྲྀΕ

-*/&$MJFOU෦ॺͷίʔυ඼࣭޲্ͷऔΓ૊Έ .FSHFࡁΈͷίʔυΛ࠶౓ϨϏϡʔ ӳޠͷϨϙʔτΛ෦ॺͰڞ༗ ຖि 3FWJFX$PNNJUUFFͷ׆ಈ Development team merge
request review Codebase Review committee review feedback discussion “Twemoji” © Twitter, Inc and other contributors (Licensed under CC BY 4.0) https://twemoji.twitter.com/ report

-*/&$MJFOU෦ॺͷίʔυ඼࣭޲্ͷऔΓ૊Έ .FSHFࡁΈͷίʔυΛ࠶౓ϨϏϡʔ ӳޠͷϨϙʔτΛ෦ॺͰڞ༗ ຖि ೥ޙظ͔Β໿೥൒ܧଓ 3FWJFX$PNNJUUFFͷ׆ಈ

-*/&$MJFOUಠࣗͷίʔυͷॻ͖ํϧʔϧ ϞόΠϧΫϥΠΞϯτྖҬϓϩάϥϛϯάݴޠݻ༗ͷςΫχοΫ ιϑτ΢ΣΞ։ൃҰൠͷϕετϓϥΫςΟε ଞͷ։ൃ෦ॺʹ΋ڞ༗Ͱ͖Δ 8FCGSPOUFOE#BDLFOE Ϩϙʔτͷ಺༰

աڈͷهࣄ͔Βιϑτ΢ΣΞ։ൃҰൠͷτϐοΫΛબผ ӳޠ͔Β೔ຊޠʹ຋༁ ࿩͠ʹ͔ͬͨ͘఺ޡղΛট͘఺ͳͲͷิ଍ ଞͷ։ൃ෦ॺ΁ͷڞ༗

೔ຊޠԽͨ͠ϨϙʔτΛ΄΅ͦͷ··هࣄʹ ࿩͠ʹ͔ͬͨ͘఺ΛՃචमਖ਼ ࣾ಺ߍਖ਼πʔϧੜ੒"*Ͱߍਖ਼ 5FDI#MPHهࣄ΁

-*/&$MJFOU෦ॺ಺Ͱڞ༗͢ΔϨϙʔτ͕ىݪ 3FWJFX$PNNJUUFFͷ׆ಈͱͯ͠ϨϙʔτΛڞ༗ ଞͷ։ൃ෦ॺʹ΋ϨϙʔτΛڞ༗ ϨϙʔτΛϒϩάهࣄͱͯ͠ฤूɾެ։ ϒϩάهࣄࣥචͷྲྀΕ ࠶ܝ

·ͣ͸෦ॺ಺޲͚ʹॻ͘ ෦ॺ಺ͱ͍͏҆৺ײ ఆظϛʔςΟϯάͷϓϨογϟʔ ஈ֊తʹڞ༗ൣғΛ޿͛Δ ແཧͷͳ͍ࠩ෼ ஈ֊͝ͱͷόοϑΝ
ࣥචܧଓͷൿ݃

ؒҧ͍ͬͯͯ΋ڐ͞ΕΔͱ͍͏৺ཧత҆શੑ ӳޠͷจ๏΍ޠኮͷؒҧ͍ ίʔυͷؒҧ͍ ओு΍ετʔϦʔͷؒҧ͍ ਂࠁʹ೰·ͣʹॻ͖࢝ΊΒΕΔ ෦ॺ಺ͱ͍͏҆৺ײ

࿩͢͜ͱʹΑΔվળ఺ͷൃݟ ΑΓೲಘ͠΍͍͢ετʔϦʔ ิ଍͢Δ΂͖આ໌ ෦ॺ಺ͱ͍͏҆৺ײDPOU A ͱ B ͕୅දྫͰ͢
͋ͱ C ΋ॏཁͳྫͰ͢Ͷ ͋ͱͰ C Λิ଍͓ͯ͜͠͏   Report Foo    ୅දྫ  A: ...  B: ... “Twemoji” © Twitter, Inc and other contributors (Licensed under CC BY 4.0) https://twemoji.twitter.com/

ʮΞώϧͪΌΜʯʹ࿩ͯ͠໰୊Λ੔ཧ͢Δख๏ ݩདྷ͸σόοάͷख๏ 5IF1SBHNBUJD1SPHSBNNFSͰ঺հ ࿩͢͜ͱͰࢥߟΛ੔ཧଞਓΛ൥Θͤͳ͍ 3VCCFS%VDLJOH “A rubber duck
assisting with debugging some Java code in NetBeans.”  © Tom Morris (Licensed under CC BY-SA 3.0)  https://commons.wikimedia.org/wiki/File:Rubber_duck_assisting_with_debugging.jpg

ίετΛ౓֎ࢹ͢Ε͹ਓͷ΄͏͕ޮՌ͕ߴ͍ ཧղͷఔ౓Λ؍࡯Ͱ͖Δ ૬ख͔Βͷ࣭໰΍ϑΟʔυόοΫ͕͋Δ 3VCCFS%VDLJOHΑΓ΋ʮ༉அʯ͠ͳ͍ Ϩϙʔτͷڞ༗ͦͷ΋ͷ͕༗ҙٛ ͷ͸ͣ
ࠓޙͷઃܭίʔσΟϯάϨϏϡʔΛվળͰ͖Δ Ϩϙʔτͷվળ͸͋͘·Ͱ΋ʮ͍ͭͰʯ 3VCCFS%VDLJOHWTਓʹ࿩͢

ࣥචܧଓͷൿ݃

ڞ༗ϛʔςΟϯάΛຖि༵ۚʹݻఆ ಥવͷΩϟϯηϧ͕໎࿭ʹͳΔ ଟڌ఺ ௨༁ऀ ॻ͔͟ΔΛಘͳ͍ঢ়گΛ࡞Δ ఆظϛʔςΟϯάͷϓϨογϟʔ

ීஈ͔Βͷωλ୳͠ ίʔυϨϏϡʔͰͷؾ෇͖ 3FWJFX$PNNJUUFFϝϯόʔͱͷࡶஊ աڈͷΞ΢τϓοτͷಡΈฦ͠ ωλͷετοΫΛ4MBDLͷUJNFTʹϝϞ͓ͯ͘͠ ఆظϛʔςΟϯάͷϓϨογϟʔDPOU

ࣥචܧଓͷൿ݃

֤ஈ֊Ͱͷʮ࠷௿ϥΠϯʯΛ௿Ίʹઃఆ ແཧͷͳ͍ࠩ෼ Slack ͷ  ϝϞ ෦ॺ಺  Ϩϙʔτ ࣾ಺  Ϩϙʔτ ϒϩάهࣄ
࿩ͤ͹఻ΘΔ ೔ຊޠʹͳ͍ͬͯΔ ࣄ࣮ & ଥ౰Ͱ͋Δ ࠷௿ϥΠϯ Nice to Have ಡΈ΍͍͢  ߏ੒/จষʹͳ͍ͬͯΔ Ϩϙʔτ͚ͩͰ  ҙຯ͕෼͔Δ ؒҧ͍͕  मਖ਼͞Ε͍ͯΔ ֤ஈ֊͕ʮͱΓ͋͑ͣʯ׬ྃͰ͖ΔΑ͏ʹ͢Δ

ࣥචܧଓͷൿ݃

֤ஈ֊Ͱωλ΍ૉࡐΛͨΊ͓ͯ͘ ஈ֊͝ͱͷόοϑΝ Slack ͷ  ϝϞ ෦ॺ಺  Ϩϙʔτ ࣾ಺  Ϩϙʔτ ϒϩάهࣄ
1 ~ 3 िؒ෼ 1 ~ 3 िؒ෼ 5 िؒ෼ ωλͷݸ਺ ෦ॺ಺ࣾ಺ڞ༗͕Ωϟϯηϧ͞Εͯ΋ϒϩάެ։ΛܧଓՄೳ

ࣥචܧଓͷൿ݃

Ξ΢τϓοτ͸ʮखஈʯ ໨తԽ͠ͳ͍ ໨తͷྫ ૊৫΁ͷ৘ใͷ஝ੵʹΑΔੜ࢈ੑͷ޲্ ૊৫΍ݸਓͷϏδϏϦςΟ޲্ ϦΫϧʔςΟϯά ίϥϘϨʔγϣϯ
Ξ΢τϓοτͦͷલʹ

৺ཧతϋʔυϧͱίετ Ͳ͏ͤΈΜͳ஌͍ͬͯΔ͜ͱͩΖ͏͠ ॻ͍ͨ͜ͱ͕ؒҧ͍ͬͯͨΒݏͩͳ จষࢿྉ࡞੒͕໘౗͍͘͞ ͕࣌ؒͳ͍ Ξ΢τϓοτͷ્֐ཁҼ
৺ཧత҆શੑ͕ߴ͍ίετ͕খ͍͞ํ๏͕ඞཁ

Ξ΢τϓοτͷൣғͱϑΥʔϚϧ͞ ൣғ ޿ ൣғ ڱ Ұൠެ։ ݸਓ Ո଒ ༑ਓ ٕज़ίϛϡχςΟ
νʔϜ ࣾ಺ ϑΥʔϚϧ ΧδϡΞϧ ঎ۀग़൛ ͭͿ΍͖ ࡶஊ ϝϞॻ͖ ϓϨθϯςʔγϣϯ Ϩϙʔτ ϛʔςΟϯά ϒϩάهࣄ SNS ϙετ

੄໺ ڱ͍ൣғΧδϡΞϧͳΞ΢τϓοτ Λ૿΍͢ͱΑ͍ Ͳ͏ͤΈΜͳ஌͍ͬͯΔ͜ͱͩΖ͏͠ ˠνʔϜϝϯόʔʹʮ༗༻ͳ஌ࣝͩʯͱݴͬͯ΋Β͑Δ͔΋ ݴ͏͜ͱ͕ؒҧ͍ͬͯͨΒݏͩͳ ˠϨϏϡʔͯ͠΋Β͑͹҆৺͢Δ͔΋
͕࣌ؒͳ͍ ˠνϟοτ΍ϝϞॻ͖͔Β࢝ΊΒΕΔ͔΋ ൣғͱϑΥʔϚϧ͞ͷܦݧଇ

-*/&Ϡϑʔͷιϑτ΢ΣΞΤϯδχΞ ৽ଔ࠾༻ɾ৽ଔڭҭͷվળ -*/&$MJFOU "OESPJEJ04 ͷ։ൃ ଞ։ൃ෦ॺͷٕज़αϙʔτ ϒϩά࿈ࡌίʔυ඼࣭޲্ͷςΫχοΫ
ॻ੶ಡΈ΍͍͢ίʔυͷΨΠυϥΠϯ ΤϯδχΞνʔϜͷੜ࢈ੑͷߴΊํ .VOFUPTIJ*TIJLBXB ࠶ܝ

ग़ൃ఺͸ʮಉ͡આ໌Λ܁Γฦ͢ͷ͸େมʯ ίʔυϨϏϡʔ࣌ͷޱ಄આ໌ ͘͝ڱ͍ൣғͰͷϓϨθϯςʔγϣϯ ଞ෦ॺ΍ւ֎ڌ఺΁ͷϓϨθϯςʔγϣϯ ࣾ಺ެࣜͷڭҭࢿྉҰൠެ։ॻ੶ࣥච <έʔεελσΟ>ಡΈ΍͍͢ίʔυͷΨΠυϥΠϯ
Prisoner's dilemma Team productivity may decrease if we focus on the personal Eng. A ┃ │ ┃ Write clean code │ Write hacky code Eng. B ┃ │ ━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━┿━━━━━━━━━━━━━━━━━━━ ┃ 8 │ 10 Write clean code ┃ │ ┃ 8 │ 1 ──────────────────╂──────────────────┼─────────────────── ┃ 1 │ 2 Write hacky code ┃ │ ┃ 10 │ 2 Introduction and Principles > Introduction Prisoner's dilemma Team productivity may decrease if we focus on the personal productivity Bob Alice Hacky Readable Readable Hacky 8 8 10 1 1 10 2 2 Introduction and Principles > Introduction

͍ܰؾ࣋ͪͰͰ͖Δ͜ͱΛ஝ੵ͢Δ ϝϞॻ͖΍ࡶஊ ʮ΋͏গ͠޿͍ൣғͰ఻͑ͯΑ͍͔΋ʯͱ͍͏੠ֻ͚Λ͢Δ ʮͦΕɺͷൃදʹͰ͖ͦ͏ʯʮͷهࣄʹྑͦ͞͏ʯ ެ։ͷஈ֊Λઃ͚Δ ˠνʔϜˠࣾ಺ˠҰൠެ։
ࡶஊˠϊʔτˠϓϨθϯςʔγϣϯ Ξ΢τϓοτΛܧଓ͢Δ৺ߏ͑

ʮίʔυ඼࣭޲্ͷςΫχοΫʯࣥචܧଓͷൿ݃ ఆظతͳΠϕϯτڱ͍ൣғ ΧδϡΞϧͳ΋ͷ͔Β ஈ֊తͳެ։ແཧͷͳ͍ࠩ෼ ੒ՌͷόοϑΝ Ξ΢τϓοτҰൠ΁ͷԠ༻ ੄໺Λ޿͛Δνϟοτ΍ϝϞ ͷࡶஊͷ஝ੵ ·ͱΊ

「コード品質向上のテクニック」連載継続の秘訣

「コード品質向上のテクニック」連載継続の秘訣

More Decks by LINEヤフーTech (LY Corporation Tech)

Other Decks in Technology

Featured

Transcript